C++ Phone Dialer Program

I am having issues with my code giving me this error:

1>LAB04.obj : error LNK2019: unresolved external symbol "void __cdecl AcknowledgeCall(char,char,char,char,char,char,char ,char)" (?AcknowledgeCall@@YAXDDDDDDDD@Z) referenced in function _main
1>C:\Users\Zonen\documents\visual studio 2010\Projects\LAB04\Debug\LAB04.exe : fatal error LNK1120: 1 unresolved externals
1>
1>Build FAILED.

any help and guidance would be really appreciated!

this is my program:

Code:

#include <iostream> #include <string> #include <iomanip> //Prototypes int ReadDials (char &d1, char &d2, char &d3, char &d4, char &d5, char &d6, char &d7, char &d8); int ToDigit (char &d); void AcknowledgeCall(char d1, char d2, char d3, char d4, char d5, char d6, char d7, char d8); char d = 0; using namespace std; int main() { char d1, d2, d3, d4, d5, d6, d7, d8; int ReturnValue = 0; while (ReturnValue != -5) { ReturnValue = ReadDials(d1,d2,d3,d4,d5,d6,d7,d8); switch(ReturnValue) { case -1: cout <<"ERROR- An invalid character was entered." << endl; break; case -2: cout <<"ERROR- Phone number can't begin with 0." << endl; break; case -3: cout <<"ERROR- Phone number can't begin with 555." << endl; break; case -4: cout <<"ERROR- Hyphen is not in the correct posistion." << endl; break; default: AcknowledgeCall(d1,d2,d3,d4,d5,d6,d7,d8); } } return 0; } int ReadDials (char & d1, char & d2, char & d3, char & d4, char & d5, char & d6, char & d7, char & d8) { cout << "Enter a phone number: "; cin >> d1; if (d1 == 'Q' || d1 == 'q') return -5; cin >> d2 >> d3 >> d4 >> d5 >> d6 >> d7 >> d8; int result = ToDigit(d); ToDigit(d); if (d == 0) return -2; if (d1 == 5 && d2 == 5 && d3 == 5) return -3; if (d4 != '-') return -4; if (result == -1) return -1; else return 0; } int ToDigit (char & d) { toupper(d); switch(d) { case 'A': case 'B': case 'C': d = '2'; return 0; break; case 'D': case 'E': case'F': d = '3'; return 0; break; case 'G': case 'H': case 'I': d = '4'; return 0; break; case 'J': case 'K': case 'L': d = '5'; return 0; break; case 'M': case 'N': case 'O': d = '6'; return 0; break; case 'P': case 'Q': case 'R': case 'S': d = '7'; return 0; break; case 'T': case 'U': case 'V': d = '8'; return 0; break; case 'W': case 'X': case 'Y': case 'Z': d = '9'; return 0; break; } } void AcknoweldgeCall(char d1, char d2, char d3, char d4, char d5, char d6, char d7, char d8) { cout << "Phone Number Dialed: " << d1 << d2 << d3 << d4 << d5 << d6 << d7 << d8; }

Your function name is spelled wrong.

Code:

void AcknoweldgeCall(char d1, char d2, char d3, char d4, char d5, char d6, char d7, char d8) { cout << "Phone Number Dialed: " << d1 << d2 << d3 << d4 << d5 << d6 << d7 << d8; }

you have to be kidding me, after hours of looking that is what I missed!

now that is is up and running however it seems that my ToDigit() function is not properly converting the letters to numbers nor is my switch in the main() funtion passing out error codes. Any ideas?

ToDigit converts to '2', '3', etc. Those are ASCII characters, whose numeric values are 50, 51, etc in decimal. A char can contain numeric values like 2, 3, 4, so try:

Code:

case 'A': case 'B': case 'C': d = 2; // notice no quotes ' ' break; // no need to return 0 here, do it at the end ...

I would also suggest that you eliminate the global variable d, it is probably causing some of your problems.

Jim

Quote:

Originally Posted by anduril462

ToDigit converts to '2', '3', etc. Those are ASCII characters, whose numeric values are 50, 51, etc in decimal. A char can contain numeric values like 2, 3, 4, so try:

Code:

case 'A': case 'B': case 'C': d = 2; // notice no quotes ' ' break; // no need to return 0 here, do it at the end ...

ok I will try those ideas

Quote:

Originally Posted by jimblumberg

I would also suggest that you eliminate the global variable d, it is probably causing some of your problems.

Jim

when I get rid of that global variable the compiler tells me that int ToDigit(d); the d is undeclared.

Well, of course. You still have to declare it, it just shouldn't be declared globally. Read this for details: Global Variables Are Bad.

Move the declaration into main().

Quote:

Originally Posted by anduril462

Well, of course. You still have to declare it, it just shouldn't be declared globally. Read this for details: Global Variables Are Bad.

Move the declaration into main().

thank you for the link, I made the adjustment

can anyone tell me what this means

1>test.obj : error LNK2005: _main already defined in LAB04.obj
1>C:\Users\Zonen\documents\visual studio 2010\Projects\LAB04\Debug\LAB04.exe : fatal error LNK1169: one or more multiply defined symbols found
1>
1>Build FAILED.

It means you have two or more main functions defined in two or more source files.
You cannot have more than one function with the same name.

Zonen - I was looking at your code again, have you considered using a string for the phone number instead of chars?

Quote:

Originally Posted by rmatze

Zonen - I was looking at your code again, have you considered using a string for the phone number instead of chars?

I have seen it done that way but for my class they want 8 individual variables

Ahh, I see. I was having a little fun today and I changed your code to use a string. That's why I asked. Did you get your code running?

no I am having trouble understanding what eylsia meant by having the main function defined in two or more sources.

actually I figured it out, I created a second file to test and had to remove it, now I can compile but for some reason it doesn't seem to be properly reading the numbers and relaying to my switch with the errors.

when I enter the number 555 it is supposed to give back an error from the main function switch that says you can't have a number that starts with 555 but instead all it does is sit there blinking and now responding. Not sure what in my code is wrong because in theory I thought everything looked good. not to mention if I type in a 8 character value like 565-2311 it says hyphen is in wrong position which is from my error switch and that isnt true. I don't know what I did wrong here.

matze when you made the changes you were talking about did it actually compile and do what it is supposed to do? Mine never actually properly read the numbers and through out errors like I needed it too. I am still stuck on what I messed up that it isnt doing right.

Thanks for all the updates however it really isn't necessary, you could have just edited your last post instead of bumping your own thread. You need to post your updated code.

here is my updated code with issues still:

Code:

#include <iostream> #include <string> #include <iomanip> #include <cctype> //Prototypes int ReadDials (char &d1, char &d2, char &d3, char &d4, char &d5, char &d6, char &d7, char &d8); int ToDigit (char &d); void AcknowledgeCall(char d1, char d2, char d3, char d4, char d5, char d6, char d7, char d8); using namespace std; int main() { char d1, d2, d3, d4, d5, d6, d7, d8; int ReturnValue = 0; while (ReturnValue != -5) { ReturnValue = ReadDials(d1,d2,d3,d4,d5,d6,d7,d8); switch(ReturnValue) { case -1: cout <<"ERROR- An invalid character was entered." << endl; break; case -2: cout <<"ERROR- Phone number can't begin with 0." << endl; break; case -3: cout <<"ERROR- Phone number can't begin with 555." << endl; break; case -4: cout <<"ERROR- Hyphen is not in the correct posistion." << endl; break; default: AcknowledgeCall(d1,d2,d3,d4,d5,d6,d7,d8); } } return 0; } int ReadDials (char & d1, char & d2, char & d3, char & d4, char & d5, char & d6, char & d7, char & d8) { char d = 0; cout << "Enter a phone number or Q to quit: "; cin >> d1; if (d1 == 'Q' || d1 == 'q') return -5; cin >> d2 >> d3 >> d4 >> d5 >> d6 >> d7 >> d8; int result = ToDigit(d); if (d1 == 0) return -2; if (d1 == 5 && d2 == 5 && d3 == 5) return -3; if (d4 != '-') return -4; if (result == -1) return -1; else return 0; } int ToDigit (char & d) { toupper(d); switch(d) { case 'A': case 'B': case 'C': d = 2; break; case 'D': case 'E': case'F': d = 3; break; case 'G': case 'H': case 'I': d = 4; break; case 'J': case 'K': case 'L': d = 5; break; case 'M': case 'N': case 'O': d = 6; break; case 'P': case 'Q': case 'R': case 'S': d = 7; break; case 'T': case 'U': case 'V': d = 8; break; case 'W': case 'X': case 'Y': case 'Z': d = '9'; break; } return 0; } void AcknowledgeCall(char d1, char d2, char d3, char d4, char d5, char d6, char d7, char d8) { cout << "Phone Number Dialed: " << d1 << d2 << d3 << d4 << d5 << d6 << d7 << d8; }

You only call your Todigit function once, and that is with a d you declared in the calling function. No where in your code are you actually converting anything from your input. What exactly do the requirements say?

I am supposed to be able to enter any form of a phone number for example 459-5647 should return that exactly, however if I ahve a 555-4513 it should bring back an error stating that you cant have a number with 555 as well as if you start with a 0 then there should be an error. You also need to be able to type letters so
abc-defg should come out as 222-3334 when ToDigit converts it.

Ok, well you aren't really doing any of that. Can you use a char array? Do you know of the ctype library and the functions isdigit and isalpha? Those would be great starting points.

I know that isalpha is supposed to check for the case I believe

I dont think I can use arrays yet though.

I think I finally understand why your saying that my program isnt doing what it should be doing. How about if I do my ReadDials function like this:

Code:

int ReadDial (char &d1, char &d2, char &d3, char &d4, char &d5, char &d6, char &d7, char &d8) { int returnValue = 0; cout << "Enter a phone number (Q to quit): "; cin >> d1; if(d1 == 'Q' || d1 == 'q') return -5; cin >> d2 >> d3 >> d4 >> d5 >> d6 >> d7 >> d8; returnValue = Todigit(d1); if (returnValue == -1) return returnValue; returnValue = Todigit(d2); if (returnValue == -1) return returnValue; returnValue = Todigit(d3); if (returnValue == -1) return returnValue; if (d4 != '-') return -4; returnValue = Todigit(d5); if (returnValue == -1) return returnValue; returnValue = Todigit(d6); if (returnValue == -1) return returnValue; returnValue = Todigit(d7); if (returnValue == -1) return returnValue; returnValue = Todigit(d8); if (returnValue == -1) return returnValue; if (d1 == '0') return -2; if (d1 == '5' && d2 == '5' && d3 == '5') return -3; return 0; }

Are you sure? This seems like an array problem to me. Did you cover them in class yet? Does the hw assignment say a "grouping" of chars or any derivation. This assigment basically flows:
Get input from user in format xxx-xxxx
iterate through input:
if first num is 0 then error else if alpha convert to number and store
continue iteration if - located any position besides 4, error. Else if alpha convert number and store
if first 3 numbers are 5 then error
output converted number.

ya I just looked, says no arrays, but does that code above look right?

Quote:

Originally Posted by zonen

ya I just looked, says no arrays, but does that code above look right?

Does it run and work? I am afraid your code is a bit all over the place. I think you are writing over your return value and your main error logic looks hazy. Follow the steps I posted only do them for each char instead of the iterating.

A working Solution... Finally:

Code:

# include <iostream> # include <string> # include <cctype> # include <iomanip> using namespace std; // prototypes int ReadDials (char &d1, char &d2, char &d3, char &d4, char &d5,char &d6, char &d7, char &d8); char Todigit(char &d); void AcknowledgeCall(char d1, char d2, char d3, char d4, char d5, char d6, char d7, char d8); // function main int main() { char d1, d2, d3, d4, d5, d6, d7, d8; int ReturnValue = 0; while (ReturnValue != -5) { ReturnValue = ReadDials (d1, d2, d3, d4, d5, d6, d7, d8); switch (ReturnValue) { case -1: cout << "Error- An invalid character was entered" << endl; break; case -2: cout << "Error- Phone number cannot begin with 0" << endl; break; case -3: cout << "Error- Phone number cannot begin with 555" << endl; break; case -4: cout << "Error- Hyphen is not in the correct position" << endl; break; default: AcknowledgeCall (d1, d2, d3, d4, d5, d6, d7, d8); } } return 0; } // function ReadDial int ReadDials (char &d1, char &d2, char &d3, char &d4, char &d5, char &d6, char &d7, char &d8) { int ReturnValue = 0; cout << "Enter a phone number (Q to quit): "; cin >> d1; if(d1 == 'Q' || d1 == 'q') return -5; cin >> d2 >> d3 >> d4 >> d5 >> d6 >> d7 >> d8; ReturnValue = Todigit(d1); if (ReturnValue == -1) return ReturnValue; ReturnValue = Todigit(d2); if (ReturnValue == -1) return ReturnValue; ReturnValue = Todigit(d3); if (ReturnValue == -1) return ReturnValue; if (d4 != '-') return -4; ReturnValue = Todigit(d5); if (ReturnValue == -1) return ReturnValue; ReturnValue = Todigit(d6); if (ReturnValue == -1) return ReturnValue; ReturnValue = Todigit(d7); if (ReturnValue == -1) return ReturnValue; ReturnValue = Todigit(d8); if (ReturnValue == -1) return ReturnValue; if (d1 == '0') return -2; if (d1 == '5' && d2 == '5' && d3 == '5') return -3; return 0; } //function ToDigit char Todigit(char &d) { d = toupper(d); switch(d) { case '0': case '1': case '2': case '3': case '4': case '5': case '6': case '7': case '8': case '9': break; case 'A': case 'B': case 'C': d = '2'; break; case 'D': case 'E': case 'F': d = '3'; break; case 'G': case 'H': case 'I': d = '4'; break; case 'J': case 'K': case 'L': d = '5'; break; case 'M': case 'N': case 'O': d = '6'; break; case 'P': case 'Q': case 'R': case 'S': d = '7'; break; case 'T': case 'U': case 'V': d = '8'; break; case 'W': case 'X': case 'Y': case 'Z': d = '9'; break; default: return -1; } } // function AcknowledgeCall void AcknowledgeCall(char d1, char d2, char d3, char d4, char d5, char d6, char d7, char d8) { cout << "Phone Number Dialed: " << d1 << d2 << d3 << d4 << d5 << d6 << d7 << d8 << endl << endl; }

thanks for all your help!

Since you are done, I have something similar:

Code:

int ReadDials (char &, char &, char &, char &, char &, char &, char &, char &); int ToDigit (char &); void AcknowledgeCall(char, char, char, char, char, char, char, char); int main() { char d1, d2, d3, d4, d5, d6, d7, d8; int ReturnValue = 0; while (ReturnValue != -5) { ReturnValue = ReadDials(d1, d2, d3, d4, d5, d6, d7, d8); switch(ReturnValue) { case -1: cout <<"ERROR- An invalid character was entered." << endl; break; case -2: cout <<"ERROR- Phone number can't begin with 0." << endl; break; case -3: cout <<"ERROR- Phone number can't begin with 555." << endl; break; case -4: cout <<"ERROR- Hyphen is not in the correct posistion." << endl; break; case -5: cout <<"Good bye!" << endl; break; default: AcknowledgeCall(d1, d2, d3, d4, d5, d6, d7, d8); } } return 0; } int ReadDials (char &d1, char &d2, char &d3, char &d4, char &d5, char &d6, char &d7, char &d8) { int i = 0; int result = 0; cout << "Enter a phone number in the following format (123-4567): "; cin >> d1; if(d1 == 'Q' || d1 == 'q') return -5; cin >> d2 >> d3 >> d4 >> d5 >> d6 >> d7 >> d8; if(d1 == '0') return -2; else if(d1 == '5' && d2 == '5' && d3 == '5') return -3; else if(d4 != '-') return -4; result = ToDigit(d1); if(result != 0) return result; result = ToDigit(d2); if(result != 0) return result; result = ToDigit(d3); if(result != 0) return result; result = ToDigit(d4); if(result != 0) return result; result = ToDigit(d5); if(result != 0) return result; result = ToDigit(d6); if(result != 0) return result; result = ToDigit(d7); if(result != 0) return result; result = ToDigit(d8); if(result != 0) return result; return 0; } int ToDigit(char &d) { int i = 0; for(i = 0; i < 8; i++) { if(static_cast<int>(d) < 48 || static_cast<int>(d) > 57) { switch(toupper(d)) { case 'A': case 'B': case 'C': d = '2'; break; case 'D': case 'E': case'F': d = '3'; break; case 'G': case 'H': case 'I': d = '4'; break; case 'J': case 'K': case 'L': d = '5'; break; case 'M': case 'N': case 'O': d = '6'; break; case 'P': case 'Q': case 'R': case 'S': d = '7'; break; case 'T': case 'U': case 'V': d = '8'; break; case 'W': case 'X': case 'Y': case 'Z': d = '9'; break; case '-': //skip, hyphen is OK break; default: //error, invalid input return -1; } } } return 0; } void AcknowledgeCall(char d1, char d2, char d3, char d4, char d5, char d6, char d7, char d8) { cout << "Phone Number Dialed: " << d1 << d2 << d3 << d4 << d5 << d6 << d7 << d8 << endl; }

>>int ReadDials (char &, char &, char &, char &, char &, char &, char &, char &);
You may want to read SourceForge.net: Do not remove parameter names - cpwiki

>>if(static_cast<int>(d) < 48 || static_cast<int>(d) > 57)
A reader will very likely have no idea what this means. Don't use these so called "magic numbers," because they mean nothing.
Worse still, you are relying on ANSI, which may or may not be the case. Why not just handle the cases you need, and fail on the rest?
It's essentially what you are doing already, just with a pointless if statement.

Also, you are passing in one character and processing it 8 times. Doesn't make much sense.

Thanks for the link, I'll implement that code with my prototypes from now on.

Also, I should have looked over that code a little better. I originally used a string and converted back to using chars because a string wasn't suppose to be used. That loop in ToDigit() doesn't do anything for this code.