Unable to join two strings due to Segmentation Fault

Hi,

I have two .txt files.

I am trying to combine each line from the first file with each line from the second file, using a nested loop:

Code:

---


#include <iostream>
#include <fstream>
#include <string>
#include <vector>
using namespace std;

int main ()
{
    string keyword = "";
    vector<string>vectorOfStrings;
    ifstream ifs( "anchortxt.txt" );
    string temp;

    while( getline( ifs, temp ) )

    {
        vectorOfStrings.push_back( temp );
    }

    vector<string>vectorOfStringsTwo;
    ifstream ifss( "rhwdtieronearticles.txt" );
    string temps;

    while( getline( ifss, temps ) )
    {
        vectorOfStringsTwo.push_back( temps );
    }

    for (unsigned int i=0; i<=vectorOfStrings.size(); i++)
    {


        for (unsigned int j=1; j<=i; j++)
        {
            string aa = vectorOfStrings[i] + vectorOfStringsTwo[j];
            cout << aa << endl;
            aa.clear();
        }
    }

    return 0;
}

---

I am using Code::Blocks on Ubuntu 64bit.

When I try to build and run the program I get the following:

Quote:

---

Segmentation fault

---

The two text files contain strings/lines which are around 500 characters in length and contain many different characters such as % | ' , .

When I run the program on txt files that contain just around 30 chars per line, with just a-z characters in, it runs fine.

Can anyone suggest why this is occurring?

Many thanks :)

There is a big difference between < and <=.

To elaborate, the error is here:
for (unsigned int i=0; i<=vectorOfStrings.size(); i++)

Now, being C++ there are safer and more effective ways of doing this using iterators. Additionally, I am assuming since you are using std::vector here this isn't a backwards school project so let's take a look at another possible implementation to ease your efforts.

Code:

---

#include <iostream>
#include <fstream>
#include <vector>
#include <string>
/*used for stream iterators*/
#include <iterator>
#include <algorithm>

/*define our datatype*/
struct fileLine{
        std::string input;
};
/*override iterator for our datatype*/
std::istream& operator>>(std::istream& stream, fileLine& line){
        //return getline method
        return (std::getline(stream,line.input));
}
int main(void){

        //our two vectors of type fileLine
        std::vector<fileLine>stringvect1, stringvect2;
        std::ifstream file1("example1.txt");
        std::vector<fileLine>::iterator stringvect_it;

        /*Read files into our vectors, line by line using
        stream iterators*/
        std::copy(std::istream_iterator<fileLine>(file1),
                std::istream_iterator<fileLine>(),
                std::back_inserter(stringvect1));
        /*you could do the same thing with your other file*/

        /*now copy the contents of our vector out. It is possible to
        use std::copy here as well, however we will use an iterator
        for demonstration purposes*/
        stringvect_it = stringvect1.begin();
        while(stringvect_it != stringvect1.end()){
                std::cout << stringvect_it->input <<std::endl;
                ++stringvect_it;
        }

        return(0);
}

---