How to read from a file line by line and store lines in separate arrays?

say the file contains:
890809
8989
1343434324
4738294

im trying to read line by line and store each into separate arrays. not working...

Code:

---

char str_out[10][40]
file_01=fopen("test_01.txt","r");

for(i=0; i<8; i++){
fscanf(file_01, "%s\n", str_out[i]);
printf("%s",str_out[i]);}

---

Quote:

---

Originally Posted by vegan

im trying to read line by line and store each into separate arrays. not working...

---

Your code as it is doesn't even know if the file was opened correctly nor not...
Test the return value of fopen() to be sure.

1. Semicolon missing after char[10][40]

2. \n missing after the %s in your printf statement

3. How are you testing for the end of the file?

thats not a problem, suppose it opened correctly. for loop is a problem...

(1) "Suppose it opened correctly" is a dangerous assumption to make - I would listen to CommonTater here.
(2) TheBigH makes some good observations that should be corrected, if this is your actual code (and not a hasty re-write for purposes of the post).
(3) "not working" gives us no insight the possible issue at hand - could you clarify exactly how it is not working?

semicolon is there in my original code, compiler compiles everything fine. it just doesn't print the string. for loop isnt working, it should work with or without \n in printf which is just to test if it stored anything in the string. so the way it looks, i mean logically it should work, right? im just not too sure if i constructed the for loop correctly. ok here is what i have in my actual code.

Code:

---

char str_out[10][40];

if((file_01 = fopen("test_01.txt", "r")) == NULL) {
        printf("Can't open file");
        exit(1);
    }
while ( (c=getc(file_01))!=EOF )
for(i=0; i<8; i++){
fscanf(file_01, "%s\n", str_out[i]);
printf("%s\n",str_out[i]);}
printf("plz be gentle with me, im still learning");

---

It works OK when I compile it (after inserting the missing declarations for i, c, and file_01). The only problem I get is when the program runs off the end of the file if there are less than 8 lines to it. It then prints out gibberish, which is what I would expect. You should put the fscanf statement inside the while conditional to check for EOF.

edit: actually, scratch that. Get rid of the for loop altogether and replace it with a while loop that tests for EOF.

Thanks a lot TheBigH. if you made it work, then i should be able to make it work too. thanks everyone! PS. found the problem

Quote:

---

Originally Posted by vegan

semicolon is there in my original code, compiler compiles everything fine. it just doesn't print the string. for loop isnt working, it should work with or without \n in printf which is just to test if it stored anything in the string. so the way it looks, i mean logically it should work, right? im just not too sure if i constructed the for loop correctly. ok here is what i have in my actual code.

Code:

---

char str_out[10][40];

if((file_01 = fopen("test_01.txt", "r")) == NULL) {
        printf("Can't open file");
        exit(1);
    }
while ( (c=getc(file_01))!=EOF )
for(i=0; i<8; i++){
fscanf(file_01, "%s\n", str_out[i]);
printf("%s\n",str_out[i]);}
printf("plz be gentle with me, im still learning");

---

---

First your while loop is using getc() as your end of file test. This is completely doomed to failure. getc() reads one character from the file for each call... this in turn displaces your file pointer by one character per call and leaves fscanf() reading from the wrong position.

Next you are reading 8 lines from the file for every single EOF test... also doomed to failure.

Look up fscanf() and fgets() in your C library documentation... you'll find a better way.

Quote:

---

Originally Posted by vegan

Thanks a lot TheBigH. if you made it work, then i should be able to make it work too. thanks everyone! PS. found the problem

---

Good, well done.

Quote:

---

Originally Posted by TheBigH

It works OK when I compile it

---

Lesson #1 in C programming.... "Compiles" does not mean "Works".

Quote:

---

Originally Posted by CommonTater

Lesson #1 in C programming.... "Compiles" does not mean "Works".

---

Did you properly read my post, and the one I was replying to? I know the code wasn't right because it still ran off the end of the file, which I mentioned. The complaint was that it wasn't printing the strings in the input file, but when I compiled and ran it it did print them.

Thank you guys once again, I've searched half the internet looking for fscanf and fgets examples and couldn;t really find one that would help me. i just realized i shouldve prob searched for something like fscanf delimiter not just fscanf c programming.

Quote:

---

Originally Posted by CommonTater

First your while loop is using getc() as your end of file test. This is completely doomed to failure. getc() reads one character from the file for each call... this in turn displaces your file pointer by one character per call and leaves fscanf() reading from the wrong position.

---

yep, you are right. if i had time i would find a better way to do it and i will def look into it but i need to submit my assignment soon and i also have a bunch of other assignments and stupid essays due on other subjects which is pity cos they make us study unnecessary cr*p instead of focusing more on programming.

Quote:

---

Originally Posted by vegan

Thank you guys once again, I've searched half the internet looking for fscanf and fgets examples and couldn;t really find one that would help me. i just realized i shouldve prob searched for something like fscanf delimiter not just fscanf c programming.

---

These are examples, really, but you should bookmark and review these pages (the second is worth an in-depth study when you have the time).

The 'C' Library Referencing Guide
Frequently Asked Questions