Inputting with SPACES...

I can't seem to successfully output characters with spaces. I inputted using getchar().
Any other ideas?
Thank you in advance!

Code:

---

printf ("Enter the Title [Use dots instead of spaces]: ");
      int i = 0;
      int c1;
      while (( c1!= '\n')&& (i <21))
      {
      new_name->title[i] = c1;
      i++;               
      c1= (char)getchar();
      }
      new_name->title[i] = '\0';
      while  (( c1= (char) getchar()) != '\n');

---

OutPut:

Code:

---


void list_names (void)
/* List all names in the book */
{
    REMINDER *tmp_ptr; /* Traverses list */
    printf ("All names in address book:\n");
    tmp_ptr= hol;

    while (tmp_ptr != NULL)
    {
 printf ("title: %s\n",tmp_ptr->title);
}
}

---

Quote:

---

Code:

---

      int c1;
      while (( c1!= '\n')&& (i <21))

---

---

You're declaring c1 uninitialized and then using its garbage value as the while loop condition. This is a "bad thing". And even if c1 doesn't by chance start off with '\n' as the value, what's new_name->title[0] going to end up as?

Quote:

---

Originally Posted by itsme86

You're declaring c1 uninitialized and then using its garbage value as the while loop condition. This is a "bad thing". And even if c1 doesn't by chance start off with '\n' as the value, what's new_name->title[0] going to end up as?

---

I see. So would initializing c1 to zero do the trick?

No. Your list_names function doesn't actually change your pointer. It just loops over and over using the same pointer.


Quzah.

Quote:

---

Originally Posted by Nephilim

I see. So would initializing c1 to zero do the trick?

---

Only if you want new_name->title[0] to always equal zero. You should be using a do/while loop here because you want to perform an action before you check the condition.

Quote:

---

Originally Posted by bithub

Only if you want new_name->title[0] to always equal zero. You should be using a do/while loop here because you want to perform an action before you check the condition.

---

I don't think a do while loop is the answer, unless he wants to store garbage in the first spot. A while loop would work fine, but he needs to read the first character before entering the loop body:

Code:

---

while ((c1 = getchar()) != '\n' && i < 21)
{
    new_name->title[i++] = c1;  // this increments i after assigning to title
}

---

or use fgets:

Code:

---

fgets(new_name->title, 21, stdin);
// fgets stores the newline, so we will trim it if it's there
if (new_name->title[strlen(new_name->title)] == '\n') {
    new_name->title[strlen(new_name->title) = '\0';
}

---

I'll try that, thanks. I'll post back.

Works like a charm ;) Thanks.