Vectors & objects/pointers

Hello!

I'm learning my way through std vectores and c++ and can't understand one thing: how do I write code that uses the automatic way of handling memory (constructores & destructores)?

What I want to do (inside a function that returns a pointer to the created object):
- Create one Item with the atribute name set to "ball"
- Put it inside a global vector
- return the pointer to the created Item.

Code:

---

Item* makeItem(){
  std::vector<Item> bag;
  bag.push_back(*(new Item()));
  bag.back().name = "ball";
  return &(bag.back());
}

---

This sample code is the best idea of how to use I came up with. I'm pretty sure I'm missing something.
Is this really the way handle the references vs objects?

Are you referring to cleaning up items allocated with new automatically? If so, you need smart pointers.

Quote:

---

Originally Posted by kotoko

Code:

---

Item* makeItem(){
  std::vector<Item> bag;
  bag.push_back(*(new Item()));
  bag.back().name = "ball";
  return &(bag.back());
}

---

---

Don't do it like that. If you want to hold onto the address of the item inserted then you're most likely going to need to use a list, not a vector, and certainly not one that is a local variable. You don't use the new keyword to push_back an item. Assuming an appropriate constructor that takes a string, here you'd just do:

Code:

---

std::list<Item> bag;

Item* makeItem() {
    bag.push_back(Item("ball"));
    return &bag.back();
}

---

But sreiously, I strongly suspect that you're only creating problems for yourself by taking pointers to the items you insert.
One needs to look at the bigger picture. How does this fit into the rest of the program? What will it be used for?