How to implement this condition..

Hello,

I need to implement the following condition in to my program which runs in 10ms cycles:

if (FLAG)F_SW == ON, then nothing needs to happen until F_SW turns OFF, in which I then want it to toggle a different flag.

I am not certain how to set this up by using IF statements, which is basically all I use since I am not a very good programmer. So I would like to know what the best way to write this out would be? Hopefully it is fairly simple, THANKS!

What's wrong with if ((FLAG)F_SW == ON), then?

My original idea was this:

Code:

---

if ((FLAG)F_SW == ON)
{
    if ((FLAG)F_SW != ON)
    {
          (FLAG)F_SW_2 = ON;
    }
}

---

I thought that because F_SW can't be both ON and OFF, the condition would never be recognized and it would never work. Am I wrong on this?

If F_SW is volatile (e.g., comes from a hardware switch) then it could change value from one line to the next. The next question is: why not just ditch the outer if statement?

(You may also want to look into the idea of a "loop", if that's what you're trying to do.)

I can't ditch the outer if statement because I only want the second flag (F_SW_2) to trigger after the first flag (F_SW) has been on and then now turned off. Then the second flag will only stay on for a certain amount of time using a counter.

It is a flag from a hardware switch, so I suppose I will try the current idea that I have posted above, assuming that the value can change from one line to the next. Thank you for your time!

It sounds like you're trying to track a change of state from "on" to "off", rather than just what state the switch is in. Presumably, there is some loop in your code that keeps running through all these things and checking the state of F_SW. What you need is to keep track of the current state and last state:

Code:

---

FLAG last_state, curr_state;
last_state = OFF  // initialize to avoid hitting our condition on the first loop
loop
    curr_state = read switch
    if last_state == ON and curr_state == OFF  // switch went from ON to OFF
        do something

---

Yes I think that is exactly what I was looking for. I think I understand your idea, I will try to implement it in to my code. Thanks alot!!

Ok, I am trying to run this program now, but I am not sure how to set the last_state to equal the previous state. Here is what I have:

Code:

---

FLAG last_state, curr_state;
last_state = OFF

loop
    curr_state = read switch
    if last_state == ON  &&  curr_state == OFF
        F_SW = ON

---

I am trying to put ( last_state = read switch ) at the beginning of the program before the loop. Will this work? Or else how do I get it to work?

You don't want the last_state to equal the read switch -- you want the current state to be what the switch is. You want the last state to be the old value of current state.

I understand that last_state is equal to the old value of current state. I do not know how to set last_state equal to the old value.

Quote:

---

Originally Posted by dswartz2

I understand that last_state is equal to the old value of current state. I do not know how to set last_state equal to the old value.

---

What's wrong with an equal sign?

Code:

---

last_state = curr_state;

---

Quote:

---

Originally Posted by dswartz2

I understand that last_state is equal to the old value of current state. I do not know how to set last_state equal to the old value.

---

Code:

---

if (switch activated)
 old_state = current_state
 current_state = switch value

---