Printable View
Hi, everyone.
I have previously asked people to review my code, and based on feedback, I've gone through several attempts at improvement. May I ask people to look at it once again? I'm doing all the source files alphabetically. This is an open-source Wikipedia bot.
TIA,
Richard
SourceForge.net Repository - [autobotwiki] Contents of /accessory_functions.h
SourceForge.net Repository - [autobotwiki] Contents of /accessory_functions.c
You seriously need to grow some confidence.
Really... if you don't trust your own coding skills, take time off from the project and take a proper course in C and or C++ programming...
We've all told you repeatedly there are serious deficiencies in your coding skills and style... but I still see them in the code posted. If you aren't interested in learning you may want to consider not asking us to abuse you yet again.
So what are the deficiencies? I thought I addressed them all.
The casts are deliberate - to gain the ability to compile unmodified as C++.
Richard
> to gain the ability to compile unmodified as C++.
First you need to read this, to learn that C and C++ do not overlap, simply by throwing in a load of casts.
Incompatibilities Between ISO C and ISO C++
Good C doesn't need casts.
Good C++ doesn't need casts.
Each cast is potentially a lost opportunity for the compiler to tell you that you've made a mess of something.
You should pick ONE language and stop trying to write polyglots
The style didn't seem too bad to me, FWIW.
Some general points.
1. Remove all the comments along the line of "added to shut the compiler up".
Add
#include <assert.h>
and put
assert(0);
in all the "impossible" places.
In a debug build, this would at least halt in a predictable manner if the unexpected happened.
2. 517 if ((strcmp (h->szloginname, "RichardcavellBot") == 0)
518 && (strcmp (szloginpassword, "secret") == 0))
No matter how good your check-in process is, sooner or later, your real password will end up being committed.
As for documentation, consider using Doxygen
It's a bit of effort to get set up, but you can build up as you go along (say whenever you touch a file).
What you get is some nice clickable HTML pages that anyone coming to the project will be able to get up to speed that much quicker.