String question

Hi,
Again a question from Koffman's book;
Question inputs a string and separate it into components.
For example;
Input :
ALT1203S14
Output:
Warehouse: ALT
Product: 1203
Qualifiers: S14

My broken code:

Code:

---

#include <stdio.h>
#include <string.h>
int main(void)
{
        int first, next,n;
        char code[40], warehouse[20], qualifiers[20], product[20];
        printf("Enter product code> ");
        scanf("%s", code);
        first = 0;
        next = 1;
        n = 0;
        while(next<strlen(code)){
                next++;
                //n++;
                if(code[next] >= 'A' && code[next] <= 'Z'){
                                n = n + 2;
                                strncpy(warehouse, code, next - n);
                                warehouse[next - n] = '\0';
                                first = next - n;
                                //next = next - n;
                }
                if(code[next] >='1' && code[next] <= '9'){
                        strncpy(product, &code[first], next - first );
                        product[next] = '\0';
                        first = next-n;
                }
                if(code[next] >= 'A' && code[next] <= 'Z'){                       
                        strncpy(qualifiers, &code[first], next - first);
                        qualifiers[next-n] = '\0';
                        first = next;
                }
        }
        printf("Warehouse: %s\nProduct: %s\nQualifiers: %s",warehouse,\
product, qualifiers);
        printf("\n%d\n%d", n,next);
        return(0);
}

---

Can you elaborate on why it is broken? Also you might want to take a look at strtok() for tokenizing strings.

Quote:

---

Originally Posted by claudiu

Can you elaborate on why it is broken? Also you might want to take a look at strtok() for tokenizing strings.

---

First of all, it does not give proper output.
İts output:
Warehouse: ALT
Product: 232S1
Qualifiers: 123
And I will look at strtok.But I guess the problem is in my if statements.

If the text format of each entry is always 3 letters, 4 numbers and 3mixed, the problem becomes very simple...

Code:

---

char buffer[12];

char prefix[4];
char digits[5];
char extra[4];

// get prefix
strncpy(buffer,prefix,3);
strncpy &buffer[3],digits,4);
strncpy &buffer[7],extra,4);

---

Quote:

---

Originally Posted by CommonTater

If the text format of each entry is always 3 letters, 4 numbers and 3mixed, the problem becomes very simple...

Code:

---

char buffer[12];

char prefix[4];
char digits[5];
char extra[4];

// get prefix
strncpy(buffer,prefix,3);
strncpy &buffer[3],digits,4);
strncpy &buffer[7],extra,4);

---

---

Thanks, I solved the problem.

Code:

---

#include <stdio.h>
#include <string.h>
int main(void)
{
        int first, next,n, x;
        char code[40], warehouse[20], qualifiers[20], product[20];
        printf("Enter product code> ");
        scanf("%s", code);
        first = 0;
        next = 1;
        n = 0;
        while(next<strlen(code)){
                next++;
                if(code[next] >='1' && code[next] <= '9'){
                        strncpy(qualifiers, &code[first], next-1 );
                        qualifiers[next-1] = '\0';
                        first = next-1;               
                        }
                else if(code[next] >= 'A' && code[next] <= 'Z'){
                        n = n + 2;
                        strncpy(warehouse, code, next - n);
                        warehouse[next - n] = '\0';
                        first = next - n;
                        x = n - 1;
                        strncpy(product, &code[first], next - x);
                        product[next-x] = '\0';
                }
        }
        printf("Warehouse: %s\nProduct: %s\nQualifiers: %s",warehouse,\
product, qualifiers);
        return(0);
}

---

Quote:

---

Enter product code> ATL1203S14
Warehouse: ATL
Product: 1203
Qualifiers: S14

---

Quote:

---

Originally Posted by paranoidgnu

Thanks, I solved the problem.

Code:

---

#include <stdio.h>
#include <string.h>
int main(void)
{
        int first, next,n, x;
        char code[40], warehouse[20], qualifiers[20], product[20];
        printf("Enter product code> ");
        scanf("%s", code);
        first = 0;
        next = 1;
        n = 0;
        while(next<strlen(code)){
                next++;
                if(code[next] >='1' && code[next] <= '9'){
                        strncpy(qualifiers, &code[first], next-1 );
                        qualifiers[next-1] = '\0';
                        first = next-1;               
                        }
                else if(code[next] >= 'A' && code[next] <= 'Z'){
                        n = n + 2;
                        strncpy(warehouse, code, next - n);
                        warehouse[next - n] = '\0';
                        first = next - n;
                        x = n - 1;
                        strncpy(product, &code[first], next - x);
                        product[next-x] = '\0';
                }
        }
        printf("Warehouse: %s\nProduct: %s\nQualifiers: %s",warehouse,\
product, qualifiers);
        return(0);
}

---

---

Very good... I was suggesting that you don't need to go at the string with loops if you know it is in a fixed format... you can just supply the offsets to strncpy and let it copy the field size you need.