Help with deal cards program.

Hi I'm making a poker game program and I need to deal 5 hands of cards(each hand has 5 cards each) in the program, each hand needs to contain different cards and we need to then display the number of pairs in each hands. I'm currently stuck in the dealing part.
This is what I have so far for dealing card:

Code:

---

void deal(card cards[52], card hands[5][5]) {
  int i, j, cd, hd;
  int value, hi, ohi, lo;
  card shuff;
 
for(cd=0, i=0; cd<5; cd++) {
    for(hd=0;hd<5;hd++) {
      hands[hd][cd] = cards[i];
      ++i;
    }
  }
for(i=0;i<5;i++) { 
    ohi = 5;
    lo = 1;
for(; lo < ohi; lo++)  {
      shuff = hands[i][lo];   
      hi = lo - 1;
      while(hands[i][hi].face > shuff.face)  {
        hands[i][hi + 1] = hands[i][hi];
        --hi;
        if(hi < 0) break;
      }
      hands[i][hi+1] = shuff;
    }
  }
  for(i = 0; i < 5; i++) {
    printf("\nHand #%d:\n\n", i+1);
    for(j = 0; j < 5; j++) {
      printf("\t%s of %s, is %s \n ",cards[j%13].face,cards[j%13].suit,cards[j%26].color);
    } 
  }
}

---

however, the compiled result shows all the hands has the exactly same cards. I'm not sure what Ive done wrong, can anyone help pls?

Code:

---

for(cd=0, i=0; cd<5; cd++) {
    for(hd=0;hd<5;hd++) {
      hands[hd][cd] = cards[i];
      ++i;
    }
  }

---

In this fragment you're putting the same cards into each hand. Did you intend them to be different at this point? EDIT: I was wrong... looking at it more now, but please still consider what I said below:

Also, please consider choosing better names for "hd", "cd", "hi", "lo", "ohi", and maybe revise your indentation (why is "for" at the beginning of the line in 3 places?).

I think I see the problem. When you print each hand, you're outputting from the cards array, not from each hand:

Code:

---

printf("\t%s of %s, is %s \n ",cards[j%13].face,cards[j%13].suit,cards[j%26].color);

---

Quote:

---

Originally Posted by Mozza314

Code:

---

for(cd=0, i=0; cd<5; cd++) {
    for(hd=0;hd<5;hd++) {
      hands[hd][cd] = cards[i];
      ++i;
    }
  }

---

In this fragment you're putting the same cards into each hand. Did you intend them to be different at this point? EDIT: I was wrong... looking at it more now, but please still consider what I said below:

Also, please consider choosing better names for "hd", "cd", "hi", "lo", "ohi", and maybe revise your indentation (why is "for" at the beginning of the line in 3 places?).

I think I see the problem. When you print each hand, you're outputting from the cards array, not from each hand:

Code:

---

printf("\t%s of %s, is %s \n ",cards[j%13].face,cards[j%13].suit,cards[j%26].color);

---

---

HI thanks for the reply. Can you give me an example on how to outputting from each hand instead of from the array? Sorry Im beginner at coding and really confused now.
Thanks again.

Quote:

---

Originally Posted by Izzy123

HI thanks for the reply. Can you give me an example on how to outputting from each hand instead of from the array? Sorry Im beginner at coding and really confused now.
Thanks again.

---

One way to do it would be to make a function void PrintCard(card c); and do:

Code:

---

for (int i = 0; i != 5; ++i)
{
    printf("Hand %d:\n", i + 1);
    for (int j = 0; j != 5; ++j)
        PrintCard(hands[i][j]);
}

---

Quote:

---

Originally Posted by Mozza314

One way to do it would be to make a function void PrintCard(card c); and do:

Code:

---

for (int i = 0; i != 5; ++i)
{
    printf("Hand %d:\n", i + 1);
    for (int j = 0; j != 5; ++j)
        PrintCard(hands[i][j]);
}

---

---

I have a print deck function, I try to put the function in but it gives error

Code:

---

void printdeck( const Card * const Deck )
{
          int i;
                  for ( i = 0; i <= 51; i++ ){
                      printf("\t%s of %s, is %s \n ",Deck[i].face,Deck[i].suit,Deck[i].color,
                            ( i + 1 ) % 2 ? '\t' : '\n' );}
}

---

The error says "cannot convert 'card' to 'const Card*' for argument '1' to 'void printdeck[const Card*]'
Do I need to make another function instead of using the existing one?

Don't worry Ive got it fixed. Working on the pairing bit now :)
thanks for your help!

Did you intend for this to be C?