Why wont my LOOP LOOP?

Need some noob help, so go easy.

I cant seem to figure out why my variable "count" will not increment.

Any help appreciated!

-Dave

Code:

---


#include <cstdlib>
#include <iostream>
#include <fstream>
#include <iomanip>
using namespace std;

int main()


{


    int count;
    char Extract_Number[4];
    char File_Name[20];
   
    cout << "Enter File to Read : " ;
    cin >> File_Name;
    count = 1;
    ifstream myfile(File_Name);
    if (myfile.is_open())
  {
    while ( myfile.good() )

          {
            myfile >> Extract_Number;
            cout << "Etracted Number is : " << Extract_Number << endl;
            cout << "The count is : " << count << endl;
            cout << "incrmenting count " ;
            count++ ;
            }}
return 0;
   
}

---

IS your file open?....

Code:

---

1. cin.getlin() // read about it
2. cout<<File_Name; //check what it is showing.
3. if (myfile.is_open())
  {
    while ( myfile.good() )

          {
            myfile >> Extract_Number;
            cout << "Etracted Number is : " << Extract_Number << endl;
            cout << "The count is : " << count << endl;
            cout << "incrmenting count " ;
            count++ ;
            }}
else
{
    cout<<"File is not found."<<endl;
}

---

I guess I should have re-titled it "why wont my counter count"?


The the int count will never increment, the file open/read/print part works fine.

-Dave

1. What is the output you do see? If you are seeing output with that code then the loop is being executed and the count should be incremented however...
2. The variable count is not initialized.
3. Your read loop should be more along the lines of:
   Code:

   ---

   while(myfile >> Extract_Number) { ... }

   ---

Code:

---

char Extract_Number[4];

---

And how many digits are there in the numbers in the file? If they are longer than 3 characters, then you get a buffer overflow, and one possible result would be that the counter variable gets overwritten.

Quote:

---

Originally Posted by anon

Code:

---

char Extract_Number[4];

---

And how many digits are there in the numbers in the file? If they are longer than 3 characters, then you get a buffer overflow, and one possible result would be that the counter variable gets overwritten.

---

Right on, that was the problem....

Ok...Why?

My number data is text...each a group of four numbers 0021 0046 etc... Why do I only have three places in the array?


Thanks again,

-Dave

Quote:

---

Originally Posted by Dave Wave

Right on, that was the problem....

Ok...Why?

My number data is text...each a group of four numbers 0021 0046 etc... Why do I only have three places in the array?


Thanks again,

-Dave

---

You don't. You've got room for four: For the first, second and third digit and for the 0-byte that terminates C-strings. You can store all four characters in there, but many functions won't work with it as there is no 0-byte and the functions don't know the length of the string.

Quote:

---

... but many functions won't work with it ...

---

... including cin >> char*, which will try to zero-terminate the string.

You need to use an array of std::string, which is a real string, and not a character. For arrays, it is also worth mentioning std::vector.

Thanks for the help, I got it all working now!


-Dave