Memory allocation problem

I've got this memory allocation problem, can't seem to figure it out:

Code:

---

#include <ctype.h>
#include <stdio.h>
#include <unistd.h>
#include <stdlib.h>
#include <string.h>


int main()
{

char buf[10];
char *p[100];
int i = 0;


while(fgets(buf,sizeof(buf),stdin))
  {
    p[i] = malloc(20);
    p[i] = buf;
    i+=1;
  }

 for(i=0; i<3; i++)
  {
    printf("%s",p[i]);
  }
return 0;
}

---

If I type

john
pavel
vlad

on the input,
it prints

vlad
vlad
vlad

on the output ?

What am doing wrong ? I don't understand, since I allocate 20 bytes for each spot in the array.

Can someone help me out ?


thanks

Code:

---

while(fgets(buf,sizeof(buf),stdin))
  {
    p[i] = malloc(20);
    p[i] = buf;
    i+=1;
  }

---

You're allocating memory for p[i], but then you're immediately throwing that pointer away by reassigning p[i] to point to buf, so in the end, every element of p ends up pointing to the same buf. Instead, use strcpy() to to copy the contents of buf to the memory you just allocated:

Code:

---

while(fgets(buf,sizeof(buf),stdin))
  {
    p[i] = malloc(20);
    strcpy(p[i], buf);
    i+=1;
  }

---