reading in a list of integers.

Hey guys, I've been trying to figure out how to read in a list of integers from a text file using visual c++ express 2010, and I'm completely stumped. This is the kind of thing that I'm trying now:

Code:

---

#include <iostream>
#include <fstream>
using namespace std;

int main () {
  int x;
  ifstream myfile;
  myfile.open ("text.txt");
  if (!myfile) {
          cout << "unable to load file.\n";
  }
  while (myfile >> x) {
          cout << x << endl;
  }
  myfile.close();
  system("pause");
  return 0;
}

---

When I run this all I get is "press any key to continue..."
So the file is correctly read, but I can't do anything with the data.


text.txt contains integers on separate lines. Like this:

12
32
14

What am I doing wrong?

Quote:

---

Originally Posted by Ben1220

So the file is correctly read, but I can't do anything with the data.

---

That appears to be false since you are printing the data.

Perhaps you want to store all the data in a container such as a std::vector?

That's the point, I'm trying to print the data, but it just won't happen. I've tried several different ways from several websites but none of them work. I know the file is being opened properly because when I change the name, I get the error message "unable to load file."
There must be something I'm missing...

Sorry, but I cannot duplicate your problem. Perhaps you should check to see if the file actually contains some valid input.

I think the problem is with ifstream,

Fix:

Quote:

---

#include <stdio.h>
#include <windows.h>
#include <iostream>
#include <fstream>

using namespace std;

int main () {
int x;
ifstream ifs ( "text.txt" , ifstream::in );
if (!ifs) {
cout << "unable to load file.\n";
}
while (ifs >> x) {
cout << x << endl;
}
ifs.close();
system("pause");
return 0;
}

---

I tried to help, but I dont know much about ifstream, I mix so much C with C++, in my codes I prefer to read files in C and use fread, much better to alocate the position of pointer.

Here is one example that I did in my class:

Quote:

---

fread (&contato, sizeof(struct Agenda), 1, arquivo);

while (!feof(arquivo)) {

printf ("Nome: '%s'\n", contato.nome);
printf ("Telefone: '%s'\n", contato.tel);
printf ("E-mail: '%s'\n", contato.email);
printf ("Aniversario: '%s'\n", contato.niver);
puts ("");

fread (&contato, sizeof(struct Agenda), 1, arquivo);

}

---

Sorry about the language is in portuguese.

The only thing you did differently was use the constructor instead of the open method. ifstream is, AFAICT, being used correctly in both examples.

If text.txt is successfully being opened, but there is no data being displayed, I can only think it's a different text.txt being opened, than the one that the OP wants to use.

• is the current working directory the same as the one you wanted?
• has text.txt previously been erroneously truncated by previous version of the program?

If I'm on the right track, then adding C isn't going to help.