Having a problem with my code :(

Hi, this is my first time posting here and was hoping someone could help me.

So basically it's a problem with types I think, here is the code:

Code:

---

LPSTR Array[];

BOOL File2Array(LPSTR pArray[], char *szFile)
{
        int i = 0;
        std::ifstream file(szFile);
        if (file.is_open()) {
                std::string line;
                while(std::getline(file, line))
                {
                        pArray[i] = mysprintf("%s", line.c_str());
                        i++;
                        if(i > 500)
                                return TRUE;
                }
        }
        else {
                Print("Unable to open file.");
                return FALSE;
        }
        return TRUE;
}

File2Array(Array, "file.txt");

---

In file.txt theres a list of words like
apple
orange
pear
banana
etc

it populates the array fine, and if I do this:

Code:

---

for(int i = 0; i < 10; i++)
cout << Array[i];

---

it prints it prints them all fine, but if i want to do, say, this:

Code:

---

BOOL IsListed(char *szWord)
{
        for(int i = 0; _strcmpi(Array[i], "(null)") != 0 && i < 500; i++)
                        if(!_strcmpi(Array[i], szWord))
                                return TRUE;
        return FALSE;
}
char szWord[0x10];
strcpy(szWord, "apple");
IsListed(Word);

---

I crash..

This is a dll too, it's a hack for a game.. honestly this is kind of out of my knowledge of c++, but I practically have it working and wrote most of it, so I wish I could get it working..

Thanks,
Vivec45

Is there an entry called "(null)" on the last line of the text file, or are there over 500 lines?

You can't do this in C++, so what is your real code?:

Code:

---

LPSTR Array[];

---

Quote:

---

Originally Posted by iMalc

Is there an entry called "(null)" on the last line of the text file, or are there over 500 lines?

You can't do this in C++, so what is your real code?:

Code:

---

LPSTR Array[];

---

---

My mistake, was kind of doing that from memory. And I was trying to put it in format of a console. Oh and I was just trying to fix it when I did, I thought it might be doing some huge loop and freezing. I noticed when it reads an empty line it equates to (null), so I thought I'd just stop reading at that point.

Code:

---

char *mysprintf(CHAR* szFormat, ...)
{
        CHAR *szString = new CHAR[8192];
        ::memset(szString, 0, 8192);
        va_list vaArgs;

        va_start(vaArgs, szFormat);
        vsprintf(szString, szFormat, vaArgs);
        va_end(vaArgs);

        return szString;
        delete[] szString;
}

BOOL File2Array(LPSTR pArray[], char *szFile)
{
        int i = 0;
        std::ifstream file(szFile);
        if (file.is_open()) {
                std::string line;
                while(std::getline(file, line))
                {
                        pArray[i] = mysprintf("%s", line.c_str());
                        i++;
                        if(i > 500)
                                return TRUE;
                }
        }
        else {
                Print("Unable to open file.");
                return FALSE;
        }
        return TRUE;
}

BOOL IsFriendlisted(char *szPlayer)
{
        for(int i = 0; _strcmpi(FriendList[i], "(null)") != 0 && i < 500; i++)
                        if(!_strcmpi(FriendList[i], szPlayer))
                                return TRUE;
        return FALSE;
}

#define DEFINEVAR(type, name)                extern type name;

        DEFINEVAR(LPSTR, FriendList[512])

        if(!_strcmpi(Msg[0],"test"))
        {
                char *Word;
                Word = "apple";

                Print("%d", IsSquelchListed(mysprintf("%s", Word), false));
                return true;
        }

---

Thanks for reply,
Vivec45

Can anyone help please? :3

You seem to have a few problems with arrays and dynamic memory allocation/deallocation. It would make your coding life a lot easier if you'd use std::string instead of character pointers and std::list or std::vector instead of arrays.