Help my program is giving a problem

My program is giving me a problem when i error check it an run it after i input wrong data it skips the thing an moves on an also i need guidance or a hint as to how the time minus thing and what exactly is rounded time as i was instructed to put it in but im not exactly sure as to what it is

Code:

---

#include <stdio.h>
#include <stdlib.h>
#include <math.h>

int main()

{
char vehicle[15];
int car;
int truck;
int hrsn, minn;
int hrso, mino;
int time;
int rt;
hrsn=0;
hrso=0;
minn=0;
mino=0;


printf("Where you driving a car or truck?\n");
scanf("%s", &vehicle );

printf("What Hour did the %s enter the lot? (0-23)\n", vehicle);
scanf("%d",&hrsn);
if((hrsn<0 || hrsn>23))
{
    printf("\a\a\a Please Input Value from 0-23!\n");
}
else
{
    printf("What Minute did the %s enter the lot? (0-59)\n", vehicle);
    scanf("%d",& minn);
}
if((minn<0 || minn>59))
{
    printf("\a\a\a Please Enter Correct Minute Between 0-59!\n");
}
else
{
    printf("What Hour did the %s leave the lot? (0-23)\n", vehicle);
    scanf("%d",& hrso);
}
if((hrso<0 || hrso>23))
{
    printf("\a\a\a Please Enter the Correct Time Between 0-23!\n");
}
else
{
    printf("What Minute did the %s leave the lot? (0-59)\n", vehicle);
    scanf("%d",& mino);
}
if(mino<0 || mino>59)
{
    printf("\a\a\a PLease Enter the Correct time between 0-59!\n");
}
else
{
rt = hrso - hrsn && mino - minn;

printf("Time in %d:%d\n", hrsn, minn);
printf("Time out %d:%d\n", hrso, mino);

printf("Parking Time %d\n", time);
printf("Rounded time %d\n", rt);
}




return 0;


}

---

Yes, what you want is to ask the user to input a correct amount and until he does keep asking. Think that you are a salesman. What you do is

Code:

---

printf("Would you by this fine product?");
scanf("%c", c);
if (c != 'y')
{
  printf("Oh, well, have a nice day sir");
  fireEmployee();
}
else
{
  printf("Nice! We aslo have this coupon...");
}

---

what you want is:

Code:

---

printf("Would you by this fine product?");
scanf("%c", c);
while (c != 'y')
{
    printf("Please reconsider");
    scanf("%c", c);
}
printf("Nice! We aslo have this coupon...");

---

Try replacing the if-else with while.

As for the rounded time is not clear like that. Maybe the total time in minutes? Maybe rounding up the time to hours? Your line of code for rt = ... is definitely not doing what you want (&& is the logical AND).

The key concept to remember here is the word "aslo". Lol, j/k ;)

Thx C_ntua i'll try it an get back to u and for the example u have given me can that work for words like with what i have i would definately need error checking in words for example for the user to input the words car or truck only, can your example be used like right here:
"(c != 'y')"
be used like (c != 'car') then blah blah blah

Quote:

---

My program is giving me a problem when i error check it an run it after i input wrong data it skips the thing an moves on an also i need guidance or a hint as to how the time minus thing and what exactly is rounded time as i was instructed to put it in but im not exactly sure as to what it is

---

=== Whew! What a read, Zangetsu! === :p :p :D :D

You may thank God almighty that you're not an English major!

Code:

---

printf("Would you by this fine product?");
scanf("%c", c);
while (c != 'y')
{
    printf("Please reconsider");
    scanf("%c", c);
}
printf("Nice! We also have this coupon...");

---

Is the point to ........ the costumer off? I would go with this

Code:

---

int loop = 0;
...
printf("Would you by this fine product?");
scanf("%c", c);
while (c != 'y' || loop >= 50)
{
    loop++;

    printf("Please reconsider");

    scanf("%c", c);

   
}
if (loop > 2)
{
    printf("well, have a nice day then...");
}

else
{
    printf("Nice! We also have this coupon...");
}

---

(I didn't read the question I just thought your answer was comical.) :D

Quote:

---

(I didn't read the question I just thought your answer was comical.)

---

I don't "by" that! :p :p :p

lol... I recognized that after I posted it, I fixed aslo though. :D

k i input the while statements and they worked so thanx very much C_ntua and everyone else who gave valid input and not jokes.lol Is there a way to do error checking for words because i would need for the user to input the words car or truck only is this possible i thought of maybe doing something to count the words car or truck so if the input is greater than 3 characters then its not the word car so is this line of thinking even possible?

I worked on the time section pls run it and tell me if im doing the right thing cause now i think i might have confused myself a bit

Code:

---

#include <stdio.h>
#include <stdlib.h>
#include <math.h>

int main()

{
char vehicle[15];
int car;
int truck;
int hrsn, minn;
int hrso, mino;
int hr; //final hour
int min; //final minute
hrsn=0;
hrso=0;
minn=0;
mino=0;
hr=0;
min=0;

printf("Where you driving a car or truck?\n");
scanf("%s", &vehicle );

printf("What Hour did the %s enter the lot? (0-23)\n", vehicle);
scanf("%d",&hrsn);
while((hrsn<0 || hrsn>23))
{
    printf("\a\a\a Please Input Value from 0-23!\n");
    scanf("%d",& hrsn);
}

{
    printf("What Minute did the %s enter the lot? (0-59)\n", vehicle);
    scanf("%d",& minn);
}
while((minn<0 || minn>59))
{
    printf("\a\a\a Please Enter Correct Minute Between 0-59!\n");
    scanf("%d",& minn);
}

{
    printf("What Hour did the %s leave the lot? (0-23)\n", vehicle);
    scanf("%d",& hrso);
}
while((hrso<0 || hrso>23))
{
    printf("\a\a\a Please Enter the Correct Time Between 0-23!\n");
    scanf("%d",& hrso);
}

{
    printf("What Minute did the %s leave the lot? (0-59)\n", vehicle);
    scanf("%d",& mino);
}
while(mino<0 || mino>59)
{
    printf("\a\a\a PLease Enter the Correct time between 0-59!\n");
    scanf("%d",& mino);
}

{
if (hrsn < (hrso - 1) && minn > mino)
{
hrso = hrso - 1;
mino = mino + 60;
}
if (mino - minn > 1 && mino - minn < 30)
{
mino = minn+30;
}

else if (mino - minn > 30 && mino - minn < 60)
{
mino = minn + 60;
}

else
{
mino = minn + 00;
}

hr = (hrso-hrsn);
min = (mino - minn);

printf("Time in %d:%d\n", hrsn, minn);
printf("Time out %d:%d\n", hrso, mino);

printf("Parking Time %d:%d\n", hr, min);

}

return 0;

}

---

"Doctor, I may have a pain."

Please be specific with what the problem is!

The time aspect of the program in subtracting the time i would like your advice on it to c if what i did was right or if u have any advice or anything like that basically your critique on it

If it's accurate - it's OK. Run-time and clarity are not an issue for the code. It's short and simple.

IMO, you don't need to include either math.h or stdlib.h, and your code should be indented so the subordinate lines of code are indented 2 to 4 spaces.

Code:

---

do {
  print something
  ask for input with scanf
}while(input value was etc.)

//looks a lot easier to understand and debug, than
do
{
print something
ask for input with scanf
}
while(input value is etc.)

---

After you've been programming for awhile, your eye will become trained, if you use standard indentation, to readily pick up on syntax bugs in your code. Properly indented code allows us to also use our trained eyes, to quickly spot some kinds of common errors.

If you want people to study your code for free, why not help them to do so?

I'm trying to have my program do word error checking but for some reason its not working i want the user to input either the words car or truck this is what i have done so far!

Code:

---

#include <stdio.h>
#include <stdlib.h>
#include <ctype.h>

int main()

{
char *vehicle;
int car;
int truck;
int hrsn, minn;
int hrso, mino;
int hr; //final hour
int min; //final minute
hrsn=0;
hrso=0;
minn=0;
mino=0;
hr=0;
min=0;

printf("Where you driving a car or truck?\n");
scanf("%s", &vehicle );

while(vehicle != "car" && vehicle != "truck")
{
    printf("Please input the words Car or Truck: ");
    scanf("%s",&vehicle);
}


printf("What Hour did the %s enter the lot? (0-23)\n", vehicle);
scanf("%d",&hrsn);
while((hrsn<0 || hrsn>23))
{
    printf("\a\a\a Please Input Value from 0-23!\n");
    scanf("%d",& hrsn);
}

{
    printf("What Minute did the %s enter the lot? (0-59)\n", vehicle);
    scanf("%d",& minn);
}
while((minn<0 || minn>59))
{
    printf("\a\a\a Please Enter Correct Minute Between 0-59!\n");
    scanf("%d",& minn);
}

{
    printf("What Hour did the %s leave the lot? (0-23)\n", vehicle);
    scanf("%d",& hrso);
}
while((hrso<0 || hrso>23))
{
    printf("\a\a\a Please Enter the Correct Time Between 0-23!\n");
    scanf("%d",& hrso);
}

{
    printf("What Minute did the %s leave the lot? (0-59)\n", vehicle);
    scanf("%d",& mino);
}
while(mino<0 || mino>59)
{
    printf("\a\a\a PLease Enter the Correct time between 0-59!\n");
    scanf("%d",& mino);
}

{
if (hrsn < (hrso - 1) && minn > mino)
{
hrso = hrso - 1;
mino = mino + 60;
}
if (mino - minn > 1 && mino - minn < 30)
{
mino = minn+30;
}

else if (mino - minn > 30 && mino - minn < 60)
{
mino = minn + 60;
}

else
{
mino = minn + 00;
}

hr = (hrso-hrsn);
min = (mino - minn);

printf("Time in %d:%d\n", hrsn, minn);
printf("Time out %d:%d\n", hrso, mino);

printf("Parking Time %d:%d\n", hr, min);

}

return 0;

}

---

You should use strcmp to compare strings.

Thx very much it works like a charm do u know of a better way for the time part of my program cause im gonna need something easier to use and i read up on time.h that sounds like it mostly gives me the current time on my pc and not something that makes the users input their time to manipulate it. Its necessary cause im gonna add on a tax function ni my program for different parking times.

Code:

---

#include <stdio.h>
#include <stdlib.h>
#include <string.h>
#include <ctype.h>

char vehicle[5];
int car;
int truck;
int hrsn; //Hour the vehicle entered the parking lot
int minn; //Minute the vehicle came in the parking lot
int hrso; //Hour the vehicle left the parking lot
int mino; //Minute the vehivle left the parking lot
int hr; //final hour
int min; //final minute
hrsn=0;
hrso=0;
minn=0;
mino=0;
hr=0;
min=0;
int main()

{


printf("Where you driving a car or truck?\n");
scanf("%s", &vehicle );

while( strcmp( vehicle, "truck" ) != 0 && strcmp( vehicle, "car" ) != 0 )
{
    printf("Please input the words Car or Truck: ");
    scanf("%s",&vehicle);
}


printf("What Hour did the %s enter the lot? (0-23)\n", vehicle);
scanf("%d",&hrsn);
while((hrsn<0 || hrsn>23))
{
    printf("\a\a\a Please Input Value from 0-23!\n");
    scanf("%d",& hrsn);
}

{
    printf("What Minute did the %s enter the lot? (0-59)\n", vehicle);
    scanf("%d",& minn);
}
while((minn<0 || minn>59))
{
    printf("\a\a\a Please Enter Correct Minute Between 0-59!\n");
    scanf("%d",& minn);
}

{
    printf("What Hour did the %s leave the lot? (0-23)\n", vehicle);
    scanf("%d",& hrso);
}
while((hrso<0 || hrso>23))
{
    printf("\a\a\a Please Enter the Correct Time Between 0-23!\n");
    scanf("%d",& hrso);
}

{
    printf("What Minute did the %s leave the lot? (0-59)\n", vehicle);
    scanf("%d",& mino);
}
while(mino<0 || mino>59)
{
    printf("\a\a\a PLease Enter the Correct time between 0-59!\n");
    scanf("%d",& mino);
}

{
if (hrsn < (hrso - 1) && minn > mino)
{
hrso = hrso - 1;
mino = mino + 60;
}
if (mino - minn > 1 && mino - minn < 30)
{
mino = minn+30;
}

else if (mino - minn > 30 && mino - minn < 60)
{
mino = minn + 60;
}

else
{
mino = minn + 00;
}


hr = (hrso-hrsn);
min = (mino - minn);

printf("Time in %d:%d\n", hrsn, minn);

printf("Parking Time %d hours:%d minutes\n", hr, min);

}

return 0;

}

---

What would be a time format that is "easier to use"?

Post up an example of what you want for timed entry. The logic is not a problem, but reading your mind is a sure flop.

time in 2:45pm time out : 3:50pmsomething like that cause i would need to minus the time in form the time out

Quote:

---

Originally Posted by zangetsu

time in 2:45pm time out : 3:50pmsomething like that cause i would need to minus the time in form the time out

---

So you subtract hours out, from hours in, and then you need a bit of logic:

Code:

---

if(minute_in < minute_out) {
  minutes_used = 60 - (minute_out - minute_in)
  //minutes_used = 60 - 5
  //minutes_used = 55 minutes
}
else if(minute_in > minute_out)
  minutes_used = (60 - minute_out) + minute_in
else
  minutes_used = 0; //minutes_in equals minutes_out

---

Give that logic a shot. I don't see a way to make your time format somehow make your time calculations, any easier. There are still just 60 minutes in an hour, and 24 hours in a day, so the above type of logic, is still going to be needed.

Quote:

---

Originally Posted by Adak

What would be a time format that is "easier to use"?

Post up an example of what you want for timed entry. The logic is not a problem, but reading your mind is a sure flop.

---

Keep the time internally in seconds... convert to hours:min:sec for display purposes only.
Then it's just a math problem...

Thx i tried it an it works but the problem im trying to fix is that when minutes in > minutes out it gives mi a negative number in the end like "1 hour:-5 minutes"

Code:

---

#include <stdio.h>
#include <stdlib.h>
#include <string.h>
#include <ctype.h>
#include <math.h>

char vehicle[5];
int car;
int truck;
int hrsn; //Hour the vehicle entered the parking lot
int minn; //Minute the vehicle came in the parking lot
int hrso; //Hour the vehicle left the parking lot
int mino; //Minute the vehivle left the parking lot
int hr; //final hour
int min; //final minute
int minutes_max;//60 minutes
int hours_max;//24 hours
hrsn=0;
hrso=0;
minn=0;
mino=0;
hr=0;
min=0;
int main()

{


printf("Where you driving a car or truck?\n");
scanf("%s", &vehicle );

while( strcmp( vehicle, "truck" ) != 0 && strcmp( vehicle, "car" ) != 0 )
{
    printf("Please input the words Car or Truck: ");
    scanf("%s",&vehicle);
}


printf("What Hour did the %s enter the lot? (0-23)\n", vehicle);
scanf("%d",&hrsn);
while((hrsn<0 || hrsn>23))
{
    printf("\a\a\a Please Input Value from 0-23!\n");
    scanf("%d",& hrsn);
}

{
    printf("What Minute did the %s enter the lot? (0-59)\n", vehicle);
    scanf("%d",& minn);
}
while((minn<0 || minn>59))
{
    printf("\a\a\a Please Enter Correct Minute Between 0-59!\n");
    scanf("%d",& minn);
}

{
    printf("What Hour did the %s leave the lot? (0-23)\n", vehicle);
    scanf("%d",& hrso);
}
while((hrso<0 || hrso>23))
{
    printf("\a\a\a Please Enter the Correct Time Between 0-23!\n");
    scanf("%d",& hrso);
}

{
    printf("What Minute did the %s leave the lot? (0-59)\n", vehicle);
    scanf("%d",& mino);
}
while(mino<0 || mino>59)
{
    printf("\a\a\a PLease Enter the Correct time between 0-59!\n");
    scanf("%d",& mino);
}

{
if(minn < mino)
{
  minutes_max = 60 - (mino - minn);
  //minutes_max = 60 - 5
  //minutes_max = 55 minutes
}
else if(minn > mino)
  minutes_max = (60 - minn) + (mino - 60);

else
  minutes_max = 0; //minutes_in equals minutes_out


if (hrsn < hrso)
{
    hours_max = 24 - (hrso - hrsn);
}

else if (hrsn > hrso)
hours_max = (24 - hrso) + minn;
else
hours_max = 0;


hours_max = (hrso - hrsn);
minutes_max = (mino - minn);

printf("Time in %d:%d\n", hrsn, minn);
printf("Time out %d:%d\n", hrso, mino);
printf("Parking Time:  %d:%d \n", hours_max, minutes_max);

}

return 0;

}

---

i revised cause im trying to make it take off an hour from it its really confusing my brain

Code:

---

#include <stdio.h>
#include <stdlib.h>
#include <string.h>
#include <ctype.h>
#include <math.h>

char vehicle[5];
int car;
int truck;
int hrsn; //Hour the vehicle entered the parking lot
int minn; //Minute the vehicle came in the parking lot
int hrso; //Hour the vehicle left the parking lot
int mino; //Minute the vehicle left the parking lot
int hr; //final hour
int min; //final minute
int minutes_max;//60 minutes
int hours_max;//24 hours
hrsn=0;
hrso=0;
minn=0;
mino=0;
hr=0;
min=0;
minutes_max=0;
hours_max=0;

int main()

{


printf("Where you driving a car or truck?\n");
scanf("%s", &vehicle );

while( strcmp( vehicle, "truck" ) != 0 && strcmp( vehicle, "car" ) != 0 )
{
    printf("Please input the words Car or Truck: ");
    scanf("%s",&vehicle);
}


printf("What Hour did the %s enter the lot? (0-23)\n", vehicle);
scanf("%d",&hrsn);
while((hrsn<0 || hrsn>23))
{
    printf("\a\a\a Please Input Value from 0-23!\n");
    scanf("%d",& hrsn);
}

{
    printf("What Minute did the %s enter the lot? (0-59)\n", vehicle);
    scanf("%d",& minn);
}
while((minn<0 || minn>59))
{
    printf("\a\a\a Please Enter Correct Minute Between 0-59!\n");
    scanf("%d",& minn);
}

{
    printf("What Hour did the %s leave the lot? (0-23)\n", vehicle);
    scanf("%d",& hrso);
}
while((hrso<0 || hrso>23))
{
    printf("\a\a\a Please Enter the Correct Time Between 0-23!\n");
    scanf("%d",& hrso);
}

{
    printf("What Minute did the %s leave the lot? (0-59)\n", vehicle);
    scanf("%d",& mino);
}
while(mino<0 || mino>59)
{
    printf("\a\a\a PLease Enter the Correct time between 0-59!\n");
    scanf("%d",& mino);
}

{
if(minn < mino)
{
  minutes_max = 60 - (mino - minn);
  //minutes_max = 60 - 5
  //minutes_max = 55 minutes
}
else if(minn > mino)
{
    minutes_max = (60 - minn) + mino;
    hours_max = hours_max-1;
}

else
  minutes_max = 0; //minutes_in equals minutes_out


if (hrsn < hrso)
{
    hours_max = 24 - (hrso - hrsn);
}

else if (hrsn > hrso)
{
    hours_max = (24 - hrso) + hrsn;
}

else
hours_max = 0;


hours_max = (hrso - hrsn);


printf("Time in %d:%d\n", hrsn, minn);
printf("Time out %d:%d\n", hrso, mino);
printf("Parking Time:  %d:%d \n", hours_max, minutes_max);

}

return 0;

}

---

When i run my program it skips the Tax function in my code and i change int main to int void an it still isnt working plz help, i put "void Tax():" in the global section an it skipped it also

Code:

---

#include <stdio.h>
#include <stdlib.h>
#include <string.h>
#include <ctype.h>
#include <math.h>

char vehicle[5];
int car;
int truck;
int hrsn; //Hour the vehicle entered the parking lot
int minn; //Minute the vehicle came in the parking lot
int hrso; //Hour the vehicle left the parking lot
int mino; //Minute the vehicle left the parking lot
int hr; //final hour
int min; //final minute
int minutes_max;//60 minutes
int hours_max;//24 hours
hrsn=0;
hrso=0;
minn=0;
mino=0;
hr=0;
min=0;
minutes_max=0;
hours_max=0;

void main()

{


printf("Where you driving a car or truck?\n");
scanf("%s", &vehicle );

while( strcmp( vehicle, "truck" ) != 0 && strcmp( vehicle, "car" ) != 0 )
{
    printf("Please input the words Car or Truck: ");
    scanf("%s",&vehicle);
}


printf("What Hour did the %s enter the lot? (0-23)\n", vehicle);
scanf("%d",&hrsn);
while((hrsn<0 || hrsn>23))
{
    printf("\a\a\a Please Input Value from 0-23!\n");
    scanf("%d",& hrsn);
}

{
    printf("What Minute did the %s enter the lot? (0-59)\n", vehicle);
    scanf("%d",& minn);
}
while((minn<0 || minn>59))
{
    printf("\a\a\a Please Enter Correct Minute Between 0-59!\n");
    scanf("%d",& minn);
}

{
    printf("What Hour did the %s leave the lot? (0-23)\n", vehicle);
    scanf("%d",& hrso);
}
while((hrso<0 || hrso>23))
{
    printf("\a\a\a Please Enter the Correct Time Between 0-23!\n");
    scanf("%d",& hrso);
}

{
    printf("What Minute did the %s leave the lot? (0-59)\n", vehicle);
    scanf("%d",& mino);
}
while(mino<0 || mino>59)
{
    printf("\a\a\a PLease Enter the Correct time between 0-59!\n");
    scanf("%d",& mino);
}

{
if(minn < mino)
{
  minutes_max = 60 - (mino - minn);
  //minutes_max = 60 - 5
  //minutes_max = 55 minutes
}
else if(minn > mino)
{
    minutes_max = (60 - minn) + mino;
    hrso = hrso-1;
}

else
  minutes_max = 0; //minutes_in equals minutes_out


if (hrsn < hrso)
{
    hours_max = 24 - (hrso - hrsn);
}

else if (hrsn > hrso)
{
    hours_max = (24 - hrso) + hrsn;
}

else
hours_max = 0;


hours_max = (hrso - hrsn);


printf("Time in %d:%d\n", hrsn, minn);
printf("Parking Time:  %d:%d \n", hours_max, minutes_max);

}


}

int Tax()
{

float gct;
float price_car;
float price_truck;
float price;
float finalprice;
price=0;
finalprice=0;
gct=0.175; //17.5%
price_car=0;
price_truck=0;



while(vehicle == "car")
{

if( minutes_max > 1 || minutes_max < 30)
{
    price = price_car + 50;
}
else if(minutes_max > 30 || minutes_max < 60)
{
    price = price_car + 100;
}
else if( hours_max >= 1)
{
    price = (price_car+100) * hours_max;
}

finalprice = (gct * price) + price;

}

while(vehicle == "truck")
{

if( minutes_max > 1 || minutes_max < 30)
{
    price = price_truck + 50;
}
else if(minutes_max > 30 || minutes_max < 60)
{
    price = price_truck + 100;
}
else if( hours_max >= 1)
{
    price = (price_truck+100) * hours_max;
}

finalprice = (gct * price) + price;

}

printf("The Final Price is: %f", finalprice);

}

---

You can't use this kind of code in C - it's not legal.

Code:

---

while(vehicle == "car")

---

use this instead:

include string.h at the top of your program, if it's not there yet.

Code:

---

if((strcmp(vehicle, "car")) == 0) {
  //they match
}
else {
  //they do not match
}

---

Did you get the time problem fixed yet?

yes i did but now the program is skipping the tax function and i tried to use pointer but im getting a hell of a lotta errors and not understanding them

Code:

---

#include <stdio.h>
#include <stdlib.h>
#include <string.h>
#include <ctype.h>
#include <math.h>

char vehicle[5];
int car;
int truck;
int hrsn; //Hour the vehicle entered the parking lot
int minn; //Minute the vehicle came in the parking lot
int hrso; //Hour the vehicle left the parking lot
int mino; //Minute the vehicle left the parking lot
int hr; //final hour
int min; //final minute
int minutes_max;//60 minutes
int hours_max;//24 hours
hrsn=0;
hrso=0;
minn=0;
mino=0;
hr=0;
min=0;
minutes_max=0;
hours_max=0;

void Tax(float *gct, float *price_car, float *price_truck, float *price, float *finalprice);

int main(void)

{

float gct;
float price_car;
float price_truck;
float price;
float finalprice;
price=0;
finalprice=0;
gct=0.175; //17.5%
price_car=0;
price_truck=0;

printf("Where you driving a car or truck?\n");
scanf("%s", &vehicle );

while( strcmp( vehicle, "truck" ) != 0 && strcmp( vehicle, "car" ) != 0 )
{
    printf("Please input the words Car or Truck: ");
    scanf("%s",&vehicle);
}


printf("What Hour did the %s enter the lot? (0-23)\n", vehicle);
scanf("%d",&hrsn);
while((hrsn<0 || hrsn>23))
{
    printf("\a\a\a Please Input Value from 0-23!\n");
    scanf("%d",& hrsn);
}

{
    printf("What Minute did the %s enter the lot? (0-59)\n", vehicle);
    scanf("%d",& minn);
}
while((minn<0 || minn>59))
{
    printf("\a\a\a Please Enter Correct Minute Between 0-59!\n");
    scanf("%d",& minn);
}

{
    printf("What Hour did the %s leave the lot? (0-23)\n", vehicle);
    scanf("%d",& hrso);
}
while((hrso<0 || hrso>23))
{
    printf("\a\a\a Please Enter the Correct Time Between 0-23!\n");
    scanf("%d",& hrso);
}

{
    printf("What Minute did the %s leave the lot? (0-59)\n", vehicle);
    scanf("%d",& mino);
}
while(mino<0 || mino>59)
{
    printf("\a\a\a PLease Enter the Correct time between 0-59!\n");
    scanf("%d",& mino);
}

{
if(minn < mino)
{
  minutes_max = 60 - (mino - minn);
  //minutes_max = 60 - 5
  //minutes_max = 55 minutes
}
else if(minn > mino)
{
    minutes_max = (60 - minn) + mino;
    hrso = hrso-1;
}

else

  minutes_max = 0; //minutes_in equals minutes_out


if (hrsn < hrso)
{
    hours_max = 24 - (hrso - hrsn);
}

else if (hrsn > hrso)
{
    hours_max = (24 - hrso) + hrsn;
}

else
hours_max = 0;


hours_max = (hrso - hrsn);


printf("Time in %d:%d\n", hrsn, minn);
printf("Parking Time:  %d:%d \n", hours_max, minutes_max);

}



Tax(&gct,&price_car,&price_truck,&price,&finalprice);


}


void Tax(float *gct, float *price_car, float *price_truck, float *price, float *finalprice)
{

if((strcmp(vehicle, "car")) == 0)
{

if( minutes_max > 1 || minutes_max < 30)
{
    price = price_car + 50;
}
else if(minutes_max > 30 || minutes_max < 60)
{
    price = price_car + 100;
}
else if( hours_max >= 1)
{
    price = (price_car+100) * hours_max;
}

finalprice = (gct * price) + price;

}

if((strcmp(vehicle, "truck")) == 0)
{

if( minutes_max > 1 || minutes_max < 30)
{
    price = price_truck + 50;
}
else if(minutes_max > 30 || minutes_max < 60)
{
    price = price_truck + 100;
}
else if( hours_max >= 1)
{
    price = (price_truck+100) * hours_max;
}

finalprice = (gct * price) + price;

}

printf("The Final Price is: %f", finalprice);
return 0;
}

---

The Tax function wasn't getting called because you ended main with a curly brace, before the line of code that was calling Tax().

Remove the curly brace in red, from your code in main():

Code:

---

printf("Parking Time:  %d:%d \n", hours_max, minutes_max);

}



Tax(&gct,&price_car,&price_truck,&price,&finalprice);


}

---

Quote:

---

Originally Posted by Adak

The Tax function wasn't getting called because you ended main with a curly brace, before the line of code that was calling Tax().

---

For that matter... he could probably take out half the brace pairs and still have a working program.

Tried it and it still doesnt work

Code:

---

#include <stdio.h>
#include <stdlib.h>
#include <string.h>
#include <ctype.h>
#include <math.h>

char vehicle[5];
int car;
int truck;
int hrsn; //Hour the vehicle entered the parking lot
int minn; //Minute the vehicle came in the parking lot
int hrso; //Hour the vehicle left the parking lot
int mino; //Minute the vehicle left the parking lot
int hr; //final hour
int min; //final minute
int minutes_max;//60 minutes
int hours_max;//24 hours
hrsn=0;
hrso=0;
minn=0;
mino=0;
hr=0;
min=0;
minutes_max=0;
hours_max=0;

void Tax(float *gct, float *price_car, float *price_truck, float *price, float *finalprice);

int main(void)

{

float gct;
float price_car;
float price_truck;
float price;
float finalprice;
price=0;
finalprice=0;
gct=0.175; //17.5%
price_car=0;
price_truck=0;

printf("Where you driving a car or truck?\n");
scanf("%s", &vehicle );

while( strcmp( vehicle, "truck" ) != 0 && strcmp( vehicle, "car" ) != 0 )
{
    printf("Please input the words Car or Truck: ");
    scanf("%s",&vehicle);
}


printf("What Hour did the %s enter the lot? (0-23)\n", vehicle);
scanf("%d",&hrsn);
while((hrsn<0 || hrsn>23))
{
    printf("\a\a\a Please Input Value from 0-23!\n");
    scanf("%d",& hrsn);
}

{
    printf("What Minute did the %s enter the lot? (0-59)\n", vehicle);
    scanf("%d",& minn);
}
while((minn<0 || minn>59))
{
    printf("\a\a\a Please Enter Correct Minute Between 0-59!\n");
    scanf("%d",& minn);
}

{
    printf("What Hour did the %s leave the lot? (0-23)\n", vehicle);
    scanf("%d",& hrso);
}
while((hrso<0 || hrso>23))
{
    printf("\a\a\a Please Enter the Correct Time Between 0-23!\n");
    scanf("%d",& hrso);
}

{
    printf("What Minute did the %s leave the lot? (0-59)\n", vehicle);
    scanf("%d",& mino);
}
while(mino<0 || mino>59)
{
    printf("\a\a\a PLease Enter the Correct time between 0-59!\n");
    scanf("%d",& mino);
}


if(minn < mino)
{
  minutes_max = 60 - (mino - minn);
  //minutes_max = 60 - 5
  //minutes_max = 55 minutes
}
else if(minn > mino)
{
    minutes_max = (60 - minn) + mino;
    hrso = hrso-1;
}

else

  minutes_max = 0; //minutes_in equals minutes_out


if (hrsn < hrso)
{
    hours_max = 24 - (hrso - hrsn);
}

else if (hrsn > hrso)
{
    hours_max = (24 - hrso) + hrsn;
}

else
hours_max = 0;


hours_max = (hrso - hrsn);


printf("Time in %d:%d\n", hrsn, minn);
printf("Parking Time:  %d:%d \n", hours_max, minutes_max);

Tax(&gct,&price_car,&price_truck,&price,&finalprice);






}


void Tax(float *gct, float *price_car, float *price_truck, float *price, float *finalprice)
{

if((strcmp(vehicle, "car")) == 0)
{

if( minutes_max > 1 || minutes_max < 30)
{
    price = price_car + 50;
}
else if(minutes_max > 30 || minutes_max < 60)
{
    price = price_car + 100;
}
else if( hours_max >= 1)
{
    price = (price_car+100) * hours_max;
}

finalprice = (gct * price) + price;

}

if((strcmp(vehicle, "truck")) == 0)
{

if( minutes_max > 1 || minutes_max < 30)
{
    price = price_truck + 50;
}
else if(minutes_max > 30 || minutes_max < 60)
{
    price = price_truck + 100;
}
else if( hours_max >= 1)
{
    price = (price_truck+100) * hours_max;
}

finalprice = (gct * price) + price;

}

printf("The Final Price is: %f", finalprice);
return 0;
}

---

Your calculations in TAX() are based on the variable minutes_max, but you didn't bring minutes_max, into that function.

Thx didnt even realise that i carried over minutes_max , hours_max and vehicle and it runs now but it crashes when i input the last variable for the main() part of the program

Code:

---

#include <stdio.h>
#include <stdlib.h>
#include <string.h>
#include <ctype.h>
#include <math.h>

char vehicle[5];
int car;
int truck;
int hrsn; //Hour the vehicle entered the parking lot
int minn; //Minute the vehicle came in the parking lot
int hrso; //Hour the vehicle left the parking lot
int mino; //Minute the vehicle left the parking lot
int hr; //final hour
int min; //final minute
int minutes_max;//60 minutes
int hours_max;//24 hours
hrsn=0;
hrso=0;
minn=0;
mino=0;
hr=0;
min=0;
minutes_max=0;
hours_max=0;

void Tax(float *gct, float *price_car, float *price_truck, float *price, float *finalprice, int *minutes_max, int *hours_max, char *vehicle[5]);

int main(void)

{

float gct;
float price_car;
float price_truck;
float price;
float finalprice;
price=0;
finalprice=0;
gct=0.175; //17.5%
price_car=0;
price_truck=0;

printf("Where you driving a car or truck?\n");
scanf("%s", &vehicle );

while( strcmp( vehicle, "truck" ) != 0 && strcmp( vehicle, "car" ) != 0 )
{
    printf("Please input the words Car or Truck: ");
    scanf("%s",&vehicle);
}


printf("What Hour did the %s enter the lot? (0-23)\n", vehicle);
scanf("%d",&hrsn);
while((hrsn<0 || hrsn>23))
{
    printf("\a\a\a Please Input Value from 0-23!\n");
    scanf("%d",& hrsn);
}

{
    printf("What Minute did the %s enter the lot? (0-59)\n", vehicle);
    scanf("%d",& minn);
}
while((minn<0 || minn>59))
{
    printf("\a\a\a Please Enter Correct Minute Between 0-59!\n");
    scanf("%d",& minn);
}

{
    printf("What Hour did the %s leave the lot? (0-23)\n", vehicle);
    scanf("%d",& hrso);
}
while((hrso<0 || hrso>23))
{
    printf("\a\a\a Please Enter the Correct Time Between 0-23!\n");
    scanf("%d",& hrso);
}

{
    printf("What Minute did the %s leave the lot? (0-59)\n", vehicle);
    scanf("%d",& mino);
}
while(mino<0 || mino>59)
{
    printf("\a\a\a PLease Enter the Correct time between 0-59!\n");
    scanf("%d",& mino);
}


if(minn < mino)
{
  minutes_max = 60 - (mino - minn);
  //minutes_max = 60 - 5
  //minutes_max = 55 minutes
}
else if(minn > mino)
{
    minutes_max = (60 - minn) + mino;
    hrso = hrso-1;
}

else

  minutes_max = 0; //minutes_in equals minutes_out


if (hrsn < hrso)
{
    hours_max = 24 - (hrso - hrsn);
}

else if (hrsn > hrso)
{
    hours_max = (24 - hrso) + hrsn;
}

else
hours_max = 0;


hours_max = (hrso - hrsn);


printf("Time in %d:%d\n", hrsn, minn);
printf("Parking Time:  %d:%d \n", hours_max, minutes_max);

Tax(&gct,&price_car,&price_truck,&price,&finalprice,&minutes_max,&hours_max,&vehicle[5]);


}


void Tax(float *gct, float *price_car, float *price_truck, float *price, float *finalprice, int *minutes_max, int *hours_max, char *vehicle[5])
{

if((strcmp(*vehicle, "car")) == 0)
{

if( *minutes_max > 1 || *minutes_max < 30)
{
    *price = *price_car + 50;
}
else if(*minutes_max > 30 || *minutes_max < 60)
{
    *price = *price_car + 100;
}
else if( *hours_max >= 1)
{
    *price = (*price_car+100) * *hours_max;
}

*finalprice = (*gct * *price) + *price;

}

if((strcmp(*vehicle, "truck")) == 0)
{

if( *minutes_max > 1 || *minutes_max < 30)
{
    *price = *price_truck + 50;
}
else if(*minutes_max > 30 || *minutes_max < 60)
{
    *price = *price_truck + 100;
}
else if( *hours_max >= 1)
{
    *price = (*price_truck+100) * *hours_max;
}

*finalprice = (*gct * *price) + *price;

}

printf("The Final Price is: %f", *finalprice);

}

---

i fixed that part but its not calculating the final price properly

Code:

---

#include <stdio.h>
#include <stdlib.h>
#include <string.h>
#include <ctype.h>
#include <math.h>


void Tax(float *gct, int *price_car, int *price_truck, int *price, float *finalprice, int *minutes_max, int *hours_max, char *vehicle[5]);

int main(void)

{

char vehicle[5];
int car;
int truck;
int hrsn; //Hour the vehicle entered the parking lot
int minn; //Minute the vehicle came in the parking lot
int hrso; //Hour the vehicle left the parking lot
int mino; //Minute the vehicle left the parking lot
int hr; //final hour
int min; //final minute
int minutes_max;//60 minutes
int hours_max;//24 hours
hrsn=0;
hrso=0;
minn=0;
mino=0;
hr=0;
min=0;
minutes_max=0;
hours_max=0;
int price=0;
float finalprice=0;
float gct=0.175; //17.5%
int price_car=0;
int price_truck=0;


printf("Where you driving a car or truck?\n");
scanf("%s", &vehicle );

while( strcmp( vehicle, "truck" ) != 0 && strcmp( vehicle, "car" ) != 0 )
{
    printf("Please input the words Car or Truck: ");
    scanf("%s",&vehicle);
}

printf("What Hour did the %s enter the lot? (0-23)\n", vehicle);
scanf("%d",&hrsn);
while((hrsn<0 || hrsn>23))
{
    printf("\a\a\a Please Input Value from 0-23!\n");
    scanf("%d",& hrsn);
}

{
    printf("What Minute did the %s enter the lot? (0-59)\n", vehicle);
    scanf("%d",& minn);
}
while((minn<0 || minn>59))
{
    printf("\a\a\a Please Enter Correct Minute Between 0-59!\n");
    scanf("%d",& minn);
}

{
    printf("What Hour did the %s leave the lot? (0-23)\n", vehicle);
    scanf("%d",& hrso);
}
while((hrso<0 || hrso>23))
{
    printf("\a\a\a Please Enter the Correct Time Between 0-23!\n");
    scanf("%d",& hrso);
}

{
    printf("What Minute did the %s leave the lot? (0-59)\n", vehicle);
    scanf("%d",& mino);
}
while(mino<0 || mino>59)
{
    printf("\a\a\a PLease Enter the Correct time between 0-59!\n");
    scanf("%d",& mino);
}


if(minn < mino)
{
  minutes_max = 60 - (mino - minn);
  //minutes_max = 60 - 5
  //minutes_max = 55 minutes
}
else if(minn > mino)
{
    minutes_max = (60 - minn) + mino;
    hrso = hrso-1;
}

else

  minutes_max = 0; //minutes_in equals minutes_out


if (hrsn < hrso)
{
    hours_max = 24 - (hrso - hrsn);
}

else if (hrsn > hrso)
{
    hours_max = (24 - hrso) + hrsn;
}

else
hours_max = 0;


hours_max = (hrso - hrsn);


printf("Time in %d:%d\n", hrsn, minn);
printf("Parking Time:  %d:%d \n", hours_max, minutes_max);

Tax(&gct,&price_car,&price_truck,&price,&finalprice,&minutes_max,&hours_max,&vehicle[5]);


}


void Tax(float *gct, int *price_car, int *price_truck, int *price, float *finalprice, int *minutes_max, int *hours_max, char *vehicle[5])
{

while((strcmp(*vehicle, "car")) == 0)
{
if( *minutes_max > 1 || *minutes_max < 30)
{
    *price = *price_car + 50;
}
else if(*minutes_max > 30 || *minutes_max < 60)
{
    *price = *price_car + 100;
}
else if( *hours_max >= 1)
{
    *price = (*price_car+100) * *hours_max;
}

*finalprice = (*gct * *price) + *price;


if((strcmp(*vehicle, "truck")) == 0)
{

if( *minutes_max > 1 || *minutes_max < 30)
{
    *price = *price_truck + 50;
}
else if(*minutes_max > 30 || *minutes_max < 60)
{
    *price = *price_truck + 100;
}
else if( *hours_max >= 1)
{
    *price = (*price_truck+100) * *hours_max;
}

*finalprice = (*gct * *price) + *price;

}
}
printf("The Final Price is: %f", *finalprice);

}

---

At the risk of suggesting a huge change...

Why do you work in hours and minutes?
If you timestamp each vehicles arrival time with In = time(NULL);
Then Timestamp each vehicles departure with Out = time(NULL);
All you have to do is subract... TimeInLot = Out - In;
The answer will be in seconds... So calculate your price on seconds.
The only time you need hours and minutes is to *display* how long he was there.

Because this is an assessment the teacher is definately not going to take the time out to be calculating seconds to input i need something extremely user friendly not even i would take the time out to calculate seconds like that

Quote:

---

Originally Posted by zangetsu

Because this is an assessment the teacher is definately not going to take the time out to be calculating seconds to input i need something extremely user friendly not even i would take the time out to calculate seconds like that

---

What are you talking about?

The suggestion was to have the software work *internally* on seconds...
A small function would display hours and minutes from seconds...
you already have a function to convert from hours to minutes.

You and your teacher don't have to calculate *anything*... that's what software is for.

Quote:

---

Originally Posted by CommonTater

you already have a function to convert from hours to minutes.

---

I DO!?... Where!? lmao like seriously i dont think we're on the same page can u explain it to mi a little better please? cause im not understanding what it is exactly what your saying?

One thing you really need to do, is to incrementally debug your program, as you're writing it.

Verify each of your calculations, before you move onto the writing up the next one. The worst thing is to have a bug show up, after you've got scores of new code written up, and you have little idea of which function is causing the problem.

Imo, you're making this more difficult than it needs to be, and passing too many variables around to your functions - but that's OK, if it's what you want. it's more difficult than it has to be, is all.

If a calculation is not right, you need to step through the code with your debugger, and watch the value of the variables involved, to see what's wrong. You can do that better than anyone else, because no one knows your program, better than you do, now.

Quote:

---

Originally Posted by zangetsu

I DO!?... Where!? lmao like seriously i dont think we're on the same page can u explain it to mi a little better please? cause im not understanding what it is exactly what your saying?

---

Ok... standard C function ... time(); ... the number of seconds since midnight 1980... incremented every second.

Car pulls into lot... TimeIn = time(NULL);
Time marches on...
Care pulls upt to pay... TimeOut = time(NULL);

Now in your present system you have to track hours and minutes separately... The logic and the math is complex, especially if it rolls over midnight so that a car enters at 10:00pm and leaves at 2:00am....

My way it's a simple arithmetic function... TimeCharge = TimeOut - TimeIn;
Now you know how many seconds he's been on the lot, thus you can easily calculate how much to charge, with nothing more complex than a quick subtraction...

Look at your code... how much of it is figuring out how many hours and minutes he's been on the lot? I just reduced that to one simple subtraction statement.

Fine... you charge by the minute... MinutesDue = TimeCharge / 60;

So all that logic has just been reduced to a single division problem.

Look how much of your code is calculating this... You could reduce it to 2 or 3 lines of code.

That's all I was suggesting.

May I suggest that you're beating a dead horse? < ROFL! > :p :p :p

Quote:

---

Originally Posted by Adak

May I suggest that you're beating a dead horse? < ROFL! > :p :p :p

---

Who me? Never! :rolleyes:

in my program i think its something with the while part cause maybe i haven't have it done something for that statement , i probably sound confusing like with a if statement if i say
if(that = bat)
then do this
but i jus have while then a if statement

Code:

---

void Tax(float *gct, int *price_car, int *price_truck, int *price, float *finalprice, int *minutes_max, int *hours_max, char *vehicle[5])
{

while((strcmp(*vehicle, "car")) == 0)
{
if( *minutes_max > 1 && *minutes_max < 30)
{
    *price = *price_car + 50;
}

---

This is getting real mind boggling now cause i try different things and i get different outputs but its always the same and its not printing that second to last printf can u tell me a better way to arrange the last past about the selection of the car or truck?

Code:

---

#include <stdio.h>
#include <stdlib.h>
#include <string.h>
#include <ctype.h>
#include <math.h>


void Tax(float *gct, int *price_car, int *price_truck, int *price, float *finalprice, int *minutes_max, int *hours_max, char *vehicle[5]);

int main(void)
{

char vehicle[5];
int car;
int truck;
int hrsn; //Hour the vehicle entered the parking lot
int minn; //Minute the vehicle came in the parking lot
int hrso; //Hour the vehicle left the parking lot
int mino; //Minute the vehicle left the parking lot
int hr; //final hour
int min; //final minute
int minutes_max;//60 minutes
int hours_max;//24 hours
hrsn=0;
hrso=0;
minn=0;
mino=0;
hr=0;
min=0;
minutes_max=0;
hours_max=0;
int price=0;
float finalprice=0;
float gct=0.175; //17.5%
int price_car=0;
int price_truck=0;


printf("Where you driving a car or truck?\n");
scanf("%s", &vehicle );

while( strcmp( vehicle, "truck" ) != 0 && strcmp( vehicle, "car" ) != 0 )
{
    printf("Please input the words Car or Truck: ");
    scanf("%s",&vehicle);
}

printf("What Hour did the %s enter the lot? (0-23)\n", vehicle);
scanf("%d",&hrsn);
while((hrsn<0 || hrsn>23))
{
    printf("\a\a\a Please Input Value from 0-23!\n");
    scanf("%d",& hrsn);
}

{
    printf("What Minute did the %s enter the lot? (0-59)\n", vehicle);
    scanf("%d",& minn);
}
while((minn<0 || minn>59))
{
    printf("\a\a\a Please Enter Correct Minute Between 0-59!\n");
    scanf("%d",& minn);
}

{
    printf("What Hour did the %s leave the lot? (0-23)\n", vehicle);
    scanf("%d",& hrso);
}
while((hrso<0 || hrso>23))
{
    printf("\a\a\a Please Enter the Correct Time Between 0-23!\n");
    scanf("%d",& hrso);
}

{
    printf("What Minute did the %s leave the lot? (0-59)\n", vehicle);
    scanf("%d",& mino);
}
while(mino<0 || mino>59)
{
    printf("\a\a\a PLease Enter the Correct time between 0-59!\n");
    scanf("%d",& mino);
}


if(minn < mino)
{
  minutes_max = 60 - (mino - minn);
  //minutes_max = 60 - 5
  //minutes_max = 55 minutes
}
else if(minn > mino)
{
    minutes_max = (60 - minn) + mino;
    hrso = hrso-1;
}

else

  minutes_max = 0; //minutes_in equals minutes_out


if (hrsn < hrso)
{
    hours_max = 24 - (hrso - hrsn);
}

else if (hrsn > hrso)
{
    hours_max = (24 - hrso) + hrsn;
}

else
hours_max = 0;


hours_max = (hrso - hrsn);


printf("Time in %d:%d\n", hrsn, minn);
printf("Parking Time:  %d hours:%d minutes\n", hours_max, minutes_max);

Tax(&gct,&price_car,&price_truck,&price,&finalprice,&minutes_max,&hours_max,&vehicle[5]);


}


void Tax(float *gct, int *price_car, int *price_truck, int *price, float *finalprice, int *minutes_max, int *hours_max, char *vehicle[5])
{
{
if((strcmp(*vehicle, "car")) == 0)
{
    printf("The price for the car will be shown shortly:");
}
else if( *minutes_max > 1 || *minutes_max < 30)
{
    *price = *price_car + 50;
}
else if(*minutes_max > 30 || *minutes_max < 60)
{
    *price = *price_car + 100;
}
else if( *hours_max >= 1)
{
    *price = (*price_car+100) * *hours_max;
}

*finalprice = (*gct * *price) + *price;
}


{
if((strcmp(*vehicle, "truck")) == 0)
{
    printf("The Price for the truck will be shown shortly");
}
else if( *minutes_max > 1 || *minutes_max < 30)
{
    *price = *price_truck + 100;
}
else if(*minutes_max > 30 || *minutes_max < 60)
{
    *price = *price_truck + 150;
}
else if( *hours_max >= 1)
{
    *price = (*price_truck+200) * *hours_max;
}

*finalprice = (*gct * *price) + *price;


}

printf("The Final Price is: %f", *finalprice);



}

---

i changed it to a do while in the tax function section but now its running both of the do whiles, please help

Code:

---

#include <stdio.h>
#include <stdlib.h>
#include <string.h>
#include <ctype.h>
#include <math.h>


void Tax(float *gct, int *price_car, int *price_truck, int *price, float *finalprice, int *minutes_max, int *hours_max, char *vehicle[5]);

int main(void)
{

char vehicle[5];
int car;
int truck;
int hrsn; //Hour the vehicle entered the parking lot
int minn; //Minute the vehicle came in the parking lot
int hrso; //Hour the vehicle left the parking lot
int mino; //Minute the vehicle left the parking lot
int hr; //final hour
int min; //final minute
int minutes_max;//60 minutes
int hours_max;//24 hours
hrsn=0;
hrso=0;
minn=0;
mino=0;
hr=0;
min=0;
minutes_max=0;
hours_max=0;
int price=0;
float finalprice=0;
float gct=0.175; //17.5%
int price_car=0;
int price_truck=0;


printf("Where you driving a car or truck?\n");
scanf("%s", &vehicle );

while( strcmp( vehicle, "truck" ) != 0 && strcmp( vehicle, "car" ) != 0 )
{
    printf("Please input the words Car or Truck: ");
    scanf("%s",&vehicle);
}

printf("What Hour did the %s enter the lot? (0-23)\n", vehicle);
scanf("%d",&hrsn);
while((hrsn<0 || hrsn>23))
{
    printf("\a\a\a Please Input Value from 0-23!\n");
    scanf("%d",& hrsn);
}

{
    printf("What Minute did the %s enter the lot? (0-59)\n", vehicle);
    scanf("%d",& minn);
}
while((minn<0 || minn>59))
{
    printf("\a\a\a Please Enter Correct Minute Between 0-59!\n");
    scanf("%d",& minn);
}

{
    printf("What Hour did the %s leave the lot? (0-23)\n", vehicle);
    scanf("%d",& hrso);
}
while((hrso<0 || hrso>23))
{
    printf("\a\a\a Please Enter the Correct Time Between 0-23!\n");
    scanf("%d",& hrso);
}

{
    printf("What Minute did the %s leave the lot? (0-59)\n", vehicle);
    scanf("%d",& mino);
}
while(mino<0 || mino>59)
{
    printf("\a\a\a PLease Enter the Correct time between 0-59!\n");
    scanf("%d",& mino);
}


if(minn < mino)
{
  minutes_max = 60 - (mino - minn);
  //minutes_max = 60 - 5
  //minutes_max = 55 minutes
}
else if(minn > mino)
{
    minutes_max = (60 - minn) + mino;
    hrso = hrso-1;
}

else

  minutes_max = 0; //minutes_in equals minutes_out


if (hrsn < hrso)
{
    hours_max = 24 - (hrso - hrsn);
}

else if (hrsn > hrso)
{
    hours_max = (24 - hrso) + hrsn;
}

else
hours_max = 0;


hours_max = (hrso - hrsn);


printf("Time in %d:%d\n", hrsn, minn);
printf("Parking Time:  %d hours:%d minutes\n", hours_max, minutes_max);

Tax(&gct,&price_car,&price_truck,&price,&finalprice,&minutes_max,&hours_max,&vehicle[5]);


}


void Tax(float *gct, int *price_car, int *price_truck, int *price, float *finalprice, int *minutes_max, int *hours_max, char *vehicle[5])
{

do{
printf("The price for the car will be shown shortly:\n");

if( *minutes_max > 1 || *minutes_max < 30)
{
    *price = *price_car + 50;
}
else if(*minutes_max > 30 || *minutes_max < 60)
{
    *price = *price_car + 100;
}
else if( *hours_max >= 1)
{
    *price = (*price_car+100) * *hours_max;
}

*finalprice = (*gct * *price) + *price;

printf("The Final Price is: %f\n", *finalprice);
}while((strcmp(*vehicle, "car")) == 0);

do{
    printf("The Price for the truck will be shown shortly\n");

if( *minutes_max > 1 || *minutes_max < 30)
{
    *price = *price_truck + 100;
}
else if(*minutes_max > 30 || *minutes_max < 60)
{
    *price = *price_truck + 150;
}
else if( *hours_max >= 1)
{
    *price = (*price_truck+200) * *hours_max;
}

*finalprice = (*gct * *price) + *price;

printf("The Final Price is: %f\n", *finalprice);

}while((strcmp(*vehicle, "truck")) == 0);

}

---

Quote:

---

$ gcc -Wall park.c
park.c: In function ‘main’:
park.c:39: warning: format ‘%s’ expects type ‘char *’, but argument 2 has type ‘char (*)[5]’
park.c:44: warning: format ‘%s’ expects type ‘char *’, but argument 2 has type ‘char (*)[5]’
park.c:123: warning: passing argument 8 of ‘Tax’ from incompatible pointer type
park.c:8: note: expected ‘char **’ but argument is of type ‘char *’

---

• If you're planning on storing "truck", you need at least 6 characters (5 + 1 for the null).
• In the scanf calls, you only need vehicle. The name of an array serves as a pointer to it's first element.
• The parameter char *vehicle[5] in the Tax function is an array of pointers-to-char, you just want the *, no [].
• Once you fix that parameter, remove the * from vehicle in the strcmp calls in Tax.

Quote:

---

park.c:14: warning: unused variable ‘truck’
park.c:13: warning: unused variable ‘car’
park.c:126: warning: control reaches end of non-void function

---

• You can ditch car and truck since they're not used.
• You said main would return an int, so make it do just that (return 0 at the end).

Without re-reading the entire thread, the problem is that you have two distinct do-while loops in your Tax function. A do-while loop always executes at least one time. That means that you will always run the car tax code and the truck tax code at least once each. You can always switch the do-while loops to an if-else setup:

Code:

---

if it's a car
    do car calcs
else if it's a truck
    do truck calcs

---

First of all thx for the quick response since the deadline is drawing much closer and if u could look at my older post i did try the if else an while if else set up and it didnt work at all

Try to use the simple logic shown by Anduril, above:

Code:

---

if(it's a car)
  //do what you need for a car
else //it's a truck
  //do what you need for a truck

---

Then post your latest code, and I'll study it when I return in 2 hours. Now, I have to go.

i keep getting the same results every time if i choose truck or car with any amount of time but truck's result is different from car's

Code:

---

#include <stdio.h>
#include <stdlib.h>
#include <string.h>
#include <ctype.h>
#include <math.h>


void Tax(float *gct, int *price_car, int *price_truck, int *price, float *finalprice, int *minutes_max, int *hours_max, char *vehicle);

int main(void)
{

char vehicle[6];
int hrsn; //Hour the vehicle entered the parking lot
int minn; //Minute the vehicle came in the parking lot
int hrso; //Hour the vehicle left the parking lot
int mino; //Minute the vehicle left the parking lot
int hr; //final hour
int min; //final minute
int minutes_max;//60 minutes
int hours_max;//24 hours
hrsn=0;
hrso=0;
minn=0;
mino=0;
hr=0;
min=0;
minutes_max=0;
hours_max=0;
int price;
price=0;
float finalprice;
finalprice=0;
float gct;
gct=0.175; //17.5%
int price_car;
price_car=0;
int price_truck;
price_truck=0;

printf("Where you driving a car or truck?\n");
scanf("%s", &vehicle );

while( strcmp( vehicle, "truck" ) != 0 && strcmp( vehicle, "car" ) != 0 )
{
    printf("Please input the words Car or Truck: ");
    scanf("%s",&vehicle);
}

printf("What Hour did the %s enter the lot? (0-23)\n", vehicle);
scanf("%d",&hrsn);
while((hrsn<0 || hrsn>23))
{
    printf("\a\a\a Please Input Value from 0-23!\n");
    scanf("%d",& hrsn);
}

{
    printf("What Minute did the %s enter the lot? (0-59)\n", vehicle);
    scanf("%d",& minn);
}
while((minn<0 || minn>59))
{
    printf("\a\a\a Please Enter Correct Minute Between 0-59!\n");
    scanf("%d",& minn);
}

{
    printf("What Hour did the %s leave the lot? (0-23)\n", vehicle);
    scanf("%d",& hrso);
}
while((hrso<0 || hrso>23))
{
    printf("\a\a\a Please Enter the Correct Time Between 0-23!\n");
    scanf("%d",& hrso);
}

{
    printf("What Minute did the %s leave the lot? (0-59)\n", vehicle);
    scanf("%d",& mino);
}
while(mino<0 || mino>59)
{
    printf("\a\a\a PLease Enter the Correct time between 0-59!\n");
    scanf("%d",& mino);
}


if(minn < mino)
{
  minutes_max = 60 - (mino - minn);
  //minutes_max = 60 - 5
  //minutes_max = 55 minutes
}
else if(minn > mino)
{
    minutes_max = (60 - minn) + mino;
    hrso = hrso-1;
}

else
{
    minutes_max = 0; //minutes_in equals minutes_out
}

if (hrsn < hrso)
{
    hours_max = 24 - (hrso - hrsn);
}

else if (hrsn > hrso)
{
    hours_max = (24 - hrso) + hrsn;
}

else
{
    hours_max = 0;
}

hours_max = (hrso - hrsn);

printf("Time in %d:%d\n", hrsn, minn);
printf("Parking Time:  %d hours:%d minutes\n", hours_max, minutes_max);

Tax(&gct,&price_car,&price_truck,&price,&finalprice,&minutes_max,&hours_max,&vehicle);
return 0;
}


void Tax(float *gct, int *price_car, int *price_truck, int *price, float *finalprice, int *minutes_max, int *hours_max, char *vehicle)
{

if((strcmp(vehicle, "car")) == 0)
{
printf("The price for the car will be shown shortly:\n");

if( *minutes_max > 1 || *minutes_max < 30)
{
    *price = *price_car + 50;
}
else if(*minutes_max > 30 || *minutes_max < 60)
{
    *price = *price_car + 100;
}
else if( *hours_max >= 1)
{
    *price = (*price_car+100) * *hours_max;
}

*finalprice = (*gct * *price) + *price;

printf("The Final Price is: %f\n", *finalprice);
}
else

if((strcmp(vehicle, "truck")) == 0)
{
    printf("The Price for the truck will be shown shortly\n");

if( *minutes_max > 1 || *minutes_max < 30)
{
    *price = *price_truck + 100;
}
else if(*minutes_max > 30 || *minutes_max < 60)
{
    *price = *price_truck + 150;
}
else if( *hours_max >= 1)
{
    *price = (*price_truck+200) * *hours_max;
}

*finalprice = (*gct * *price) + *price;

printf("The Final Price is: %f\n", *finalprice);

}

}

---

Code:

---

scanf("%s", &vehicle);
...
Tax(&gct,&price_car,&price_truck,&price,&finalprice,&minutes_max,&hours_max,&vehicle);

---

Remove the & from those two places. The name of the array is a pointer to it's first element, so vehicle is a char *. That makes &vehicle a char **, which is not what Tax wants.

I formatted and tweaked your program. Can't tell if it's accurate or not, but the car and truck pricing is different in the test I made.

Check it out, and use it in any future posts, because I'm not spending any more time formatting your code and removing useless code, again.

Code:

---

#include <stdio.h>
#include <string.h>
#include <ctype.h>

void Tax(float *gct, int *price_car, int *price_truck, int *price, float *finalprice, int *minutes_max, int *hours_max, char *vehicle);

int main(void)
{
  char vehicle[6];
  int hrsn; //Hour the vehicle entered the parking lot
  int minn; //Minute the vehicle came in the parking lot
  int hrso; //Hour the vehicle left the parking lot
  int mino; //Minute the vehicle left the parking lot
  int hr; //final hour
  int min; //final minute
  int minutes_max;//60 minutes
  int hours_max;//24 hours
  int price;
  int price_car;
  int price_truck;
  int i, length;
  float finalprice;
  float gct;
  hrsn=0;
  hrso=0;
  minn=0;
  mino=0;
  hr=0;
  min=0;
  minutes_max=0;
  hours_max=0;
  price=0;
  finalprice=0;
  gct=0.175; //17.5%
  price_car=0;
  price_truck=0;
 
  printf("\n\nWhere you driving a car or truck?\n");
  scanf("%s", &vehicle );
 
  while( strcmp( vehicle, "truck" ) != 0 && strcmp( vehicle, "car" ) != 0 )
  {
    printf("Please input the words Car or Truck: ");
    scanf("%s",&vehicle);
  }
  length = strlen(vehicle); 
  for (i=0; i<length; i++) 
  { //change all vehicle letters to lowercase
    vehicle[i] = tolower(vehicle[i]);
  }

  printf("What Hour did the %s enter the lot? (0-23)\n", vehicle);
  scanf("%d",&hrsn);
  while((hrsn<0 || hrsn>23))
  {
    printf("\a\a\a Please Input Value from 0-23!\n");
    scanf("%d",& hrsn);
  }
    printf("What Minute did the %s enter the lot? (0-59)\n", vehicle);
    scanf("%d",& minn);

  while((minn<0 || minn>59))
  {
    printf("\a\a\a Please Enter Correct Minute Between 0-59!\n");
    scanf("%d",& minn);
  }
  printf("What Hour did the %s leave the lot? (0-23)\n", vehicle);
  scanf("%d",& hrso);
 
  while((hrso<0 || hrso>23))
  {
    printf("\a\a\a Please Enter the Correct Time Between 0-23!\n");
    scanf("%d",& hrso);
  }
  printf("What Minute did the %s leave the lot? (0-59)\n", vehicle);
  scanf("%d",& mino);
 
  while(mino<0 || mino>59)
  {
    printf("\a\a\a PLease Enter the Correct time between 0-59!\n");
    scanf("%d",& mino);
  }
  if(minn < mino)
  {
    minutes_max = 60 - (mino - minn);
    //minutes_max = 60 - 5
    //minutes_max = 55 minutes
  }
  else if(minn > mino)
  {
    minutes_max = (60 - minn) + mino;
    hrso = hrso-1;
  }
  else
  {
    minutes_max = 0; //minutes_in equals minutes_out
  }
  if (hrsn < hrso)
  {
    hours_max = 24 - (hrso - hrsn);
  }
  else if (hrsn > hrso)
  {
    hours_max = (24 - hrso) + hrsn;
  }
  else
  {
    hours_max = 0;
  }
  hours_max = (hrso - hrsn);
  printf("Time in %d:%d\n", hrsn, minn);
  printf("Parking Time:  %d hours:%d minutes\n", hours_max, minutes_max);
 
  Tax(&gct,&price_car,&price_truck,&price,&finalprice,&minutes_max,&hours_max,vehicle);
  return 0;
}
void Tax(float *gct, int *price_car, int *price_truck, int *price, float *finalprice, int *minutes_max, int *hours_max, char *vehicle)
{
  if((strcmp(vehicle, "car")) == 0)
  {
    printf("The price for the car will be shown shortly:\n");
    if( *minutes_max > 1 && *minutes_max < 30)
    {
      *price = *price_car + 50;
    }
      else if(*minutes_max > 30 && *minutes_max < 60)
    {
      *price = *price_car + 100;
    }
    else if( *hours_max >= 1)
    {
      *price = (*price_car+100) * *hours_max;
    }
    *finalprice = (*gct * *price) + *price;
    printf("The Final Price is: %f\n", *finalprice);
  }
  else
  //if((strcmp(vehicle, "truck")) == 0)
  {
    printf("The Price for the truck will be shown shortly\n");
    if( *minutes_max > 1 && *minutes_max < 30)
    {
      *price = *price_truck + 100;
    }
    else if(*minutes_max > 30 && *minutes_max < 60)
    {
      *price = *price_truck + 150;
    }
    else if( *hours_max >= 1)
    {
      *price = (*price_truck+200) * *hours_max;
    }
    *finalprice = (*gct * *price) + *price;
    printf("The Final Price is: %f\n", *finalprice);
  }
}

---

Thanks for neating up the code i tried different stuff with the tax part but it just aint working for me

Quote:

---

Originally Posted by zangetsu

Thanks for neating up the code i tried different stuff with the tax part but it just aint working for me

---

Ok, it's not calculating the tax correctly. Let's debug:

1) What input is giving the right answer? Anything?

2) What input is giving the wrong answer? What's the right answer for this input?

Post up the arithmetic that should be used for the tax. I don't want to use the code, if it's known to be wrong.

What's the equation for the tax? Do you have an equation, instead of a description, to calculate the tax?

When you say "Tax", you mean "Parking Charge", right?

its like this, car and truck are suppose to have different prices and tax is the added on Government tax onto the fare. So its the fare plus tax. so for 0 to 30 mins its bout $50 for car, and 30 mins to 60 is treated like an hour so its $100 then every hour is $100
so the final thing is finalprice=(gct X price)+price, before this during the 0 to 30 mins thing if u look at the code its like price=price_car+50 and gct = %17.5 or 0.175

OK. thanks for clearing that up.

Now, what vehicle and what time for that vehicle, is giving the wrong output?

What should the answer be to that same vehicle, and that same time?

it doesn't matter what i put in, i'm always getting the same answer. BAsically 30 minutes should be $50 +tax for a car and it should be $100 for every hour

What if I'm there for an hour and a half?

Code:

---

if minutes between 1 and 29
    ... no, i'm at minutes 30
ELSE
if minutes between 30 and 59
    ... yes, my minutes are at 30
ELSE
if hours ...
    ... yes i have one hour, but you can't check that, because you already checked minutes

---

See your problem yet?


Quzah.

i think so are u saying that since i only want 30mins and a hour i should take out the 30 to 59 part? is that what your saying cause im not too understanding your non-sentences

What he's saying is that your arithmetic on the hours and minutes, fails if the vehicle is there for 90 minutes.

Try it and see if Quzah is correct.

Quote:

---

Originally Posted by Adak

What he's saying is that your arithmetic on the hours and minutes, fails if the vehicle is there for 90 minutes.

Try it and see if Quzah is correct.

---

I see my dead horse is still kicking...

Frankly I'm a little amazed that nobody here has come straight out and told the OP he could probably do this job in about 50 lines of code if he simply converted the time to minutes.

It doesn't matter when the car or truck arrived. It doesn't matter when it left. What matters is how long it was parked on the lot...

1.Get the start time as hours and minutes from the operator.
2.Get the end time as hours and minutes from the operator.
3.Calculate the number of minutes on the lot (maybe 15 or 20 lines of code so far)
4.If more than 30 minutes, work out the charge for the first 30 minutes. (5 lines max)
5.Subtract 30 from the number of minutes on the lot. (1 line)
6.Work out the charge for the rest of the time. (2 or 3 lines)
7. Add up the two charges (1 line)
8. Calculate tax on the total (2 lines max)
9. Print the guy's bill (5 lines max)

The fact there are two rates in play chould add no more than 5 extra lines to the code.

Really... This is not a complex problem.

Tater, you told him several times. Obviously, he doesn't want to do that. Not everyone is as good at beating zee dead horse, as you are! :p

Good to see you're still at it - +1 for sticking with it. I'm not going to mention that it will happen when pigs fly. :p :p

The tickets you get from the parking garage, will typically show time in and time out.

Quote:

---

Originally Posted by Adak

Tater, you told him several times. Obviously, he doesn't want to do that. Not everyone is as good at beating zee dead horse, as you are! :p

Good to see you're still at it - +1 for sticking with it. I'm not going to mention that it will happen when pigs fly. :p :p

---

Even you, my patient friend, have to admit, it's getting just a bit ridiculous.

Quote:

---

Really... This is not a complex problem.

---

Clearly, you never met the next of kin to Rube Goldberg! ANYTHING can be a complex problem. Just give them a chance...

Hey Tater thx for try with me eve nthough most of the time i have no idea what your talking about but at number 5. why would i do that could u pls explain that part

Quote:

---

Originally Posted by zangetsu

Hey Tater thx for try with me eve nthough most of the time i have no idea what your talking about but at number 5. why would i do that could u pls explain that part

---

Looking at your code I was of the impression you had a gate fee... a flat rate for the first 30 minutes... So that's what that was about...

Anyway... here it is in 49 lines... AND... it accounts for passing midnight, passing new years, leap years, different rates for cars and trucks and even long stays... (It's not properly error trapped for stuff like exit before enter or invalid dates and times... but it's working here.)

Code:

---

// CITY PARKING
#include <stdio.h>
#include <time.h>
// monetary values
#define PRICE_CAR    1.25      // car rate per hour
#define PRICE_TRUCK  2.50      // truck rate per hour
#define GATE_CHARGE  5.00      // flat rate for flat rate period
#define GATE_TIME    30        // length of  flat rate period
#define SALES_TAX    17.5      // tax addon in percent

int _cdecl main( void )
  { int tOnLot = 0;
    float Rate = PRICE_CAR;
    printf("\n\t\t *****  CITY PARKING *****\n\n");
    // get time in and time out
    { struct tm tIn = {0}, tOut = {0};
      printf("Enter dates and times numerically as YYYY MM DD HH MM\n\n");
      printf("Time In  :\t");
      scanf("%d %d %d %d %d",&tIn.tm_year,&tIn.tm_mon,&tIn.tm_mday,
                              &tIn.tm_hour,&tIn.tm_min);
      tIn.tm_year -= 1900;
      printf("Time Out :\t");
      scanf("%d %d %d %d %d",&tOut.tm_year,&tOut.tm_mon,&tOut.tm_mday,
                              &tOut.tm_hour,&tOut.tm_min);
      tOut.tm_year -= 1900;
      tOnLot = (mktime(&tOut) - mktime(&tIn)) / 60; }  // time in minutes 
    // get vehicle type and set hourly rate
    { getchar();
      printf("\nIs this a Truck? (Y or N) : ");
      int vt = getchar();
      if ( vt == 'y' || vt == 'Y')
        Rate = PRICE_TRUCK; } 
    // display time
    printf("\nTime on Lot : %d minutes\n\n",tOnLot);   
    // calculate billable time
    { float Total = 0;
      float Time = 0;
      float Tax = 0;
      tOnLot -= GATE_TIME;
      printf("Gate Fee  :\t%8.2f\n",GATE_CHARGE);
      if( tOnLot > 0)
        { Time = (tOnLot * Rate) / 60.0;
          printf("Time      :\t%8.2f  (%dmin @ $%.2fhr) \n",Time,tOnLot,Rate); }
      Total = GATE_CHARGE + Time;
      printf("SubTotal  :\t%8.2f\n", Total);
      Tax = Total * (SALES_TAX / 100.0);
      printf("Sales Tax :\t%8.2f\n\n",Tax);
      Total += Tax;
      printf("Total Due :\t%8.2f\n\n",Total); } 
    return 0; }

---

Thanks for taking the time out to show me an example of what u were talking about i'll try and emulate the tax part into my program but i'm not going to put in the year, month and day part cause i wouldn know how to error check for the different days of the month like e.g how february only has 28 days. but what is important in my assignment is that my function are split and are not into one big main function.

Quote:

---

Originally Posted by zangetsu

Thanks for taking the time out to show me an example of what u were talking about i'll try and emulate the tax part into my program but i'm not going to put in the year, month and day part cause i wouldn know how to error check for the different days of the month like e.g how february only has 28 days. but what is important in my assignment is that my function are split and are not into one big main function.

---

1) The Time library should automatically know things like days in months, leap years, dayligh savings etc. That's what it's about... you give it a year, month, day, hour, minute, second and it converts that into the number of seconds since midnight, January 1, 1970. Then all time functions have a common reference... You can then add, subtract, etc. The only real error check you should need is if tOnLot ends up a negative number.

2) If you look closely at the way I wrote that code you'll find "extra" brackets in there. These are scopes that could easily be broken out into their own functions.

But I agree you should not hand in my example... if your prof does any searching, you're busted! You do need to rewrite your own version. The point was to show you how easily it can be done when you convert the time to seconds or minutes, as appropriate.

when i run some tests on your code i took out year month and day and it didnt work i actually got the same number that i use to get from my previous code.lol the 58.75
this is what i modified with your code

Code:

---

// CITY PARKING
#include <stdio.h>
#include <time.h>
// monetary values
#define PRICE_CAR    50.25      // car rate per hour
#define PRICE_TRUCK  100.50      // truck rate per hour
#define GATE_CHARGE  50.00      // flat rate for flat rate period
#define GATE_TIME    30        // length of  flat rate period
#define SALES_TAX    17.5      // tax addon in percent

int _cdecl main( void )
  { int tOnLot = 0;
    float Rate = PRICE_CAR;
    printf("\n\t\t *****  CITY PARKING *****\n\n");
    // get time in and time out
    { struct tm tIn = {0}, tOut = {0};
      printf("Enter dates and times numerically as HH MM\n\n");
      printf("Time In _________________________________\n");

      printf("Hour:\n");
      scanf("%d",&tIn.tm_hour);

    while((tIn.tm_hour<0 || tIn.tm_hour>24))
  {
    printf("\a\a\a Please Input Correct Hour!\n");
    scanf("%d",& tIn.tm_hour);
  }
      printf("Mintues:\n");
      scanf("%d",&tIn.tm_min);

    while((tIn.tm_min<0 || tIn.tm_min>59))
  {
    printf("\a\a\a Please Input Correct Minutes!\n");
    scanf("%d",& tIn.tm_min);
  }

      printf("Time Out _________________________________\n");

      printf("Hour:\n");
      scanf("%d",&tOut.tm_hour);

    while((tOut.tm_hour<0 || tOut.tm_hour>24))
  {
    printf("\a\a\a Please Input Correct Hour!\n");
    scanf("%d",& tOut.tm_hour);
  }
      printf("Mintues:\n");
      scanf("%d",&tOut.tm_min);

    while((tOut.tm_min<0 || tOut.tm_min>59))
  {
    printf("\a\a\a Please Input Correct Minutes!\n");
    scanf("%d",& tOut.tm_min);
  }

      tOnLot = (mktime(&tOut) - mktime(&tIn)) / 60; }  // time in minutes
    // get vehicle type and set hourly rate
    { getchar();
      printf("\nIs this a Truck? (Y or N) : ");
      int vt = getchar();
      if ( vt == 'y' || vt == 'Y')
        Rate = PRICE_TRUCK; }
    // display time
    printf("\nTime on Lot : %d minutes\n\n",tOnLot);
    // calculate billable time
    {
      float Total = 0;
      float Time = 0;
      float Tax = 0;
      tOnLot -= GATE_TIME;
      printf("Gate Fee  :\t%8.2f\n",GATE_CHARGE);
      if( tOnLot > 0)
        {
          Time = (tOnLot * Rate) / 60.0;
          printf("Time      :\t%8.2f  (%dmin @ $%.2fhr) \n",Time,tOnLot,Rate);
        }
      Total = GATE_CHARGE + Time;
      printf("SubTotal  :\t%8.2f\n", Total);
      Tax = Total * (SALES_TAX / 100.0);
      printf("Sales Tax :\t%8.2f\n\n",Tax);
      Total += Tax;
      printf("Total Due :\t%8.2f\n\n",Total);
      }
    return 0;
    }

---

That's right... the time library works on the number of seconds since midnight January 1, 1970... you're giving it year 0, month 0, day 0 ...

Moreover your mini-version fails to account for crossing midnight, month end, year end etc.

If you don't care about these things don't use time ... just take (hour * 60 ) + minutes and subtract.

Thx its done an it works i just need two more functions now anybody have any ideas of what i could add to this apart from allocating or keeping track of parking space cause that sounds hella difficult.lol

my program is basically finished now i jus need some error checking in there but don't know how i tried the isalpha thing for my menu its below scanf for choice but it doesn't work

Code:

---

#include <stdio.h>
#include <conio.h>
#include <windows.h>
#include <ctype.h>

#define CAR 1
#define TRUCK 2

/* to store vehicle number, and its
  row-column position in an array */
struct vehicle
{
    int num;
    int row;
    int column;
    int type;
};
int isdigit( int ch );
int isalpha( int ch );
int parking_lot[4][10];  /* a 2-D array to store number of vehicle parked */
int V_count;  /* to store total count of vehicles */
int carcount;    /* stores total count of cars */
int truckcount;  /* stores total count of trucks */

void display();
void changecolumn(struct vehicle*);
struct vehicle * add(int, int, int, int);
void delete_func(struct vehicle*);
void getfreerowcolumn(int, int*);
void get_info(int, int, int*);
void show();

/* decrements the column. number by one
  this fun. is called when the data is
  shifted one place to left */
void changecolumn(struct vehicle *P)
{
    P -> column = P -> column-1;
}

/* adds a data of vehicle */
struct vehicle* add(int t, int num, int row, int column)
{
    struct vehicle *P;

    P=(struct vehicle*) malloc(sizeof(struct vehicle));

    P -> type=t;
    P -> row=row;
    P -> column=column;

    if(t==CAR)
          carcount++;
    else
          truckcount++;

    V_count++;
    parking_lot[row][column]=num;

    return P;
}

/* deletes the data of the specified
  car from the array, if found */
void delete_func(struct vehicle *P)
{
    int c;

    for (c=P -> column;c<9;c++)
            parking_lot[P -> row][c] = parking_lot[P -> row][c+1];

    parking_lot[P -> row][c]=0;

    if(P -> type == CAR)
        carcount--;
    else
        truckcount--;

        V_count--;
}

/* get the row-column position for the vehicle to be parked */
void getfreerowcolumn (int type, int *arr)
{
    int r, c, fromrow = 0, torow = 2;

    if(type == TRUCK)
    {
        fromrow += 2;
        torow += 2;
    }

    for(r=fromrow;r<torow;r++)
    {
        for(c=0;c<10;c++)
        {
            if(parking_lot[r][c]==0)
            {
                arr[0] = r;
                arr[1] = c;
                return 0;
            }
        }
    }

    if(r == 2 || r == 4)
    {
        arr[0] = -1;
        arr[1] = -1;
    }
}

/* get the row-column position for the vehicle with specified number */
void get_info (int type, int num, int *arr)
{
    int r, c, fromrow = 0, torow = 2;

    if(type == TRUCK)
    {
        fromrow += 2;
        torow += 2;
    }

    for(r=fromrow;r<torow;r++)
    {
        for(c=0;c<10;c++)
        {
            if(parking_lot[r][c] == num)
            {
                arr[0] = r;
                arr[1] = c;
                return 0;
            }
        }
    }

    if(r == 2 || r == 4)
    {
        arr[0] = -1;
        arr[1] = -1;
    }
}

/* displays list of vehicles parked */
void display()
{
    int r, c;

    printf("Cars ->\n");

    for(r=0;r<4;r++)
    {
        if(r == 2)
            printf("Trucks ->\n");

        for(c=0;c<10;c++)
          printf("%d\t",parking_lot[r][c]);
          printf("\n");
    }
}

void main()
{
    int choice, type, number, row = 0, column = 0;
    int i, tarr[2];
    int finish = 1;
    int hrsn=0; //Hour the vehicle entered the parking lot
    int minn=0; //Minute the vehicle came in the parking lot
    int hrso=0; //Hour the vehicle left the parking lot
    int mino=0; //Minute the vehicle left the parking lot
    int minutes_max=0;//60 minutes
    int hours_max=0;//24 hours


    struct vehicle *P;

    /* creates a 2-D array of car and truck class */
    struct vehicle *car[2][10];
    struct vehicle *truck[2][10];

    system("CLS");

    /* displays menu and calls corresponding functions */
    while(finish)
    {
        system("CLS");
        system("color 02");


    printf("\t\t***************************************\n");
    printf("\t\t***************************************\n");
    printf("\t\t**        Courtney Reid            **\n");
    printf("\t\t**                                  **\n");
    printf("\t\t**          6A Business              **\n");
    printf("\t\t**                                  **\n");
    printf("\t\t**          Mr. Brown              **\n");
    printf("\t\t**                                  **\n");
    printf("\t\t**      Computer Science            **\n");
    printf("\t\t**                                  **\n");
    printf("\t\t**                                  **\n");
    printf("\t\t***************************************\n");
    printf("\t\t***************************************\n\n\n");


        printf("\nCar Parking\n");
        printf("1. Arrival of a vehicle\n");
        printf("2. Departure of vehicle\n");
        printf("3. Total number of vehicles parked\n");
        printf("4. Total number of Cars parked\n");
        printf("5. Total number of Trucks parked\n");
        printf("6. Display order in which vehicles are parked\n");
        printf("7. Display Parking Time\n");
        printf("8. Exit\n");

        scanf("%d", &choice);
        if(isalpha(choice))
        printf( "You entered a letter of the alphabet\n" );



        switch(choice)
        {
            case  1 :

            system("CLS");

            printf("What Hour did the vehicle enter the lot? (0-23)\n");
            scanf("%d",&hrsn);

            while((hrsn<0 || hrsn>23))
            {
                printf("\a\a\a Please Input Value from 0-23!\n");
                scanf("%d",&hrsn);
            }

            printf("What Minute did the vehicle enter the lot? (0-59)\n");
            scanf("%d",&minn);

            while((minn<0 || minn>59))
            {
                printf("\a\a\a Please Enter Correct Minute Between 0-59!\n");
                scanf("%d",&minn);
            }
            printf("Time in %d:%d\n", hrsn, minn);

                printf("\nAdd: \n");

                type = 0;

                /* check for vehicle type */
                while(type != CAR && type != TRUCK)
                {
                    printf("Enter vehicle type (1 for Car / 2 for Truck ): \n");
                    scanf("%d", &type);
                    if(type != CAR && type != TRUCK)
                        printf("\nInvalid vehicle type.\n");
                }

                printf("Enter vehicle number: ");
                scanf("%d", &number);
                /* add cars' data */
                if(type == CAR || type == TRUCK)
                {
                    getfreerowcolumn(type, tarr);

                    if(tarr[0] != -1 && tarr[1] != -1)
                    {
                        row = tarr[0];
                        column = tarr[1];

                        if(type == CAR)
                            car[row][column] =  add(type, number, row, column);
                        else
                            truck[row - 2][column] = add(type, number, row, column);
                    }
                    else
                    {
                        if(type == CAR)
                            printf("\nNo parking slot free to park a Car\n");
                        else
                            printf("\nNo parking slot free to park a Truck\n");
                    }
                }
                else
                {
                    printf("Invalid type\n");
                }

                printf("\nPress any key to continue...");

                getch();
                break;

            case  2 :

            system("CLS");

            printf("Departure\n");

            printf("What Hour did the vehicle leave the lot? (0-23)\n");
            scanf("%d",&hrso);

            while((hrso<0 || hrso>23))
            {
                printf("\a\a\a Please Enter the Correct Time Between 0-23!\n");
                scanf("%d",&hrso);
            }

            printf("What Minute did the vehicle leave the lot? (0-59)\n");
            scanf("%d",&mino);

            while(mino<0 || mino>59)
            {
                printf("\a\a\a PLease Enter the Correct time between 0-59!\n");
                scanf("%d",&mino);
            }
            printf("Time Out %d:%d\n", hrso, mino);

                type = 0;

                /* check for vehicle type */
                while(type != CAR && type != TRUCK)
                {
                    printf("Enter vehicle type 1 for Car or 2 for TRUCK : \n");
                    scanf("%d", &type);
                    if(type != CAR && type != TRUCK)
                        printf("\nInvalid vehicle type.\n");
                }
                printf("Enter number: ");
                scanf("%d", &number);

                if(type == CAR || type == TRUCK)
                {
                    get_info(type, number, tarr);
                    if(tarr[0] != -1 && tarr[1] != -1)
                    {
                        column = tarr[1];

                        /* if the vehicle is car */
                        if(type == CAR)
                        {
                            row=tarr[0]-2;
                            if(!(row<0))
                            {
                            delete_func(car[row][column]);
                            for(i=column;i<9;i++)
                            car[row][i] = car[row][i+1];
                            {
                                changecolumn(car[row][column]);
                            }
                            car[row][i] = NULL;
                            }

                        }
                        /* if a vehicle is truck */
                        else
                        {
                            row = tarr[0]-2;
                            if(!(row<0))
                            {
                                delete_func(truck[row][column]);
                                for(i=column;i<9;i++)
                                    truck[row][i] = truck[row][i+1];
                                {
                                    changecolumn(truck[row][column]);
                                }
                                truck[row][i] = NULL;
                            }
                        }
                    }
                    else
                    {
                        if(type==CAR)
                            printf("\nInvalid car number, or a car with such number has not been parked here.\n");
                        else
                            printf("\nInvalid truck number, or a truck with such number has not been parked here.\n");
                    }
                }

                printf("\nPress any key to continue...");
                getch();
                break;

            case 3 :


                system("CLS");
                printf("Total vehicles parked: %d\n", V_count);
                printf("\nPress any key to continue...");
                getch();
                break;

            case  4 :

                system("CLS");
                printf("Total cars parked: %d\n", carcount);
                printf("\nPress any key to continue...");
                getch();
                break;

            case  5 :

                system("CLS");
                printf("Total trucks parked: %d\n", truckcount);
                printf("\nPress any key to continue...");
                getch();
                break;

            case  6 :

                system("CLS");
                printf("Display\n");
                display();
                printf("\nPress any key to continue...");
                getch();
                break;

            case  7 :

                system("CLS");

                  if(minn < mino)
                {
                    minutes_max = mino - minn;
                    //minutes_max = 60 - 5
                    //minutes_max = 55 minutes
                }
                    else if(minn > mino)
                    {
                        minutes_max = (60 - minn) + mino;
                        hrso = hrso-1;
                    }
                        else
                        {
                            minutes_max = 0; //minutes_in equals minutes_out
                        }

        if (hrsn < hrso)
        {
            hours_max = 24 - (hrso - hrsn);
        }
            else if (hrsn > hrso)
            {
                hours_max = (24 - hrso) + hrsn;
            }
                else
                {
                    hours_max = 0;
                }

                hours_max = (hrso - hrsn);

                printf("Parking Time: %d hours:%d minutes\n", hours_max, minutes_max);
                printf("\nPress any key to continue...");
                getch();
                break;


            case  8 :

                system("CLS");
                exit(1);
                break;

        }
    }
}

---

choice is an int. You are interpreting the input as an int because scanf has "%d". The case statement checks for 1 - 8. Also correct.

isalpha() is meant to be used on a character.

k most if not all of my input are integers so most of my number inputs crash when i put an char instead of a number i put a default after my last case break but it didn't fix the menu problem

Code:

---

default: system ("CLS"); printf("\n\t\t\tPLEASE SELECT A VALID OPTION");main();

---

Quote:

---

Originally Posted by zangetsu

k most if not all of my input are integers so most of my number inputs crash when i put an char instead of a number i put a default after my last case break but it didn't fix the menu problem

Code:

---

default: system ("CLS"); printf("\n\t\t\tPLEASE SELECT A VALID OPTION");main();

---

---

NEVER call main() as a function... way too much goes wrong when you do that.

If you want to check whether the user typed in letters instead of digits then you must allow any arbitrary chars as input. Not force interpretation by scanf's %d. Use %s and simply capture the string into a char buffer. Then loop through each character to make sure it's '0' to '9 only.

tried that an got an error i'm seriously not understanding and i don't see any c examples of error proofing which is really sad

Code:

---

#include <stdio.h>
#include <conio.h>
#include <windows.h>
#include <ctype.h>

#define CAR 1
#define TRUCK 2

/* stores vehicle number and its
  row-column position in an array */
struct vehicle
{
    int num;
    int row;
    int column;
    int type;
};
int isdigit( int ch );
int isalpha( int ch );
int parking_lot[4][10];  /* a 2-D array to store number of vehicles parked */
int V_count;  /* stores total count of vehicles */
int carcount;    /* stores total count of cars */
int truckcount;  /* stores total count of trucks */

void display();
void changecolumn(struct vehicle*);
struct vehicle * add(int, int, int, int);
void delete_func(struct vehicle*);
void getfreerowcolumn(int, int*);
void get_info(int, int, int*);
void show();

/* decrements the column. number by one
  this fun. is called when the data is
  shifted one place to left */
void changecolumn(struct vehicle *P)
{
    P -> column = P -> column-1;
}

/* adds a data of vehicle */
struct vehicle* add(int t, int num, int row, int column)
{
    struct vehicle *P;

    P=(struct vehicle*) malloc(sizeof(struct vehicle));

    P -> type=t;
    P -> row=row;
    P -> column=column;

    if(t==CAR)
          carcount++;
    else
          truckcount++;

    V_count++;
    parking_lot[row][column]=num;

    return P;
}

/* deletes the data of the specified
  car from the array, if found */
void delete_func(struct vehicle *P)
{
    int c;

    for (c=P -> column;c<9;c++)
            parking_lot[P -> row][c] = parking_lot[P -> row][c+1];

    parking_lot[P -> row][c]=0;

    if(P -> type == CAR)
        carcount--;
    else
        truckcount--;

        V_count--;
}

/* get the row-column position for the vehicle to be parked */
void getfreerowcolumn (int type, int *arr)
{
    int r, c, fromrow = 0, torow = 2;

    if(type == TRUCK)
    {
        fromrow += 2;
        torow += 2;
    }

    for(r=fromrow;r<torow;r++)
    {
        for(c=0;c<10;c++)
        {
            if(parking_lot[r][c]==0)
            {
                arr[0] = r;
                arr[1] = c;
                return 0;
            }
        }
    }

    if(r == 2 || r == 4)
    {
        arr[0] = -1;
        arr[1] = -1;
    }
}

/* get the row-column position for the vehicle with specified number */
void get_info (int type, int num, int *arr)
{
    int r, c, fromrow = 0, torow = 2;

    if(type == TRUCK)
    {
        fromrow += 2;
        torow += 2;
    }

    for(r=fromrow;r<torow;r++)
    {
        for(c=0;c<10;c++)
        {
            if(parking_lot[r][c] == num)
            {
                arr[0] = r;
                arr[1] = c;
                return 0;
            }
        }
    }

    if(r == 2 || r == 4)
    {
        arr[0] = -1;
        arr[1] = -1;
    }
}

/* displays list of vehicles parked */
void display()
{
    int r, c;

    printf("Cars ->\n");

    for(r=0;r<4;r++)
    {
        if(r == 2)
            printf("Trucks ->\n");

        for(c=0;c<10;c++)
          printf("%d\t",parking_lot[r][c]);
          printf("\n");
    }
}

void main()
{
    int type, number, row = 0, column = 0;
    int i, tarr[2];
    int finish = 1;
    int hrsn=0; //Hour the vehicle entered the parking lot
    int minn=0; //Minute the vehicle came in the parking lot
    int hrso=0; //Hour the vehicle left the parking lot
    int mino=0; //Minute the vehicle left the parking lot
    int minutes_max=0;//60 minutes
    int hours_max=0;//24 hours
    char* choice;

    struct vehicle *P;

    /* creates a 2-D array of car and truck class */
    struct vehicle *car[2][10];
    struct vehicle *truck[2][10];

    system("CLS");

    /* displays menu and calls corresponding functions */
    while(finish)
    {
        system("CLS");
        system("color 02");


    printf("\t\t***************************************\n");
    printf("\t\t***************************************\n");
    printf("\t\t**        Courtney Reid            **\n");
    printf("\t\t**                                  **\n");
    printf("\t\t**          6A Business              **\n");
    printf("\t\t**                                  **\n");
    printf("\t\t**          Mr. Brown              **\n");
    printf("\t\t**                                  **\n");
    printf("\t\t**      Computer Science            **\n");
    printf("\t\t**                                  **\n");
    printf("\t\t**                                  **\n");
    printf("\t\t***************************************\n");
    printf("\t\t***************************************\n\n\n");


        printf("\nCar Parking\n");
        printf("1. Arrival of a vehicle\n");
        printf("2. Departure of vehicle\n");
        printf("3. Total number of vehicles parked\n");
        printf("4. Total number of Cars parked\n");
        printf("5. Total number of Trucks parked\n");
        printf("6. Display order in which vehicles are parked\n");
        printf("7. Display Parking Time\n");
        printf("8. Exit\n");

        scanf("%s", &choice);
        if(isalpha(choice))
        printf( "You entered a letter of the alphabet\n" );




        switch(choice)
        {
            case  1 :

            system("CLS");

            printf("What Hour did the vehicle enter the lot? (0-23)\n");
            scanf("%d",&hrsn);

            while((hrsn<0 || hrsn>23))
            {
                printf("\a\a\a Please Input Value from 0-23!\n");
                scanf("%d",&hrsn);
            }

            printf("What Minute did the vehicle enter the lot? (0-59)\n");
            scanf("%d",&minn);

            while((minn<0 || minn>59))
            {
                printf("\a\a\a Please Enter Correct Minute Between 0-59!\n");
                scanf("%d",&minn);
            }
            printf("Time in %d:%d\n", hrsn, minn);

                printf("\nAdd: \n");

                type = 0;

                /* check for vehicle type */
                while(type != CAR && type != TRUCK)
                {
                    printf("Enter vehicle type (1 for Car / 2 for Truck ): \n");
                    scanf("%d", &type);
                    if(type != CAR && type != TRUCK)
                        printf("\nInvalid vehicle type.\n");
                }

                printf("Enter vehicle number: ");
                scanf("%d", &number);
                /* add cars' data */
                if(type == CAR || type == TRUCK)
                {
                    getfreerowcolumn(type, tarr);

                    if(tarr[0] != -1 && tarr[1] != -1)
                    {
                        row = tarr[0];
                        column = tarr[1];

                        if(type == CAR)
                            car[row][column] =  add(type, number, row, column);
                        else
                            truck[row - 2][column] = add(type, number, row, column);
                    }
                    else
                    {
                        if(type == CAR)
                            printf("\nNo parking slot free to park a Car\n");
                        else
                            printf("\nNo parking slot free to park a Truck\n");
                    }
                }
                else
                {
                    printf("Invalid type\n");
                }

                printf("\nPress any key to continue...");

                getch();
                break;

            case  2 :

            system("CLS");

            printf("Departure\n");

            printf("What Hour did the vehicle leave the lot? (0-23)\n");
            scanf("%d",&hrso);

            while((hrso<0 || hrso>23))
            {
                printf("\a\a\a Please Enter the Correct Time Between 0-23!\n");
                scanf("%d",&hrso);
            }

            printf("What Minute did the vehicle leave the lot? (0-59)\n");
            scanf("%d",&mino);

            while(mino<0 || mino>59)
            {
                printf("\a\a\a PLease Enter the Correct time between 0-59!\n");
                scanf("%d",&mino);
            }
            printf("Time Out %d:%d\n", hrso, mino);

                type = 0;

                /* check for vehicle type */
                while(type != CAR && type != TRUCK)
                {
                    printf("Enter vehicle type 1 for Car or 2 for TRUCK : \n");
                    scanf("%d", &type);
                    if(type != CAR && type != TRUCK)
                        printf("\nInvalid vehicle type.\n");
                }
                printf("Enter number: ");
                scanf("%d", &number);

                if(type == CAR || type == TRUCK)
                {
                    get_info(type, number, tarr);
                    if(tarr[0] != -1 && tarr[1] != -1)
                    {
                        column = tarr[1];

                        /* if the vehicle is car */
                        if(type == CAR)
                        {
                            row=tarr[0]-2;
                            if(!(row<0))
                            {
                            delete_func(car[row][column]);
                            for(i=column;i<9;i++)
                            car[row][i] = car[row][i+1];
                            {
                                changecolumn(car[row][column]);
                            }
                            car[row][i] = NULL;
                            }

                        }
                        /* if a vehicle is truck */
                        else
                        {
                            row = tarr[0]-2;
                            if(!(row<0))
                            {
                                delete_func(truck[row][column]);
                                for(i=column;i<9;i++)
                                    truck[row][i] = truck[row][i+1];
                                {
                                    changecolumn(truck[row][column]);
                                }
                                truck[row][i] = NULL;
                            }
                        }
                    }
                    else
                    {
                        if(type==CAR)
                            printf("\nInvalid car number, or a car with such number has not been parked here.\n");
                        else
                            printf("\nInvalid truck number, or a truck with such number has not been parked here.\n");
                    }
                }

                printf("\nPress any key to continue...");
                getch();
                break;

            case 3 :


                system("CLS");
                printf("Total vehicles parked: %d\n", V_count);
                printf("\nPress any key to continue...");
                getch();
                break;

            case  4 :

                system("CLS");
                printf("Total cars parked: %d\n", carcount);
                printf("\nPress any key to continue...");
                getch();
                break;

            case  5 :

                system("CLS");
                printf("Total trucks parked: %d\n", truckcount);
                printf("\nPress any key to continue...");
                getch();
                break;

            case  6 :

                system("CLS");
                printf("Display\n");
                display();
                printf("\nPress any key to continue...");
                getch();
                break;

            case  7 :

                system("CLS");

                  if(minn < mino)
                {
                    minutes_max = mino - minn;
                    //minutes_max = 60 - 5
                    //minutes_max = 55 minutes
                }
                    else if(minn > mino)
                    {
                        minutes_max = (60 - minn) + mino;
                        hrso = hrso-1;
                    }
                        else
                        {
                            minutes_max = 0; //minutes_in equals minutes_out
                        }

        if (hrsn < hrso)
        {
            hours_max = 24 - (hrso - hrsn);
        }
            else if (hrsn > hrso)
            {
                hours_max = (24 - hrso) + hrsn;
            }
                else
                {
                    hours_max = 0;
                }

                hours_max = (hrso - hrsn);

                printf("Parking Time: %d hours:%d minutes\n", hours_max, minutes_max);
                printf("\nPress any key to continue...");
                getch();
                break;


            case  8 :

                system("CLS");
                exit(1);
                break;

            default:

                system ("CLS");
                printf("Incorrect input please try again");
                getch();
                break;
        }
    }
}

---