if, else if question

Can someone please explain why this program does not work? Also, for some reason, I cannot get my cin.get() to pause and await a key press from the user. I know both items are rather simple but I have drawn a blank. Thank you all!

Code:

---

#include <iostream>
#include <cstdlib>

int choice;

int main()
{
    using namespace std;

    cout << "Do you want to hear a joke?" << endl;
    cout << "Enter y for yes or n for no:" << endl;
    cin >> choice;

        if (choice == 'y' || choice == 'Y')
        {
            cout << "\n" << endl;
            cout << "What do you call a guy with" << endl;
            cout << "no arms and no legs laying on the floor?" << endl;
            cout << "\n" << endl;
            cin.get();
            cout << "Matt!" << endl;
        }
        else if (choice == 'n' || choice == 'N')
        {
            cout << "Program will end." << endl;
            return 1;
        }
return 0;
}

---

'y' is a char, not an int.

Quote:

---

Originally Posted by tabstop

'y' is a char, not an int.

---

Thanks tabstop! Really appreciate it, but can you tell me why my cin.get() doe not work? What I am wanting to do is make the program stop and await the user to press any key to allow the program to continue and show the result.

cin.get works exactly as it's supposed to. The problem is that what it is supposed to do is not "make the program stop and wait for the user to press any key". In fact, there's not really any standard C++ function that does that, since C++ doesn't really expect there to be a keyboard on the other end.

get will wait for a line of input to be entered. Since there already is a line of input there, from you asking the question earlier (but only reading in a single character instead of the whole thing) there's no reason to wait.

Quote:

---

Originally Posted by tabstop

cin.get works exactly as it's supposed to. The problem is that what it is supposed to do is not "make the program stop and wait for the user to press any key". In fact, there's not really any standard C++ function that does that, since C++ doesn't really expect there to be a keyboard on the other end.

get will wait for a line of input to be entered. Since there already is a line of input there, from you asking the question earlier (but only reading in a single character instead of the whole thing) there's no reason to wait.

---

Thanks! I suppose the only way to actually do that is use a system pause but then again that would not be portable. I appreciate the insight.

A simple solution might be:

Code:

---

std::cin.ignore();
std::string guess;
std::getline(std::cin, guess);

---

Quote:

---

Originally Posted by StainedBlue

A simple solution might be:

Code:

---

std::cin.ignore();
std::string guess;
std::getline(std::cin, guess);

---

---

That's really a press any key followed by enter command, and because his program already has "using namespace std;", all those std::'s are just going to confuse him.

I think I remember seeing a press any key to continue code in a program from a book I read earlier this year, but I can't find it in there and can't remember it at all :\