Code working but not after 1 day

Hi all,

First, I am new to this forum :)
I've just started playing with the C language. And I wanted to create a script which will keep my game server online. The script is working fine. It checks if the port is in use and then sends a players status command to the server. If the server doesnt respond the process will get killed and restarted.
After a while, lets say 1 day the script doesnt know anymore if the server is online it keeps killing the process over and over even when it is online.
I thought that it may be had to do with the sockets which I need to close or something, to many sockets opened?
Here is a piece of code:

Code:

---

peer.sin_family      = AF_INET;
from = atoi("****");

check = 0;
peer.sin_addr.s_addr = resolv("***.***.***.***");
peer.sin_port = htons(from);
printf("All done, Please sit back while I'll keep an eye on your server.\n");
while( 1 < 3) {
        sleep(PLENTYOFSEC);
        sd = socket(AF_INET, SOCK_DGRAM, IPPROTO_UDP);
        if(sd < 0) std_err();
        if(sendto(sd, "\\status\\", 8, 0, (struct sockaddr *)&peer, sizeof(peer))< 0) std_err();
        if(timeout(sd, TIMEOUT) < 0 ) {
                printf("\nServer IS NOT running!!! Count: %hu \n\n ", check);
                system("killall process.exe");
                system("sh restart.sh");
                check ++;
            } else {
                if (scan == check) {
                        fputs(".", stdout);
                }
        }
close(sd);
}

---

Thanks in advance.

You don't close the socket if scan is not equal to check, whatever scan may be. Also, UDP is unreliable; if it doesn't reply it doesn't mean it's down. You should at least try it several times before you assume it's not up.

Okay thats right yes not in this piece, but wouldnt it be the best way to put

Code:

---

close(sd);

---

in the end of the loop?

Edit:
Okay ive changed the code now. Putted the socket close in the end of the loop.
But isnt it a bit strange that it works the first couple of hours well and after it then not? I will try to check the udp connection multiple times thanks.

Quote:

---

Originally Posted by sheepilja

Okay thats right yes not in this piece, but wouldnt it be the best way to put

Code:

---

close(sd);

---

in the end of the loop?

Okay ive changed the code now. Putted the socket close in the end of the loop.
But isnt it a bit strange that it works the first couple of hours well and after it then not? I will try to check it multiple times thanks.

---

No that's not strange. At one point, you will have so many sockets open that the operating system will refuse to provide you more. "socket()" should fail, then, though.