Printable View
Okay, I want my program to read a text file and print it, but it doesn't seem to do that. Instead, it prints the first letter, which I type in, when it asks for the file name. A little help please? :(
I know it's a simple problem, but I just recently started and would appreciate some advice, thanks!
Coding deleted
Mikacho from JPM forums?
You were capturing a single character, this declares an array of characters.Code:..}
PS, if you want to deal with files you should learn how to open a file for reading and print the file contents to stdout.
ngfjmhfm,dm,dg
Haha, on JPM I am Google. Or, The Yellow Brick Road when I wasn't banned.
Confused by what you wanted, feels like you're trying to do two things at once.
edit:
You should probably close the file before exiting as well, with fclose(fp);
scanf("%s", &key);
Both of you, tenchu and Mikahcho, should note that key is not the same type as &key. According to the manual, scanf requires a pointer to the type of storage indicated by each conversion specifier in the format string. key, as a string, is already converted to a pointer to char when you use it in this context.
You were Yellow Brick Road??! Dude, I loved you back then... You were so witty, why'd you get banned? ;-;
Sorry if my request wasn't clear...
What I need is a program which asks the user to input a file location. The program finds the text file, and reads it, character by character, and prints it on screen. That's it ;_;
Okay, my friend just told me that I should be using a while statement and the fgetc function... So I might try to play around with that... And I'll try the code you wrote out, THANK YOU! :D
@Whiteflags
I didn't understand what you said... Eurgh, programming is the bain of my life haha
What you want is the answer I posted over in this other topic -> http://cboard.cprogramming.com/c-pro...ser-space.html
Except you want the user to enter the file location/name and not hard code it. You have already done that part, now you just need to combine that with with the other example.
I was banned because the admin didn't like my wittiness. =(
Whiteflags, so what you're saying is:
name[] = string
name = address of the array
Scanf requires the address and therefore the & was redundant?
I left the & in because it was part of his original code, I just slapped the [20] on the other key so I could capture the "%s" I didn't think to remove the &
~_~
>> I didn't understand what you said... Eurgh, programming is the bain of my life haha
What you're doing is wrong, so stop.
You've declared in your program that key is
char key[20];
and you use it like
scanf("%s", &key);
The address of operator gets the address of the array. This works out to the type char (*)[20] meaning a pointer to array. The address of operator is one of the few contexts where arrays are not condensed to pointers to the zeroth element. It would be wrong even if that did happen, but the point is scanf is not built with pointers to arrays in mind.
Like with other functions, scanf can change your string with a pointer to the zeroth element. The identifier key becomes such a pointer in many contexts, and this is one of those. You could also write anything equivalent to what scanf actually needs. I hope this is all clear.
jtdjyrfjyrdjyd
edit: deleted double post in case you missed it.
It works for me on Linux. What are you entering for the filename? You may not need to add the directory if it's in the same directory as the executable.
It was son goku, haha.
Is it possible to pm on this forum? It seems I can't do it...
I don't see a PM yet, maybe I need more posts or maybe I am blind haha.
If you ever want to PM me you can PM me on JPM.
fp=fopen("%s\n", "w");
This will try to open a file for writing named "%s
" which I doubt will work.
And you're still doing this. I posted a more complete reply before you posted this code, so please stop using &key after you read it. It doesn't work for printf either.Code:FILE *fp;
fp=fopen("%s\n", "w");
printf("%s\n", &key);
char c;
while (c != NULL){
c = fgetc(fp);
printf("%s", &key);
}
Be aware that key will never change in that display loop. Based on what you've described, you could do it like this: edit tenchu's given example to fill up the array and then print the array whenever the array is full. Repeat this until the file is empty. Remember, you're working with strings!
Read the pm I sent you please...
I removed quoted code.
I think strings are really tricky. They are one of my most hated things to deal with. It takes some getting used to.
I think, to get good at C, you'd need a creative mind and a technical mind... I lack the latter... :[
Can we not have so many conversations going on at once please? It's really confusing for me, since I will never have access to the private discussion in order to help. And honestly, I don't know who "son goku" is or why he matters. We should be concentrating on the task at hand which would solve all of the problem!
Mikahcho can you post what your code is now. Maybe we can try harder.
Quote:
Originally Posted by whiteflags
Ahhh, sorry Whiteflag, Techu is helping me out, and we're almost finished, I think. Thanks for the offer though, I really appreciate it (:
Sorry about the conversation, we happened to know one another from somewhere else and randomly bumped into one another here. I was able to help one on one and explain things in detail.
We were able to solve the problem as well as an IDE issue he had which was shooting some weird errors.
Do you realize how RUDE it is to remove code from a message forum?
Not really. Seeing as it's no longer needed, I don't understand why I should leave it there. It was such a simple question, anyway. Most of you would do it in a flash, undoubtedly.Quote:
Do you realize how RUDE it is to remove code from a message forum?