Issue with pointers and data types (in functions)

:confused:

I cant seem to make this work i have an issue when i call the function into main, the data type of the array is NOT compatible...

I know I have to change the pointers or data type, but if i do, i don't get the right median number or the combination is incompatible.

Please help me out, I been trying this little piece of code for more than 3 hours.

Thank you

Code:

---

#include <stdio.h>
#include <math.h>
#include <stdlib.h>
#define maxarr 30

void show_median(double *[], int counter);


int main ()
{
        double arr[maxarr], value;
        int counter, i;
        counter=0;
        scanf("%lf", &value);
        while(value !=-1)
        {
                arr[counter]= value;
                printf("Please enter '-1' to stop entering values.\n");
                scanf("%lf", &value);
                counter=counter+1;
        }
        printf("values entered are:\n\n");
        i=0.0;
        while(i<counter)
        {
                printf("%.1lf  ", arr[i]);
                i=i+1;
        }


      show_median(arr, counter);

      return 0;
}
void show_median(double *arr[], int counter)
{
        int mid;
        double median2;
        mid=counter/2.0;
        if(counter%2)
                median2= (*arr[mid]+*arr[mid/+1])/2.0;
        else (median2=*arr[mid]);
        printf("median is : %.1lf\n", median2);

}

---

double *arr[] -> double * arr
median2= (*arr[mid]+*arr[mid/+1])/2.0; -> median2= (arr[mid] + arr[mid/+1]) / 2.0;
else (median2=*arr[mid]); -> else (median2 = arr[mid]);

Btw, it is convention that macros are all UPPERCASE, to avoid name conflicts.
Also, you seem to be confusing integers are doubles, interchanging them where they really are not usable. They don't cause harm, but still...
If you add ".0" to a number, you get a double. If you don't, you get an integer.

Example:
>>while(value !=-1)
Here you are comparing a double to an integer. No problem since the integer is promoted to a double, but you might want to know.

>>mid=counter/2.0;
This is pointless (or might give a warning) since the result is truncated to an int afterwards anyway. You may as well divide by only "2".

And lastly, i = i + 1 is the same as i++. Same for counter.