Array of Linked Lists: Status Access Violation!!

I'm building a 'simulated' web browsing experience that simply intakes character strings, pretends their URLs, and does what a web browser would do. It creates a cache and moves strings that have already been encountered to the front of the list etc. Note it begins with an array of structures that contain pointers to linked lists.

The problem i'm having is when i call any of my functions all i get is:

Code:

---

0 [main] WebBrowse 5456 exception::handle: Exception: STATUS_ACCESS_VIOLATION
307 [main] WebBrowse 5456 open_stackdumpfile: Dumping stack trace to WebBrowse.exe.stackdump

---

here is my code:

Code:

---

#include <stdio.h>
#include <stdlib.h>
#include <string.h>
#define HASHSIZE 101
#define MAXLIST 5
struct hashlist{
        int listsize;//number of items in linked list
        struct linklist *head;//pointer to head of linked list
        struct linklist *tail;//pointer to tail of linked list
};
struct linklist{
        struct linklist *next; // pointer to next entry in chain
        char *str; // page name
        int count; // count for occurrence
};
static struct hashlist *hashtab[HASHSIZE]; // pointer table

/*hash: form hash value for string s */
unsigned int hash(char *s){
        unsigned hashval;

        for(hashval = 0; *s != '\0'; s++)
                hashval = *s + 31 * hashval;
        return hashval % HASHSIZE;
}
/*builds the structure with input string*/
struct linklist *buildNode(char *s){
        struct linklist *temp = NULL;
        temp = malloc(sizeof(struct linklist));

        temp->str = s;
        temp->count = 0;
        temp->next = NULL;
        return temp;
}
/*searches linked list to see if string already exists*/
struct linklist *search(char *s){
        struct linklist *np;

        for(np = hashtab[hash(s)]->head; np != NULL; np = np->next){
                if(strcmp(s, np->str) == 0)
                        return np; //found it
        }
        return NULL; //didn't find it
}
/*inserts structure into list*/
struct linklist *insert(char *url){
        struct linklist *test = NULL;
        struct linklist *ins = NULL;

        if((test = search(url)) == NULL) //doesnt yet exist
                ins = buildNode(url);
        hashtab[hash(url)]->head = &ins;
        return ins;
}

---

when i use:

Code:

---

int main(){
        setvbuf(stdout, NULL, _IONBF, 0);
        char s[] = "test";
        insert(s);
        return 0;
}

---

the above error results. I understand the conceptual aspect of the linked list and how the hash function works, but i can't get my code to stop giving me this error.

Am i using pointers incorrectly, or using values when pointer parameters are called? What does Status_Access_Violation signify? Any help would be greatly appreciated. If i was unclear with any of these let me know. Please help!

You are taking address of local variable.

hashtab[hash(url)]->head = &ins;

But it happens when i call the search function as well, which only has a local structure. From what i can gather the address of something is being accessed simultaneously, but i can't see it. Can you see it or walk me through where i went wrong?

Also in your buildNode() function, you might want to make a copy of string.
Btw, Are you ignoring your compiler warning?

There is no compiler warning. In fact it compiles fine, it's only in runtime that it gives me the Status Access Violation error. I've been messing around with linked lists all weekend and i've had no problems. It's only when i try to make an array of structures where each element points to a linked list where i run into issues.

Anyways on my machine there is no compiler warning or error. I'm using Eclipse Helios on Windows 7 Ultimate 64.

Quote:

---

Originally Posted by Zyreal687

But it happens when i call the search function as well, which only has a local structure.

---

Bayint Naung is absolutely right about this problem. Fix this problem first and see if both your problems are solved. If not, solve the remaining problem.

Okay here is the revised version:

Code:

---

struct node *buildNode(char *s){
        struct node *temp = NULL;
        struct hashlist *headList = hashtab[hash(s)];
        temp = malloc(sizeof(struct node));
        char x[strlen(s)+1];
        strcpy(x, s);

        temp->str = x;
        temp->occur = 0;
        temp->next = headList->head;
        headList->head = temp;
        return temp;
}

---

I copied the input string and dealt with it in local. However calling this function still results in a STATUS_ACCESS_VIOLATION. Commenting out these lines:

Code:

---

        temp->next = headList->head;
        headList->head = temp;

---

Removes the error. So anytime i deal with any array element in the array hashtab[] i receive this error. What is the correct way to call an element from an array of structures?

char x[strlen(s)+1]; // this is local variable! again!!!

You are using C99 Variable Length Array(VLA).
Read Question 7.5a.

Thank you Bayint, that link was very helpful.
I've been working on it all week and that bit of information really solved all my segfaults.
It works now!