A simple pointer problem

I am just playing with c++ codes; why here count is printing 0, where I am expecting it to be 10, just want to count how many times the function is called itself.

Code:

---

using namespace std;

void count_fn(int n, int *count)        {
        if(n==0)        {
                return;
        }
        else    {
                *count++;
                n--;
                count_fn(n, count);
        }
}

int main(int argc, char *argv[])
{
        int *count = new int(0);
        count_fn(10, count);
        cout << endl <<"Count is" <<*count << endl;
}

---

Look carefully at:

Code:

---

*count++;

---

This dereferences count, and increments count. Rather, you want to increment the result of dereferencing count.

Remember to delete what you new. In fact, you do not need dynamic memory allocation here: you can create count as an int, then pass its address to the initial call to count_fn. Better yet, you can make count a reference parameter.

Quote:

---

Originally Posted by kapil1089thekin

I am just playing with c++ codes; why here count is printing 0, where I am expecting it to be 10, just want to count how many times the function is called itself.

Code:

---

using namespace std;

void count_fn(int n, int *count)        {
        if(n==0)        {
                return;
        }
        else    {
                *count++;
                n--;
                count_fn(n, count);
        }
}

int main(int argc, char *argv[])
{
        int *count = new int(0);
        count_fn(10, count);
        cout << endl <<"Count is" <<*count << endl;
}

---

---

"*count++" dereferences the pointer, then increments it (the pointer, that is - not the value); parenthesis around the dereference solves the problem. Also, don't forget to call the corresponding "delete".

I have solved it by giving the parentheses, but what difference it makes?
but a problem arises again with the solution

why the 1st code is working but the second code is throwing segmentation fault(core dump)?

1st code:

Code:

---

using namespace std;

void count_fn(int n, int *count)        {
        if(n==0)        {
                return;
        }
        else    {
                (*count)++;
                n--;
                count_fn(n, count);
        }
}

int main(int argc, char *argv[])
{
        int count = 0;
        count_fn(10, &count);
        cout << endl <<"Count is" <<count << endl;
}

---

2nd code

Code:

---

#include<iostream>

using namespace std;

void count_fn(int n, int *count)        {
        if(n==0)        {
                return;
        }
        else    {
                (*count)++;
                n--;
                count_fn(n, count);
        }
}

int main(int argc, char *argv[])
{
        int *count = 0;
        count_fn(10, count);
        cout << endl <<"Count is" <<*count << endl;
}

---

how delete is used?
in the code which I posted previously, just to know the parameters used in delete and when it should be used?

Quote:

---

Originally Posted by kapil1089thekin

I have solved it by giving the parentheses, but what difference it makes?

---

With the parentheses, you are incrementing the result of the dereferencing, not the pointer. Personally, I might write:

Code:

---

++*count;

---

Quote:

---

Originally Posted by kapil1089thekin

why the 1st code is working but the second code is throwing segmentation fault(core dump)?

---

Err... they look identical save for the header inclusion. Are you sure you posted the correct examples?

Quote:

---

Originally Posted by kapil1089thekin

how delete is used?

---

With respect to your example in post #1:

Code:

---

// ...
cout << endl <<"Count is" <<*count << endl;
delete count;

---

I corrected the codes/my post above...

Quote:

---

Originally Posted by kapil1089thekin

I corrected the codes/my post above...

---

Oh, then that is because count in main is a null pointer.