Program accepts input but does not return result as intended

I'm working on a simple program that accepts scores from 20 games. It then is supposed to determine which one is the high score and return that to the screen. The program compiles without errors (using Code::Blocks), and it accepts all 20 inputs, however when it comes to returning the top score, it always returns 0. This is regardless of what numbers are entered. I'm thinking that either a number isn't being stored in the points2 array, highscore integer, or isn't being returned to the variable number. Any help would be much appreciated.

Thanks,

Code:

---

#include <stdio.h>
#include <stdlib.h>
#define RANGE 21
int top_score(int[],int);
int main(void)
{
    int points[RANGE];
    int game = 0;
    int number;
    char instring [20];
    for (game = 1; game <= 20; game++)
    {
        printf ("Enter points scored in game number %d", game);
        gets (instring);
        points [game] = atoi (instring);
    }
    number = top_score(points,game);
    printf ("Highest points scored in a game is %f", number);
}

int top_score (int points2[], int game2)
{
    int index;
    int highscore;
    highscore = points2[0];
    for (index = 1; index < game2; index++)
    {
        if (highscore < points2[index])
        {
            highscore = points2[index];
        }
    }
        return (highscore);
}

---

Why %f?

SIDE HINT: gets is bad. Really really really bad. SourceForge.net: Gets - cpwiki

Array indices start at 0.

You should use

Code:

---

scanf("%d", &points[game]);

---

Also, as msh said, you should use the index starting from 0.

However, one quick thing to do is to print all the numbers on the screen to verify that your array is filling up correctly:

Code:

---


for (game = 0; game < 20; game++)
printf("Score %d = %d\n", game+1, points[game]);

---

However, the value is always 2,293,580. This is strange to me because I'm usually only inputting between 1 and 3 for my individual score values. I'm not sure where this large number is coming from. I used the example from v333k to show what was being stored in my array. It shows as going in correctly. So, I'm thinking that something is wrong in my top_score function.

Thanks msh and tabstop for the help. I have the game index starting at 1 because my array is length 21. Starting it at one prompts to user to input the score for Game 1 instead of Game 0. I figured I'm still only taking 20 entries.

Code:

---

#include <stdio.h>
#include <stdlib.h>
#define RANGE 21
int top_score(int[],int);
int main(void)
{
    int points[RANGE];
    int game = 0;
    int number;
    char instring [20];
    for (game = 1; game <= 20; game++)
    {
        printf ("Enter points scored in game number %d", game);
        scanf("%d", &points[game]);
        printf("Score %d = %d\n", game, points[game]); /*shows what's in my array*/
        points [game] = atoi (instring);
        number = top_score(points,game);
    }

    printf ("Highest points scored in a game is %d", number);
}

int top_score (int points2[], int game2)
{
    int index;
    int highscore;
    highscore = points2[0];
    for (index = 0; index < game2; index++)
    {
        if (highscore < points2[index])
        {
            highscore = points2[index];
        }
    }
        return (highscore);
}

---

wouldn't adding a 'int maxScore = 0;' before your loop and insert in the middle of the for loop 'if (points[game] > maxScore) maxScore = points[game];' and finally a printf("Highest score was %d\n", maxScore); at the end be easier?

Replace %f in the second printf statement with %d.

The reason why this isn't working is so simple that you're gonna kick yourself. I'll point out the offending line, try to see why it's the problem. There's another line that will cause your program to fall short on checking scores as well; i'll point that out as problem two.

Code:

---

#include <stdio.h>
#include <stdlib.h>
#define RANGE 21
int top_score(int[],int);
int main(void)
{
    int points[RANGE];
    int game = 0;
    int number;
    char instring [20];
    for (game = 1; game <= 20; game++)
    {
        printf ("Enter points scored in game number %d", game);
        scanf("%d", &points[game]);
        printf("Score %d = %d\n", game, points[game]); /*shows what's in my array*/
        points [game] = atoi (instring);  <--------------- PROBLEM ONE
        number = top_score(points,game);
    }

    printf ("Highest points scored in a game is %d", number);
}

int top_score (int points2[], int game2)
{
    int index;
    int highscore;
    highscore = points2[0];
    for (index = 0; index < game2; index++) <-------------- PROBLEM TWO
    {
        if (highscore < points2[index])
        {
            highscore = points2[index];
        }
    }
        return (highscore);
}

---

Hope this helps!

(You can thank google alerts, by the way. It's the only reason why I saw this post, LoL)

It kind of looks like you're trying to do a bubble sort.

Ok, I got it to work correctly filling the array correctly and outputting a correct high score.

I still didn't figure out what I had wrong with this line of code, which fatezero pointed out for me.

Code:

---

  for (index = 0; index < game2; index++) <-------------- PROBLEM TWO

---

Thank you everyone who helped point me in the right direction.

Quote:

---

Originally Posted by Anarchristo

I still didn't figure out what I had wrong with this line of code, which fatezero pointed out for me.

Code:

---

  for (index = 0; index < game2; index++) <-------------- PROBLEM TWO

---

---

This for loop is only going to run from index 0, to index 20; your score values are stored at indicies 1 through 21, meaning that the last score is never going to be tested.

If you're going for the bubblesort approach, this is definitely a good start. But a smaller, faster, approach would be something like this:

Code:

---

#include <stdio.h>
#include <stdlib.h>

#define MAXSCORES        20

int main(void)
{
    int points[MAXSCORES];
    int highscore=0;

    for (int game=0; game < 20; game++)
    {
        printf ("Enter points scored in game number %d: ", game+1);
        scanf("%d", &points[game]);

        if (points[game] > highscore) highscore = points[game];
    }

    printf ("Highest points scored in a game is %d\n", highscore);
        return 0;
}

---