Unhandled Exception , access violation reading locations.

Would you please tell me the way to correct this kind of error ??
I have thought many many days and I simply cannot solve this . . . .

Code:

---

void win(Map*initialMap , Map* currentMap , int x , int y){
        int i;
        int j;
        for(i=0; i < currentMap->height ; i++){                               
        // all boxes are pushed into all targets
                for(j=0; j < currentMap->width ; j++){
        if (currentMap->map2D[y+j][x+i]=='@' && initialMap->map2D[y-j][x-i]=='!' )  <-- error
                return ;
                }
        }     
}

int try(Map *initialMap, Map *currentMap, int x, int y, int max_no_of_move, Stack *s) {
        int i,j,k;
        int result=0;
        char q='\0';
        char e[4]={NORTH,SOUTH,EAST,WEST};
        Map tempmap;
        if(max_no_of_move ==0 ) return 0; 
        win(&initialMap,&currentMap,&x,&y) return 1;
          // if not , try each possible directions
        for(i=0;i<4;i++){
                        if ( move_keeper(&initialMap,&currentMap,&x,&y,e[i])) {
                                clone_map(&tempmap,&currentMap);
                                result  = try  ( &currentMap, &tempmap , x, y , max_no_of_move -1 , &s );
                                        if(result) { return result;
                                                //A solution is found
                                                push(&s,e);
                                            }
                                                else {
                                                        q=pop(&s);
                        for(j=0;j<currentMap->width ; j++) {
                        for(k=0;k<currentMap->height;k++){
                                                        tempmap.map2D[k][j]=currentMap->map2D[k][j];
                        }}
                                                }               
                                                return  result;
                        }
                        }
               
       
}

---

OP needs to read http://cboard.cprogramming.com/c-pro...ead-first.html

and this thread should be moved to C++ forum

Quote:

---

Originally Posted by vart

and this thread should be moved to C++ forum

---

I think this is C, not C++, otherwise there would have been a compile error due to the use of a keyword as a function name.

Indeed it is C . . .

And I am thinking of the base case ( pushing all boxes into all targets .. )

I am wondering if this code is correct or not . . .

Code:

---

void win(Map*initialMap , Map* currentMap , int x , int y){
        int i;
        int j;
        for(i=0; i < currentMap->height ; i++){                               
        // all boxes are pushed into all targets
                for(j=0; j < currentMap->width ; j++){
        if (currentMap->map2D[y+j][x+i]=='@' && initialMap->map2D[y-j][x-i]=='!' )  <-- error
                return ;
                }
        }     
}

---

You need a simpler and more transparent one, imo.

Code:

---

int isWon(int currentMap, int offsetR, int offsetC, int maxRowGoal, int maxColGoal) {
  int r, c;
  int won = 1;  //assume game is won

  for(r = 0; r < maxRowGoal; r++) {
    for(c = 0; c < maxColGoal; c++) {
      if(currentMap[r+offsetR][c+offsetC] != answerMap[r][c]) {
        won = 0;
        break;
      }
    }
  }
  return won;
}

---

The offsetR/C gives the starting row and column, and maxRow/ColGoal, gives the ending coordinates. imo a function to check if the game is won, should return SOMETHING to signify if the game is won or not.

I have this game (at least the first 50 levels of one version of it by "Thinking Rabbit"), and there are some levels of it that the solution just makes me laugh. :p