error: ISO C++ forbids declaration of 'string' with no type

Hello all,
I am receiving this error when I try to compile.

Tags.h

Code:

---

#ifndef _TAGS_H
#define _TAGS_H

using namespace std;

class Tags
{
  public:

  void splitStart(const string divider, Tags *first);
 ...
}

---

Why would I be getting this error?

Thanks,
Michael

Probably because you didn't include "<string>" before the file.

But DON'T DON'T DON'T use "using namespace std;" or any using statement in a header file or before you included all header files. Just write "std::string".
Actually, don't do it, in a few projects you'll hit a big wall yourself meaning you'll have to change every header file you made up to that point. That should teach you for the rest of your life; better than me just saying don't do it.

The way you've got it set up now, your header requires that the <string> header be included prior to this header. This forces an ordering of headers in source files which should be avoided as it may or may not compile simply according to the order you're including such headers.

If a header has some object/type that requires a header then that header should be included. This ensures that no matter the ordering of your include statements in the source file, you'll always be able to compile.

You should also avoid any using namespace std declaration in a header and explicitly qualify any needed objects.

Try:

Code:

---

#ifndef _TAGS_H
#define _TAGS_H

#include <string>

class Tags
{
  public:

  void splitStart(const std::string divider, Tags *first);
 ...
}

---

Also, why are you taking a string by const value? Do you really want a *copy* of it?
Since you are passing a const value you can't modify the value anyway. Might as well pass by ref and save some overhead...

Code:

---

void splitStart(const std::string& divider, Tags *first);

---

Quote:

---

Originally Posted by hk_mp5kpdw

The way you've got it set up now, your header requires that the <string> header be included prior to this header. This forces an ordering of headers in source files which should be avoided as it may or may not compile simply according to the order you're including such headers.

If a header has some object/type that requires a header then that header should be included. This ensures that no matter the ordering of your include statements in the source file, you'll always be able to compile.

You should also avoid any using namespace std declaration in a header and explicitly qualify any needed objects.

Try:

Code:

---

#ifndef _TAGS_H
#define _TAGS_H

#include <string>

class Tags
{
  public:

  void splitStart(const std::string divider, Tags *first);
 ...
}

---

---

Hello and thank you all.

Why not use "using namespace std;"??? I've seen this before, but never known or heard why not to use it.

Thanks,
Michael

Quote:

---

Originally Posted by TheBigOnion

Why not use "using namespace std;"??? I've seen this before, but never known or heard why not to use it.

---

Because your header file could be included in source files that do not expect this using directive to be present, thus resulting in a name conflict that might be a compile error, or might even silently alter the meaning of the program.

Quote:

---

Do you really want a *copy* of it

---

If the class std::string is implemented following the COW philosophy it doesn't create a copy unless you modify the string. But I'm not sure if the string class is always implemented that way.