what is wrong with the logic in my loop?

clip of program:

printf( "Hello ;;;;;; " );
printf( "Hello ;;;;;; " );


function to clear everything inside the quotes:

Code:

---

int null_chars(char str[200])
{       
        int i,j=0, x;
        for (i=0; str[i] != '\n' ; i++)
        {
                if (str[i] == '"')                                                       
                        {
                                for( j=i+1 ; str[j] != '"'; j++)
                                {
                                        str[j] = '0';
                                }
                        }
        }

}

---

this causes a huge bug...I have another function that clears comments that written the EXACT same way and works perfectly...I know there's something wrong with the for loop on the inside

You need to escape quotes in strings or as single characters:

Code:

---

if( str[i] == '\"' )

---

Quzah.

that didn't work...it says there is some breakpoint in the loop or somethiing...

A null character and an escape character must have a backslash before them i.e null would be '\0' and the quotes would be '\"'. Also you want to declare index variables or variables exclusive to the loop inside of the for declaration section because it minimizes thier scope, looks less confusing, and saves memory... and to me that extra for loop you have on the inside looks unnecessary.

Here's what I would do (It may not be syntactically correct seeing as how i didn't compile it and I am not a C programmer)

Code:

---

int STRING_LIMIT = 200;
void null_chars(char input[STRING_LIMIT])
{       
        for (int i,in_quotes = 0;i < STRING_LIMIT;i++)
        {
                if(input[i] == '\"')                                               
                {
                        if (in_quotes == 0)
                        {
                                in_quotes = 1;
                        }
                        else
                        {
                                in_quotes = 0;
                        }
                }
                else if(in_quotes == 1)
                {
                        input[i] = '\0';
                }
        }
        /*return or print here?*/
}

---

Thanks! it worked.