Converting C into MIPS Assembly

Hi, I wanted to convert this code into assembly but I'm having trouble. Here's what I got :]

Code:

---

int b = 0, x;
while (x != 0) {
        b += ((x & 03) == 2);
    x >>= 1;

---

believe this is just a basic instruction to count the number of occurrences of the bit sequence “10” (one zero) in x.

Now to convert this, here's what I got:

Code:

---

L1: bne  $s1, $zero, DONE    # branch if ! ( x ==0j )
addu $s0, $ra, $0 #b = 0 store ra
add  $s1, $s1, $s2 #    b+=$s2
beq $s2, $s2, 2 b += ((x & 03) == 2
addi $s3, $s3, 1 #    x>>=1
j    L1 # jump back to top of loop
DONE:

---

but I'm thinking that there are some logical issues with this ASM code. Is there a different way to approach this conversion? Thanks :]

Use a compiler, and study the generated assembler; patch up to match your processor.

It's even easier if you just get a cross-compiler that targets MIPS - the job is as good as done :)

MSVC 2008 has the option to compile for MIPS.

Just a small "thing". You wouldn't be using the "s" registers, since they're designed for "long" use. You'd want to be using the "t" registers to store the temporary values. Doesn't make much sense you're adding to "b" before you evaluate the expression? :\

Not sure why you have a branch-on-equal instruction (beq). I don't see where that would come into your loop, since you'll then skip "x >>= 1;". So yes, your logic is wrong.

As others have said, generating the optimised MIPS assembly would be easier for learning, but don't get in the habit, especially if you have to do this in an exam. You may find the compiler might even be putting things on the stack if it's not optimised.

I would approach this problem by rewriting the C code as simply as possible. Any line that has more than one operator on it probably needs to be simplified (with a few exceptions). Get it to the point where you can rewrite every line of C as a line of MIPS. A few obvious problems that jump out are the fact that you use the << and & operators, but haven't used the corresponding instructions . Also, you're using bne, but the comment right next to it implies the opposite comparison.

If you want to go the compiler route, MIPS-SDE is a cross-compiler available for free download from the MIPS website, but if you already have VS as mentioned above - that's certainly easier. Though I'd second the recommendation not to do so if you're doing this for a class. I don't think there's anything wrong with your approach - you just need to have a better understanding of how each operation in C breaks down into the operations done in Assembly.

If you turn off all optimizations in the MSVS compiler and set it for MIPS you may be able to learn something via its output. I would not turn this code in for credit but it may give you a push in the right direction.