Error in passing arguments

I have defined an abstract class so I must use reference to that class... I also use a list with that type... the problem is when I intent to use the iterator as an argument to a function.
This is the snap:

Code:

---

void sustituir(CTermino *&termino)
      //Dado un termino, le aplica la sustitución y lo entrega modificacdo
      {
          Parser parser;
        if (!(invalida) && !(esSustitucionVacia()))
        {
        //Solicito la lista de parametros del termino, para atenderlo en caso de que sea una funcion
        list<CTermino> * listaParametros = termino->getListaParametros();
        list<CTermino>::iterator it = listaParametros->begin();
       

        //Dependiendo del tipo de termino que sea, lo sustituyo       
        switch (!(termino->perteneceVariable(termino) || parser.esConstante(termino->getSimbolo()))) {
            case false:
                      if ( mapaReemplazos.find(termino->getSimbolo()) != mapaReemplazos.end())
                      {
                        termino = (mapaReemplazos[termino->getSimbolo()]).second;
                      }         
                break;
            case true:
                      while (it != listaParametros->end())
                      {
                        sustituir (*it);
                   
                        it++; 
                      }
                      termino->setListaParametros(*listaParametros);
                  break;   
            default: ;
            }
        delete listaParametros;           
        }
      }

---

When I compile I got:
error: no matching function for call to 'CSustitucion::sustituir(CTermino&)'
note: candidates are: void CSustitucion::sustituir(CTermino*&)

Is it possible to do what I intent to do? What should I do in order to correct such compile error?

Thanks in advance!!!!! :)

Quote:

---

error: no matching function for call to 'CSustitucion::sustituir(CTermino&)'
note: candidates are: void CSustitucion::sustituir(CTermino*&)

---

That error message means that you don't have a function called CSustitucion::sustituir that takes a CTermino reference as a parameter. Instead, it would appear you're instead passing a reference to a pointer? . . . can I see the code for CSustitucion::sustituir()?

That´s the code... it´s recursive function.

Perhaps you should have called it as:

Code:

---

sustituir(&*it);

---

since you need to pass a pointer according to the function signature.

I have also tried that alternative as I did in another case... but I don´t know why it doesn´t work... I intented to do a cast to, but I couldn´t solve the issue.

*sigh*. I'm sorry, I'm very tired at the moment. I would concur with laserlight, that you need to pass it a pointer, since that is what the implementation specifies.

Out of curiosity, why are you passing a reference to a pointer? Unless you're changing what the pointer references, it's slightly redundant . . . I think . . .

CTermino is an abstract class, that´s what I use CTermino *

Quote:

---

Originally Posted by tommantonela

I have also tried that alternative as I did in another case... but I don´t know why it doesn´t work... I intented to do a cast to, but I couldn´t solve the issue.

---

Oh yes, that would not work, and that is directly related to what strange found strange.

The problem is that since the parameter is a non-const reference, one must pass a modifiable lvalue to it. However the result of the address-of operator is an rvalue.

You appear to need to pass the pointer by reference because of this statement:

Code:

---

termino = (mapaReemplazos[termino->getSimbolo()]).second;

---

I have no understanding of what your code actually does, but perhaps you should pass the pointer by value and change the above statement to copy a CTermino object:

Code:

---

*termino = *(mapaReemplazos[termino->getSimbolo()]).second;

---

By the way, please translate your code to English before posting. It makes it easier for most of us to understand your code.

Quote:

---

By the way, please translate your code to English before posting. It makes it easier for most of us to understand your code.

---

Seconded. I cannot tell from the code why you need to pass in *&CTermino or why single indirection (just a simple pointer) would not work just as well.

switching on a bool is truly weird. Especially the default case for neither true or false. A Tri-bool perhaps?
Most people use an if-else-statement.

Sorry for my Spanish Code!!! That function is used in order to solve a part of problems related with First Order Logic... to check the satisfiability of a set of clauses...
The switch is not the problem even though is not the perfect solution...
laserligth, I did what you said but the problem continuos :S

I am a little puzzled though. If CTermino is an abstract base class, then how can you have a list<CTermino>?

Quote:

---

Originally Posted by strange

That error message means that you don't have a function called CSustitucion::sustituir that takes a CTermino reference as a parameter. Instead, it would appear you're instead passing a reference to a pointer? . . . can I see the code for CSustitucion::sustituir()?

---

Unless I am overlooking/simplifying this but the error alone, really, points out the problem. . It specifies the possible candidate that matches your declaration, the compiler is trying to guess on your intentions here.