Don't Understand Class

I remember doing very simple classes in c++ before but I'm having a lot of trouble understanding this use of class. One that reads from file into an array. I would ask my teacher but he just makes it sound ever more confusing and the book that I'm using doesn't even cover how to use a class this way.

Its suppose to read a city and the average temperature for each city.

Here's a piece of the code he wants us to use:

PHP Code:

---

#ifndef _ASSIGNMENT_8_CPP_
#define _ASSIGNMENT_8_CPP_

#include <iostream>
#include <fstream>
#include <string>
#include <iomanip>
#include <cstdlib>

using namespace std;

class DATA {
private:
    char city[20][25];
    int temps[20];
    int HIGH; 
    int LOW; 
    float AVE; 
    char HIGH_city[25]; 
    char LOW_city[25];
public: 
    DATA(); 
    void FileRead(char fname[25]); 
    /* I was taught to do it like "void FileRead(char);". Why is it that way?*/
    void FindMax(); 
    void FindMin(); 
    void FindAve(); 
    void ShowData();
    void Print();
};

DATA::DATA()
{
         //Isn't there suppose to be some code in here?
}

void DATA::FileRead(char fname[25])//Don't understand why "fname" is an array of char
{
    ifstream infile(fname);
    int i = 0, size = 0;
    char temp[32];
    
    while(!infile.eof())
    {
        infile.getline(temp, 30, ' ');
        strcpy(city[i],temp);//Gives me error: " deprecated conversion from string constant to ‘char*’ "
        
        infile.getline(temp, 30);
        temps[i] = atoi(temp);
        
        i++;
        size++;
    }
      /*How am I suppose to use this outside of this function?*/

    infile.close();
} 


---

What do you have trouble understanding?

A class called DATA?

That's about the worst thing I've ever seen. That's like a deliberate slap in the face of OOP (and good software engineering in general).

what brewbuck said...

and also, in an application you include that class, then you declare an instance of the object to access the member.

... and you don't *have to put code in to constructor's/destructor's, just if it applies or if you need to, it's something you decide based on what you're doing.

Code:

---

#include "ASSIGNMENT 8.CPP" // ?

int main()
{
        DATA *lolData = new DATA();
        lolData->FileRead("lotsofdata.txt");
}

---

... you've also left out an #ENDIF at the end there on your class file, and you should probably use a header file for 'awesome practice' compliance to impress your teacher.

The FileRead function is flawed in that it will process the last line of the file twice due to its use of eof to control the looping. Let your instructor know I said that. The eof flag that is tested is only set after an attempt to read past the end of the file fails. When you've successfully reached the last line of the file and processed the data within, eof is still false even though you are physically at the end of the file. Because of this you'll end up going back into the loop and attempting to do the two getline calls which will then fail and set eof to true however at this point you are already in the loop processing bad data.

Code:

---

DATA::DATA()
{
        //Isn't there suppose to be some code in here?
}

---

I don't know... maybe? There doesn't necessarily have to be unless you want the constructor to explicitly do certain "stuff".

Quote:

---

Originally Posted by brewbuck

A class called DATA?

That's about the worst thing I've ever seen. That's like a deliberate slap in the face of OOP (and good software engineering in general).

---

Reminds me, a lot of people still use "Data" as a suffix to a lot of their classes. VertexData, PhysicsData, TextureData, ObjectData, MatrixData, etc. DATA is pretty bad, but besides the caps, not that big a deal especially since it's just schoolwork and not a real personal project.

http://cboard.cprogramming.com/game-...tml#post522672

Thank You all so much for your help. However I still don't know how to use the data I got in the FileRead function in all the other functions.

The data is read in to private members, so if you want to do something with the data other than what is provided through the public functions, you'll need to modify the class and add your own functions.