is gets dangerous?

i wrote this:

Code:

---

// sendinfo is a struct.

.
.
.
 printf(" Name:  ");
 gets(name);
 strcpy(sendinfo.name,name);
.
.
.

---

when i compile it, the compiler prints:
- warning: the `gets' function is dangerous and should not be used.

should i consider this? Why is it dangerous?
thx

AFAIK, because there is absolutely no way to avoid a buffer overflow.

Quote:

---

Originally Posted by anon

AFAIK.

---

what's this?

ok..

then, which function should i use?

fgets is what you should use

char *fgets(char *s, int size, FILE *stream);

eg

Code:

---

fgets(name, 20, stdin);

---

this will read in at most 20 characters into name from stdin. if the user tries to input more than 20 characters, everything after the 20th character will be ignored

Quote:

---

Originally Posted by Brain_Child

this will read in at most 20 characters into name from stdin. if the user tries to input more than 20 characters, everything after the 20th character will be ignored

---

19, actually, including the newline if it is among the first 19.

Quote:

---

Originally Posted by laserlight

19, actually, including the newline if it is among the first 19.

---

Aren't you just counting from zero?

Just out of curiosity, what compiler are you using?

Quote:

---

Originally Posted by laserlight

19, actually, including the newline if it is among the first 19.

---

ah yes, only 19. the 20th spot is reserved for the null byte

thx you all!
i am writing this:

Code:

---

#include <stdio.h>
#include "header.h"

struct account_info sendinfo; 

/* This is header file
struct account_info
{
        char name[15];
        char surname[15];
        int  account_id;
        float  rest;
};
*/

char name[20];

main()
{
        printf("| Name: ");
        fgets(name,20,stdin);
        strcpy(sendinfo.name,name);
       
        printf("Name %c\n", sendinfo.name);
       
}

---

compiler: warning: incompatible implicit declaration of built-in function 'strcpy'

Execution:

| Onoma: john
| Onoma: À

????????????????????

Quote:

---

Originally Posted by johnybe

compiler: warning: incompatible implicit declaration of built-in function 'strcpy'

---

You should #include <string.h> for strcpy(). Also, avoid global variables, and in this case you can yse sendinfo.name directly.

Quote:

---

Originally Posted by laserlight

You should #include <string.h> for strcpy(). Also, avoid global variables, and in this case you can yse sendinfo.name directly.

---

Thx! i dont have anymore this warning... but it stills not printing my entry...

> printf("Name %c\n", sendinfo.name);

Pretty sure you wanted %s for string, there.

Open a console window and type the path to your program, too.

Quote:

---

Originally Posted by whiteflags

> printf("Name %c\n", sendinfo.name);

Pretty sure you wanted %s for string, there.

---

oh my god! yes... thxxx!!

Code:

---

Open a console window and type the path to your program, too.

---

what do you mean?

In windows there is a program called the "Command Prompt" found from Start in Accessories. Open one up, and start your program from there by typing the path to the executable, then you'll be able to see everything that happens no matter what.

Quote:

---

Originally Posted by whiteflags

Aren't you just counting from zero?

---

What do you mean?

Quote:

---

Originally Posted by C_ntua

Just out of curiosity, what compiler are you using?

---

gcc (GCC) 4.1.2 20080704 (Red Hat 4.1.2-46)
Copyright (C) 2006 Free Software Foundation, Inc.
This is free software; see the source for copying conditions. There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.