Assigning something

Im trying to initialize code with keyCode and id with keyId respectively. Why do I get ['strcpy' makes integer from pointer without cast]?

Code:

---

Key * ky_new(const char * keyCode, int keyId)
{
 Key * ky = (Key *)malloc(sizeof(Key));
 if (ky != NULL)
    {
    strcpy(ky->code , keyCode);
    ky->id = keyId;
    }
 return ky;
}

---

Because you don't have #include <string.h> at the top of the file.

Nope, I've double checked. I do have #include <string.h> .What's the problem then?Thkc

Not clear can u explain it further and one more thing r u getting an error or result is not correct if result is not correct then u can do like

memset(ky, 0, sizeof(ky));

or always do allocation with calloc

Quote:

---

Originally Posted by Jasper

Nope, I've double checked. I do have #include <string.h> .What's the problem then?Thkc

---

If you had string.h at the top of this file (not just somewhere in your code), then you wouldn't be getting this error (you might be "making pointer from integer without a cast" but not the other way around).

This has to do with modular decomposition. The code I gave was in the c file. This one below is in the h.file.

Code:

---

typedef struct
{
 int id;
 char code;
}Key;

---

So now you are making a pointer from an integer without a cast, because code is a single character and cannot be used in a string context.

code is a char; it can only hold one character.
strcpy copies in a string, but you do not have any place to copy that string...

So.... should I change strcpy(ky->code , keyCode); to ky->code = keyCode; ? Ive tried it but it still gives the same exact error. Thkx

You need to change your struct.

You need to make sure there is room in your code member. A string in C is an array of characters.

Quote:

---

Originally Posted by tabstop

You need to change your struct.

---

or change the const char * keyCode to const char keyCode

Neither. You do not seem to understand what they do.

Elysia, u mean Im supposed to allocate memory for code? If that is so,is the code below the way to do it?

Code:

---

keyCode = (char *) malloc(code * sizeof(char);

---

keyCode already contains valid memory!
However, ky->code does not! It contains room for ONE char only. Either you expand it using an array or make it a pointer and allocate using malloc. Only then you have to remember to free it later.