Memory Leak!!!!

Hi Friends,

I have a question!!!

Actually memory is allocated for a particular variable like this :

Code:

---

{

struct InstanceDataStruct *instanceData;

  instanceData = (struct InstanceDataStruct*)malloc(sizeof InstanceDataStruct));

//some codes are there
//some codes are there
    .......
    .......

try
  {
            pthread_mutex_lock(&mutex);
    setWSSecurity(siei_abus, sieiUserId, sieiPsw);
        instanceData->client = new ATT::SIEIClient(sieiWsdl, siei_abus);
        pthread_mutex_unlock(&mutex);
  }
      catch (IT_Bus::Exception& e) {
      setRemedyReturnStatus(
        status, AR_RETURN_ERROR, AR_ERROR_CONNECT, "Couldn't create client connection");
        pthread_mutex_unlock(&mutex);
        return AR_RETURN_ERROR;        // Error at this line,says memory is lost
}

---

Please help me out

Thanks in Advance!!!

And what is the question?

Why to use malloc in C++?

Could you use static allocation?

You also need to:
1) Stop mixing tabs and spaces, thus fixing the indentation.
2) If 1) does not fix the indentation, fix it now.
3) Show relevant code, preferably the minimal amount of code needed to represent the problem, because there's absolutely no way to determine why from your code right now.

instanceData is not being deallocated before that return statement. That's one of the possible memory leaks.
Then whoever wrote this code is allocating again for one of it's members in instanceData->client = new ATT::SIEIClient(sieiWsdl, siei_abus), that's your second memory leak since instanceData itself never gets deallocated.

Because you are allocating memory, but you never free it.

change -

Code:

---

struct InstanceDataStruct *instanceData;

  instanceData = (struct InstanceDataStruct*)malloc(sizeof InstanceDataStruct));

---

to

Code:

---

struct InstanceDataStruct  instanceData;

---

and the problem should go away if its related to the malloc. Without more specific information that's all i can suggest.

Thanks a lot friend!!!!!

Thanks a lot friend!!!!

HI Mario F.,

I have 2 catch statements within which 2 return statements are there.So should i need deallocate memory twice for your reference :

Code:

---




struct InstanceDataStruct *instanceData;

  instanceData = (struct InstanceDataStruct*)malloc(sizeof InstanceDataStruct));

//some codes are there
//some codes are there
    .......
    .......

try
  {
            pthread_mutex_lock(&mutex);
    setWSSecurity(siei_abus, sieiUserId, sieiPsw);
        instanceData->client = new ATT::SIEIClient(sieiWsdl, siei_abus);
        pthread_mutex_unlock(&mutex);
  }



      catch (IT_Bus::Exception& e) {
        setStatus("ARPluginCreateInstance:", status, (char *) e.message());
        pthread_mutex_unlock(&mutex);
        return AR_RETURN_ERROR;          // 1 return statement here
      }
      catch (...) {
        pthread_mutex_unlock(&mutex);
        return AR_RETURN_ERROR;          //2 return statement here
      }

---

Certainly. Each catch block offers a distinct execution path.

Assuming there is nothing else going on with the code that you aren't showing, coming those catch blocks, you'll need to deallocate before each return statement. You will not be deallocating twice. You'd still be deallocating just once. Once for every execution path.

I'd suggest you get familiar with RAII. It will save you trouble especially with these kinds of problems.

Thanks Mario F,

Your suggesion really helps me..

Thanks a lot..

Subhashish