missing type specifier - int assumed??

the error is in push declaration beside closing bracket...

Code:

---

#include <list>
#include <iostream>
using namespace std;

template<class T>
class Stack
{
 public:
  Stack(void);      // default constructor
  void push(const T& item);  // add item to the Stack
  private:
  list<T> stackList;

};
template<class T>
Stack<T>::Stack(void)
{

}

template<class T>
Stack<T>::push(const T& item)
{
        stackList.insert(size(),item);
}

int main()
{
        Stack<int> object;

        for (int i = 0; i < 10; i++)
        {
                object.push(i);
        }
               

        return 0;

}

---

list::insert takes an iterator as the parameter indicating the place to insert, not an index.

insert - C++ Reference

you could use something like "stackList.insert(stackList.end(), item)" instead

yes kya i agree. ok i insert at beginning of stack now with this code but how do i get my print function to work? i get a syntax error on the line that i pass ostream& to print function...

Code:

---

#include <list>
#include <ostream>
#include <iostream>
using namespace std;

template<class T>
class Stack
{
public:
Stack(void); // default constructor
void push(const T& item); // add item to the Stack
void printStack(ostream &out); // prints the values in stack to stream out
private:
list<T> stackList;

};
template<class T>
Stack<T>::Stack(void)
{

}

template<class T>
void Stack<T>::push(const T& item)
{
stackList.insert(stackList.begin(),item);
}

template<class T>
void Stack<T>::printStack(ostream &out)
{
list<int>::iterator iter;
for (iter = stackList.begin(); iter < stackList.end(); iter++)
out << *iter;
}

int main()
{
Stack<int> object;

for (int i = 0; i < 10; i++)
{
object.push(i);
}

object.printStack(ostream&);


return 0;

}

---

It usually helps to post the error messages you're getting. ;)

Anyway, the problem is that printStack expects an actual object (eg: cout, cerr, etc). Another problem is that inside printStack you're comparing list iterators with <, but they aren't guaranteed to support that, so use != instead. Also, when using nested types within templates you should make it a habit to prepend the type with 'typename', eg:

Code:

---

typename list<int>::iterator iter;

---

Besides all that, learn how to indent your code - it makes it much more readable.

thanks for all the help sebasiani ive got it working now.

Quote:

---

Originally Posted by Sebastiani

Also, when using nested types within templates you should make it a habit to prepend the type with 'typename'

---

I disagree, but the code that you modified by way of example shows that there is another problem: stackList is of type std::list<T>, but iter is of type std::list<int>::iterator, which happens to work because the test is done with a Stack<int>. Rather, iter should be of type typename std::list<T>::iterator, and now the disambiguation with typename is appropriate.

Quote:

---

Originally Posted by laserlight

I disagree, but the code that you modified by way of example shows that there is another problem: stackList is of type std::list<T>, but iter is of type std::list<int>::iterator, which happens to work because the test is done with a Stack<int>. Rather, iter should be of type typename std::list<T>::iterator, and now the disambiguation with typename is appropriate.

---

Ah, yes, I overlooked the list<int> declaration, and I literally cut and pasted my example from the OP's submission. Lazy and distracted - great combination. :p