Access violation in std::map

I am getting an access violation when tring to access elements in a std::map. The violation occurs on the red line below.

Code:

---

typedef std::map<wxString, CAccount> mapAccountList;
class CAccountManager : public wxFrame
{
    public:
    CAccountManager() { Init(); }
    ~CAccountManager() {  }
    bool SaveAccount(CAccount &Account);
    bool SaveAccountsToDisk();
    bool LoadAccountsFromDisk();
    int GetNumberOfAccounts() { return m_AccountList.size(); }
    const mapAccountList& GetAccountList() const { return m_AccountList; }
 
    private:
    void Init();
    mapAccountList  m_AccountList;
};
 
bool CAccountManager::SaveAccountsToDisk()
{
    // save all accounts to disk
    if (m_AccountList.empty() )
        return false;
 
    wxFile oFile(ACCOUNT_LIST_FILENAME, wxFile::write);
    if (!oFile.IsOpened() )
    {
        SHOWERROR(wxT("Cannot open output file!") );
        return false;
    }
 
    mapAccountList::iterator iter;
    for (iter = m_AccountList.begin(); iter != m_AccountList.end(); ++iter)
    {
        SAccountInfo AI = iter->second.GetAccountInfo();

        if (!oFile.Write(AI.AccountName) )
        {
            SHOWERROR(wxT("Could not write to output file!") );
            oFile.Close();
            return false;
        }
    }
 
    oFile.Close();
    return true;
}

---

I've been beating my brain for an hour now and still can't figure it out. What am I missing here?!?

>> for (iter = m_AccountList.begin(); iter != m_AccountList.end(); ++iter)

There's nothing wrong with that line of code - the problem is most likely in the "do some stuff here" part.

Here is the "do some stuff" part (added to OP if that makes it easier..)

Code:

---

    {
        SAccountInfo AI = iter->second.GetAccountInfo();

        if (!oFile.Write(AI.AccountName) )
        {
            SHOWERROR(wxT("Could not write to output file!") );
            oFile.Close();
            return false;
        }
    }

---

I hate debugging.... That is the line that the dubbuger is reporting the access violation on. Not sure what it is or how to narrow it down any further than that.....?

Are you sure the instance of CAccountManager being used is valid at the time of the access violation?

First comment out this line:

>> SAccountInfo AI = iter->second.GetAccountInfo();

If it runs ok, then change the line to this:

Code:

---

CAccount ca = iter->second;

---

If it fails, then look into the CAccount copy constructor, otherwise:

Code:

---

CAccount ca = iter->second;
ca.GetAccountInfo();

---

If that fails, look into CAccount::GetAccountInfo, otherwise:

Code:

---

CAccount ca = iter->second;
SAccountInfo AI = ca.GetAccountInfo();

---

If it fails there, look into the SAccountInfo copy constructor.

That should narrow it down, at least.

I would say the map does not exist. Therefore I would also conclude, without looking at more of your code, that CAccountManager has gone out of scope somehow.

I'm begining to think that Bubba is right. The above code is being called (and the error is occuring) when the program exits. I think the problem is due to the way I am exiting. I am calling the function from inside App::OnExit and I think I should be calling it from inside a wxCloseEvent handler. Not sure if this is right or not but I am going to re write some code and find out for sure.