New to C What Is wrong with this...

Take a look at the code below, when I enter the password "test" I get the message incorrect password.

Why is this. Also is there a way to define passwords via a text file.

And put a line break between printed messages.

And Auto display both lines? Without user input?

Code:

---

#include <iostream>

using namespace std;

int main()
{
char string[25];

    cout<<"Welcome to the UK Memory.com inventory system";
    cin.get();
    cout<<"Enter Your Password then press enter to continue!";
    cin>> string;
    cin.get();

    if (string == "test")
        cout<<"Welcome Karl";
    else {cout<<"Incorrect Password! Try Again";}

}

---

You cannot use "==" to compare two C style strings. You need to use strcmp(). Since you appear to be using C++ instead of C, it would be better if you used std::string instead of C style strings in the first place. If you use std::string, then you can use std::getline(std::cin, my_string) to get user input.

Quote:

---

Originally Posted by headshot119

Take a look at the code below, when I enter the password "test" I get the message incorrect password.

Why is this.

---

Because you cannot compare null terminated strings with ==. You should use std::strcmp for this, from the <cstring> header.

A better approach would be to #include <string> and use a std::string object. This also means that have to either get rid of that using directive, or rename your string.

Quote:

---

Originally Posted by headshot119

Also is there a way to define passwords via a text file.

And put a line break between printed messages.

And Auto display both lines? Without user input?

---

Yes. Yes. Yes. Yes. Take things one step at a time.

Sorry I'm new to C++, I just followed some of the C++ tutorials on the main page to cobble this together, and what you said went way over my head.

Here is a short example on how to use std::string:

Code:

---

#include <iostream>
#include <string>

int main()
{
    std::string s;
    std::cin >> s;
    if(s == "test")
        std::cout << "Welcome Karl\n";
}

---

Note that you can use "==" when comparing C++ strings (which you cannot do with C style strings).

Figured out the string bit thanks bithub. Just need answers to how to do the other things?

Quote:

---

Originally Posted by headshot119

Figured out the string bit thanks bithub. Just need answers to how to do the other things?

---

What things (specifically)?

Also is there a way to define passwords via a text file.

And put a line break between printed messages.

And Auto display both lines? Without user input?

EDIT

How can I use a loop so that if an incorrect password is given it asks for it again? Think I'd use a do while loop here, I maybe wrong.

Quote:

---

Also is there a way to define passwords via a text file.

---

Yes. You need to read up on how to do file I/O with C++.

Quote:

---

And put a line break between printed messages.

---

Yes. The '\n' character is used to print a line break.

Quote:

---

And Auto display both lines? Without user input?

---

I'm not sure I understand. The only reason your original program requires user input is that you asked for it. See the cin.get() statements?

You misunderstood me, I wanted it to display two lines of text, without the user having to press enter in between.

EDIT

Doesn't matter fixed once I thought about it logically.

Code:

---

#include <iostream>
#include <string>

using namespace std;

int main()
{

    cout<<"Welcome to the UK Memory.com inventory system \n Enter Your Password then press enter to continue!";
    std::string password;
    std::cin >> password;

    while (password != "test")
        std::cout<<"Incorrect Password";

    if (password == "test")
        std::cout<<"Welcome User";
}

---

How do I stop the infinite loop when you execute this code?

Quote:

---

How do I stop the infinite loop when you execute this code?

---

That depends. You need to start thinking like a programmer. What are your intentions with that loop? Did you mean to do this?

Code:

---

while (password != "test")
{
        std::cout<<"Incorrect Password";
        std::cin >> password;
}

---

Your right I do need to think like a programmer, when I sit back and thing logically after seeing your code it makes much more sense.

Just read up on files I/O. I understand how to call them or create them, but not how to use the bit inside it.

EDIT

How do you neaten the output of the code, at the moment when you enter a wrong password asks you to enter it again, but when you type it appears right next to the printed message, rather than on a new line.

EDIT 2.

Once again I followed your advice, looked at something else for a bit, looked at the code and realized that adding a simple "\n" solved my problem.

Quote:

---

Originally Posted by headshot119

EDIT

How do you neaten the output of the code, at the moment when you enter a wrong password asks you to enter it again, but when you type it appears right next to the printed message, rather than on a new line.

---

Print a new line?

I realized that, read my second edit in that post.

Code:

---

#include <iostream>
#include <string>

using namespace std;

int main()
{
//Main Strings
std::string Password;
std::string AdministratorPassword;

//Main Menu
std::string MainMenu;

//Edit Menu
std::string EditMenu;
    std::string AddItem;
    std::string EditItem;

    cout<<"Welcome to the UK Memory.com inventory system \n Enter Your Password then press enter to continue! \n";
    std::cin >> Password;

while (Password != "test")
{
        std::cout<<"Incorrect Password \n Please Re-enter your password \n";
        std::cin >> Password;
}

//I need to add multiple password support, and user configurable passwords
    if (Password == "test")
        std::cout<<"Welcome User \n What would you like to do now? \n 1> Lookup item. \n 2> Packing mode. \n 3> Edit mode. \n \n \n Enter your selection. \n " ;
//Menu Selection Start Here.
        std::cin >> MainMenu;

    if (MainMenu == "1")
        std::cout<<"Lookup Mode selected \n Please scan the item's barcode and press enter, or type other for more options." ;

    if (MainMenu == "2")
        std::cout<<"Packing Mode selected \n Scan the order barcode to begin." ;

    if (MainMenu == "3")
        std::cout<<"Edit Mode selected \n Please enter administrative password to begin. \n" ;

        std::cin >> AdministratorPassword;

                while (AdministratorPassword != "admin")
{
                        std::cout<<"Incorrect Password \n Please Re-enter your password \n";
                        std::cin >> AdministratorPassword;
}
                if (AdministratorPassword == "admin")
                        std::cout<<"Edit Mode confrimed \n Please select an option. \n 1> Add item \n 2> Edit item \n 3> Delete iten. \n 4> Password configuration \n" ;

                            std::cin >> EditMenu;

                            if (EditMenu == "1")
                                std::cout<<"Add item mode. \n Please enter the item's details using the following syntax \n Item Number ; Item Barocde ; Item Name ; Stocked quantity \n" ;

                                    std::cin >> AddItem;

                                    if (AddItem != "*******;*******;********;********" )
                                        std::cout<<"Syntax incorrect. The correct syntax for this operation is...\n Item Number ; Item Barocde ; Item Name ; Stocked quantity";

                            if (EditMenu == "2")
                                std::cout<<"Edit item mode." ;

                            if (EditMenu == "3")
                                std::cout<<"Delete item mode." ;

                            if (EditMenu == "4")
                                std::cout<<"Password configuration mode. \n Please re-enter administrative password \n" ;

                                        std::cin >> AdministratorPassword;

                                    while (AdministratorPassword != "admin")
{
                                        std::cout<<"Incorrect Password \n Please Re-enter your password \n";
                                        std::cin >> AdministratorPassword;
}
                                    if (AdministratorPassword == "admin")
                                        std::cout<<"Password configuration mode confirmed." ;
}
//Edit mode needs another menu, giving access to various options including, adding / editing items, password editing ect.

---

When I go to edit mode, then try to access option 2 3 or 4, it doesn't do anything which I suspect is to do with line 59 interfering with the selection choice. How Do I fix this?