How to open a text file in a specific directory

I want to create a directory which is taken from the user(like test123) and than open a txt file in it and write some thing on that text. Here is my code. Please help me to solve this problem!!!

[tag]

Code:

---


#include <iostream>
#include <windows.h>
#include <string>
#include <stdio.h>
#include <fstream>
using namespace std;

int main(int argc, char * argv[])
{
string str;
LPSECURITY_ATTRIBUTES attr;
attr = NULL;
cout << "Type a Folder Name To Create.\n";
cout << "Folder=";
cin >> str;
CreateDirectory(str.c_str(), attr);
cout << "\nFolder Created!\n";


ofstream outfile;
outfile.open("c:\\str.c_str()\document1.txt", ios::out);
outfile<<"Hello!!!!....";
outfile.close();
return 0;
getchar();
getchar();
}

---

[/tag]

The call to str.c_str() is within the string "c:\\str.c_str()\document1.txt" will be treated as a string.

You need to create the string:

"c:\\" + str.c_str() + "\\document1.txt"

And also for the create directory, otherwise it would be created locally:

"c:\\" + str.c_str()

Quote:

---

Originally Posted by Scarlet7

The call to str.c_str() is within the string "c:\\str.c_str()\document1.txt" will be treated as a string.

You need to create the string:

"c:\\" + str.c_str() + "\\document1.txt"

And also for the create directory, otherwise it would be created locally:

"c:\\" + str.c_str()

---

It gives error in + ; and say invalid pointer addition.

Quote:

---

It gives error in + ; and say invalid pointer addition.

---

Yes, that is because c_str() converts the string to a char pointer.
Tty this -

Code:

---

char cstr[64] = "c:\\";
strcat(cstr,str.c_str());
strcat(cstr, "\\document1.txt");

...

outfile.open(cstr, ios::out);

---

Quote:

---

Originally Posted by Spidey

Yes, that is because c_str() converts the string to a char pointer.
Tty this -

Code:

---

char cstr[64] = "c:\\";
strcat(cstr,str.c_str());
strcat(cstr, "\\document1.txt");

...

outfile.open(cstr, ios::out);

---

---

Thank you Spidey, it works.

It might have worked, but it wasn't a good C++ answer.

> CreateDirectory(str.c_str(), attr);
Like this, you should have built your string as a C++ string, then at the last possible moment used the c_str() method to get the result to pass to the function.

Running back to C-style char arrays isn't good.

Say

Code:

---

string filename = "C:\\";
filename += str;
filename += "\\document1.txt";
outfile.open(filename.c_str(), ios::out);

---

BTW, if you want to make your code a little easier to read (and maybe more portable with relative paths) then use / instead of \\ for your path separators.
The Windows API will always accept / or \\ but UNIX will only accept / for path separators. So just use the thing they both have in common which is /.

Quote:

---

Originally Posted by Salem

It might have worked, but it wasn't a good C++ answer.

> CreateDirectory(str.c_str(), attr);
Like this, you should have built your string as a C++ string, then at the last possible moment used the c_str() method to get the result to pass to the function.

Running back to C-style char arrays isn't good.

Say

Code:

---

string filename = "C:\\";
filename += str;
filename += "\\document1.txt";
outfile.open(filename.c_str(), ios::out);

---

---

Yup, that would be a much better way to do it.