Writing encrypted value to file.

Well, I'm having a little problem writing an encrypted value to a file.

To be a little more specific, I used an XOR like method to encrypt a string, and tried writing the value to a file. The problem is, it's only writing the first character in the string, or nothing at all.

Here's a code snippet:

Code:

---

string4 = "Text: "+string1+"\nText: "+string2+"\nText: "+string3;
                                for ( unsigned int i = 0; i < string4.length(); i++ ) {
                                        string4[i] = string4[i]^key[i];
                                        string4 = string4[i];
                                }
                                ofstream file;
                                path_source = "C:\\Users\\%USER%\\Documents\\dir\\";
                                path = path_source+string1+path_ext;
                                file.open (path.c_str());
                                file << string4;

---

Does anyone see any problems, or know why this may be occuring?

You need to open the file in binary mode.

Quote:

---

Originally Posted by hk_mp5kpdw

You need to open the file in binary mode.

---

Thanks, I knew it had something to do with how the file was opened. :)

Okay, well, I tried adding ios::binary, and nothing is still written to the file.

Do I need to open and write to the file using a different method, now that I'm using binary mode?

Quote:

---

Originally Posted by mkthnx001

Here's a code snippet:

Code:

---

string4 = "Text: "+string1+"\nText: "+string2+"\nText: "+string3;
                                for ( unsigned int i = 0; i < string4.length(); i++ ) {
                                        string4[i] = string4[i]^key[i];
                                        string4 = string4[i];
                                }
                                ofstream file;
                                path_source = "C:\\Users\\%USER%\\Documents\\dir\\";
                                path = path_source+string1+path_ext;
                                file.open (path.c_str());
                                file << string4;

---

Does anyone see any problems, or know why this may be occuring?

---

That red part there, it doesn't seem right, you're assigning a char to a string object? are you sure you need it there? As for how you're supposed to write binary data to the file, try looking into this:

write - C++ Reference

Quote:

---

Originally Posted by JacobN

That red part there, it doesn't seem right, you're assigning a char to a string object? are you sure you need it there? As for how you're supposed to write binary data to the file, try looking into this:

write - C++ Reference

---

Well, I replaced file.open (path.c_str()); with file.open (path.c_str(),ios::binary);, and it still doesn't seem to be working.

Is there something else I must do?

The standard library won't expand %USER%, that's a shell thing.

char *user = getenv("USER");
check it for NULL, then substitute it yourself.

Quote:

---

Originally Posted by Salem

The standard library won't expand %USER%, that's a shell thing.

char *user = getenv("USER");
check it for NULL, then substitute it yourself.

---

No, that's not the problem, I just put the %USER% in the code snippet, to replace the actual value that was in that place.

Fantastic, complete waste my of time on a non-existent problem :(

Anywho, if someone would be kind enough to explain the binary opening mode to me a bit more in detail, I'd really appreciate it.

Quote:

---

Originally Posted by mkthnx001

Anywho, if someone would be kind enough to explain the binary opening mode to me a bit more in detail, I'd really appreciate it.

---

No offense, but did you check out the link I gave you? There's a full example showing how to use ofstream::write to write binary data to a file... Or at least that's what I thought.

Quote:

---

Originally Posted by JacobN

No offense, but did you check out the link I gave you? There's a full example showing how to use ofstream::write to write binary data to a file... Or at least that's what I thought.

---

Yes, but I'm afraid I don't quite understand it. Isn't the example they show for copying one file's contents to another?

It is, but notice how they do it? They read the data from one file into a char array, just like you have in your string object( the c_str() method returns one ), and then they write this char array to the other file using ofstream::write. To get the number of chars you're going to write to the file, you could use the string::length() method to get this number.

Is there any other method of doing this?