Splitting source into multiple files(Linux & make)

I consider myself to be a pretty able programmer, for a hobbyist, but I've run into some problems that I cannot seem to solve.
I'm taking my first shot at any real linux programming, and I am writing an ircbot for a channel I frequent. The linuxy part of it will be its eventual ability to use modules to call user-defined functions on certain events(E.g. receives PRIVMSG and it checks the PRIVMSG event chain. If someone has registered, it'll call the function in that module.. ).. I digress.

The problem I'm having is that, after the initial stages where it was all bunched up in one source file(Should have started out the other way), I decided to divide it all up into multiple source files. This has never really been a problem for me - I've done this plenty of times on Visual Studio, but the difference is that I'm not using an IDE that does the work for me, and I'm using make.

I'll describe the files:

ircbot.c: Contains the main function, which call various functions from botfunctions.c
botfunctions.c: Contains definitions for functions.
prototypes.h: Prototypes for functions in botfunctions.c
botstructs.h: Contains definitions for various structures used to structure input and so on.

What I started by doing is what I've done in most of my other projects. I use a main "includes.h" file which contains all the standard header files(stdio.h, network header files and all that), and includes the other header files, like prototypes, botstructs and so on. I then include this file in the other source files.

Thing is, if I use make, I can get everything to compile, since it splits everything into object files. ircbot.c compiles to ircbot.o fine, and botfunctions.c to botfunctions.o too, and they are compiled into the main executable fine. If I run this executable, however, I get the output I'm supposed to see a billion times over. In fact, it is too much for my terminal to handle and I have to manually kill it. The bot functions properly past that - it connects and does what it's supposed to do, only once, not a billion times like when it displays output.
Looking at the disassembly of the executable, it looks like main is a series of conditional jumps into itself.

I know there's something wrong here, since if I just try to compile with gcc, it doesn't like it and gives me undefined references to all the functions, in spite of the prototypes.h file being included.

Can someone give me some tips on this? I have read several makefile tutorials and "split your project into many files"-tutorials, but none of the mention strange cyclic calling errors(Cyclic dependencies, but not strange loops).

I would really appreciate it if someone could give me some hints on what I'm doing wrong, and tips for the future. Is the "one main include file with include guard"-approach no good? If so, why not?

Much appreciated,
IceDane

What does your makefile look like (roughly, if it's too big to post here)?

You should have something like

Code:

---

bot : all your o files here
        gcc -o bot all your o files here again

---

(where naturally you'd use $variables for most of that). On the other hand, I'm not sure what you're doing differently that you can't compile the thing by hand....

Technically for Windows, but uses gmake, which is the same make-program as Linux uses, here is the makefile for Minibasic. It's not a VERY complex, but it's not simple either.
matsp / minibasic / source — bitbucket.org

--
Mats

Quote:

---

Originally Posted by IceDane

Thing is, if I use make, I can get everything to compile, since it splits everything into object files. ircbot.c compiles to ircbot.o fine, and botfunctions.c to botfunctions.o too, and they are compiled into the main executable fine. If I run this executable, however, I get the output I'm supposed to see a billion times over. In fact, it is too much for my terminal to handle and I have to manually kill it. The bot functions properly past that - it connects and does what it's supposed to do, only once, not a billion times like when it displays output.
Looking at the disassembly of the executable, it looks like main is a series of conditional jumps into itself.

---

Perhaps this is just a major bug with your program and is unrelated to your makefile.

Quote:

---

Originally Posted by IceDane

I know there's something wrong here, since if I just try to compile with gcc, it doesn't like it and gives me undefined references to all the functions, in spite of the prototypes.h file being included.

---

Whether you automate the process or run the commands manually, you still need to link the object files together to form the executable program. That a common header is included everywhere is orthogonal to this.

Quote:

---

Originally Posted by IceDane

Is the "one main include file with include guard"-approach no good? If so, why not?

---

I presume that each header file has its own include guard as well?

One problem with having a common "mother of all headers" that includes all the other headers is that a change to any header will then require much more re-compilation than is necessary. If each source file and header only included those headers that are necessary (or none at all, if forward declarations will suffice), then a change to one header would only require re-compilation of those source files that include it.

However, the use of pre-compiled headers should be able to alleviate this problem, and a common header can simplify things for a user of your library, should you be providing one.

A related problem is that it becomes harder to separate parts of what you have written for reuse in another program since each source file would depend on all the headers.

Quote:

---

Originally Posted by tabstop

What does your makefile look like (roughly, if it's too big to post here)?

You should have something like

Code:

---

bot : all your o files here
        gcc -o bot all your o files here again

---

(where naturally you'd use $variables for most of that). On the other hand, I'm not sure what you're doing differently that you can't compile the thing by hand....

---

Thanks for the reply.

My makefile is as follows:

Code:

---

ircbot:  ircbot.o botfunctions.o
        gcc -Wall -ggdb3 ircbot.o botfunctions.o -o ircbot

ircbot.o: ircbot.c
        gcc -Wall ircbot.c -c
       
botfunctions.o: botfunctions.c
        gcc -Wall botfunctions.c -c

clean:
        rm -rf *.o

---

That does compile(if I used the main include file approach), too, like I said, but that gives me the strange errors I mentioned.

Do I have to use extern or some such? I have never ever had to use that keyword(I haven't been using global variables much) and everything has worked fine, so I know this can be done without using extern.

EDIT: laserlight: The program compiled and ran as per expectations before I split it up.

Sorry - this seems to be a bug with my program anyway. The input is printed way too often for some bizarre reason, but it works after that. I simply thought this was an effect of splitting it up(Even in spite of that conclusion going against my instinct), but now that I've put everything as it was(in one file), I still get the same strange error.

Thanks for trying to help me solve an error that wasn't there anyway, though, heh.

Quote:

---

Originally Posted by IceDane

but now that I've put everything as it was(in one file), I still get the same strange error.

Thanks for trying to help me solve an error that wasn't there anyway, though, heh.

---

Haha, but good to know we had the same instincts about the problem and it turned out to be correct :D

What you can do now is to take a diff between your newly re-combined source and the one that worked. Chances are, the bug was introduced in the changed portions (but it could also have been latent in the unchanged portions, then "triggered" when you made other changes).