Get stringstream with separator!!!

I've read some example for the get Int or char for stringstream with ' ' (space) separator.
for example:

Code:

---

string line = {1 2 3 4 5 6};

---

the library will auto get each number as an Int and put into vector

Code:

---

vector<int> numbers;

---

The question is "How i get (read) from file and get words
- space separator
- "<" or ">" separator (the program will ignore this and assume it as a space)
- with "-" (hyphen) a numbers of word will become one word (Today-is-a-nice-day) means no separator
- With "." (end period) - here is a difficult part
- first: 0.2 0.2a is read by 0.2 and 0.2a
- second: .2 a.2a .2 (2 spaces) is read by 2 2a and 2 (it will check the char before the "." to be blank.

Could anyone give me an idea of how to read from a file and get char as description.

Thanks, regard

I'm confused on the first part of your question. However, most of the things you listed below can be solved with getline, which has an option for delimiter

Code:

---

istream& getline (char* s, streamsize n, char delim );

---

A good example may be

Code:

---

char name[256];
... // file setup
file.getline(name, 256, '>');

---

I hope this helps, but it is hard for me to understand the question.

Thx for reply. I will explain again.
this is my text file.

Code:

---

Today!is-not-a-good-day, the<problem<is<this "<"
More.about.decimal 0.2abc 0.2 .2abc .2 abc.2abc abc.2 abc0.20  .2 . 2

---

the requirement of the program is to read the file and then count them

Code:

---

COUNT | WORD
------+------
  1  | 0.2
  1  | 0.2abc
  3  | 2
  1  | 20
  2  | 2abc
  1  | More
  1  | Today
  2  | abc
  1  | abc0.20
  1  | about
  1  | decimal
  1  | is
  1  | is-not-a-good-day
  1  | problem
  1  | the
  1  | this

Number of unique words in test.txt is 16
Total number of words in test.txt is  20

---

as you can see as the result. it read each word then count them.
I wonder should i use string or char to get a word.
This will involve bintree (which i will read more about). But first i should have an idea of how to make it.
Thx and regard

Quote:

---

Originally Posted by cubimongoloid

it read each word then count them.

---

What is the definition of word in this context?

is it a vector of char???
because i confuse to read by line or by char?

Quote:

---

Originally Posted by cubimongoloid

is it a vector of char?

---

No, I am not talking about how you plan to store the words. I am asking about what are the exact rules by which you determine that part of the text forms a word.

As you can read the post above. there is a file with mixing words and chars. The program will read the file, separate them follow the rules (which is show as result, so hard to explain)

they will be separate by '.'(full stop), space, '<' '>' greater or smaller.
The '.' has to be distinguished by decimal (0.2 or 3.3 with a.2 or .2 which will become a and 2 or 2)

hmm... okay, I missed the part where you expressed the concept in terms of separators rather than the actual definition of a word.

Either way, here's an idea: define a Word class. Overload operator>> for std::istream for this Word class such that it reads from the input stream into a word. As a prototype implementation, try making it able to read in words separated by spaces, hyphens, '<' and '>'.

You would also want to overload operator<< for std::ostream to make it easy for you to print the word. Part of your requirements involve implementing a (balanced) binary tree, but for now use a std::map<Word, std::size_t>. Overload operator< for your Word class to make it easy to use it as the key type for std::map (and it will come in handy again when you implement your own binary tree).

thx, im reading and thinking about them.

To give you a better idea of how this Word class might actually be used, here is an example using std::string:

Code:

---

#include <map>
#include <string>
#include <cstddef>
#include <iostream>

int main()
{
    typedef std::map<std::string, std::size_t> WordCountMap;
    WordCountMap words;

    // Read in the words into the map and update the counts.
    std::string word;
    while (std::cin >> word)
    {
        ++words[word];
    }

    // Print the words and their corresponding counts.
    for (WordCountMap::iterator i = words.begin(), end = words.end();
        i != end; ++i)
    {
        std::cout << i->second << ": " << i->first << std::endl;
    }
}

---

With an input of "how much wood would a wood chuck chuck if a wood chuck would chuck wood?" (note that you have to simulate EOF), the expected output would be:

Code:

---

2: a
4: chuck
1: how
1: if
1: much
3: wood
1: wood?
2: would

---

That was quick. I'm just a beginner so to understand it i hv to take time. great work.

The typedef map<> is in the library or user define. And i havent study map so, i barely understand it. In this case i m forced to use bintree.

Im trying with the ostream and istream now. This is my attempt

Code:

---

struct words
{
  string s;
 
  words() : s(" ") {}
  words(const string st) : s(st) {}
 
  friend ostream &operator<< (ostream &stream, words word);
  friend istream &operator>> (istream &stream, words &word);
};

ostream &operator>> (ostream &stream, words word)
{
  stream << word.s;
  return stream;
}

istream &operator<< (istream &stream, words &word)
{
  stream >> word.s;
  return stream;
}

---

I read by file so i use getline for reading the string and put it into istream

Code:

---

while (fin.good())
      {
        getline(fin, temp);
        words w(temp);
        cout << w;
      }

---

now i can work ... just print out text file

Quote:

---

Originally Posted by cubimongoloid

The typedef map<> is in the library or user define. And i havent study map so, i barely understand it.

---

std::map is part of the C++ standard library. You can get an overview of its interface from cppreference.com's entries on std::map.

Quote:

---

Originally Posted by cubimongoloid

In this case i m forced to use bintree.

---

std::map is typically implemented with a balanced binary tree. My point here is to use std::map first, then replace it with your own tree implementation later. (Are you sure a bintree must be used? It sounds like it is far more complex than is needed for this problem.)

Quote:

---

Originally Posted by cubimongoloid

Im trying with the ostream and istream now. This is my attempt

---

Looks like you mixed them up. Your declarations should be:

Code:

---

friend ostream& operator<< (ostream &stream, const words& word);
friend istream& operator>> (istream &stream, words& word);

---

I fixed them already, now they can read from file, normal.

This is base on bintree work with bintree.h is provided by lecturer. He's so tricky. And i'm not sure that can we used another method as map. And there will be only 165 or less code line in this assignment. I don't think it gonna fit.

Btw, the separator will be define in istream and ostream or getline(fin, temp, '.'). I'm working on it now.

Quote:

---

Originally Posted by cubimongoloid

This is base on bintree work with bintree.h is provided by lecturer.

---

Just to clarify: when you say bintree, do you mean the bintree structure as defined by the Dictionary of Algorithms and Data Structures entry that I linked to, or do you merely mean a binary tree, e.g., a simple binary search tree?

Furthermore, what is the interface of this bintree? Are you supposed to use your lecturer's implementation, or are you supposed to implement it yourself?

Quote:

---

Originally Posted by cubimongoloid

And i'm not sure that can we used another method as map. And there will be only 165 or less code line in this assignment. I don't think it gonna fit.

---

My example was only 24 lines. Adding in the definition of the Word class, plus implementation of operator<< and operator< extended it to a total of 50 lines, including an implementation of operator>> that has no net effect. This leaves you with well over 100 lines to fully implement operator>>, with over a dozen more lines to touch up on your output and cater for a change to use bintree.h instead of <map>. Plus, my indent style consumes a line for each opening brace; changing to use a different indent style can save on lines of code.

I understand what u said. The thing here is the lecturer provide bintree.h and binnode.h (his own work so you have to implement it in to your assignment. Because when submit, i can online submit 1 file then it will be combined with two those file to make the app work.
bintree.h

Code:

---

#ifndef BINTREE_H_
#define BINTREE_H_

#include <stdexcept>
#include <math.h>

#include "binnode.h"

/********************************************************\
  template class for a binary tree
\********************************************************/


template <typename dataType> class bintree
{
  private:
      binNode<dataType> *root;
      int numItems;

  public:
      /*******************************************************\
        constructors & destructors
      \*******************************************************/

      // constructor
      bintree() : root(NULL), numItems(0) {}

      // destructor
      ~bintree() {
        if (root != NULL) delete root;
      }

      /*******************************************************\
        misc functions
      \*******************************************************/

      bool empty() const {
        return (numItems == 0);
      }

      int size() const {
        return numItems;
      }

      int numNodes() const {
        if (root == NULL) {
            return 0;
        } else {
            return root->numNodes();
        }
      }

      int maxTreeDepth() const {
        if (root == NULL) {
            return 0;
        } else {
            return root->maxTreeDepth();
        }
      }

      int numLeafNodes() const {
        if (root == NULL) {
            return 0;
        } else {
            return root->numLeafNodes();
        }
      }

      double balance() const {
        // Returns a measure of how balanced a tree is.
        // A value of 1 is a prefectly balanced tree.
        // The closer to 0 the value is the more unbalanced
        // the tree.
        // A value < 0.5 indicates a tree that is seriously unbalanced

        // case of no nodes in tree
        if (numItems == 0) return 1.0;

        // calculate balance
        double log2numItems = log10(numItems + 1) / log10(2);
        return log2numItems / maxTreeDepth() * (numLeafNodes() * 2) / (numItems + 1);
      }

      void rebalance() {
        // Rebalance tree using the AVL algorithm
        // While this does not guarantee a perfectly balanced tree
        // it does make it mostly balanced by guranteeing that the diference
        // in depth between every right and left subtree is at most 1

        if (root != NULL) {
            while (root->rebalance(root));
        }
      }

      /*******************************************************\
        insertion and erasure functions
      \*******************************************************/

      void insert(const dataType& newData) {
        if (root == NULL) {
            root = new binNode<dataType>(newData);
        } else {
            root->insert(newData);
        }
        numItems++;
      }

      void erase(const dataType& delData) {

        if (root == NULL) {
            throw std::invalid_argument("data does not exist in tree to erase");
        }

        root->erase(&root, delData);

        numItems--;
      }

      dataType* find(const dataType &findData) const {
            // this function looks for findData in ther tree.
                // If it find the data it will return the address of the data in the tree
                // otherwise it will return NULL
        if (root == NULL) return NULL;
        else return root->find(findData);
      }

      /*******************************************************\
        print function for assignment.
                assumes dataType has print() function
      \*******************************************************/

          void print() const {
            if (root != NULL) root->print();
      }
};

#endif

---

This is also help us to understand the bintree and implement it into the assignment. which is i have to implement the bintree into my work. The app will read the file with multiple dilimiter in 1 file. As i have searching on the Internet, they said that we have to overload getline or checking each char to compare with dilimiter.

Your code is very short and simple, but the thing is i have to do as the specification so it need times for searching and doing it.

I m very appreciate you help.

Right, bintree is a class template for an AVL tree, which is a balanced binary tree. The basic concepts of its usage to solve your problem are the same as with std::map, hence you can start by using std::map.

Quote:

---

Originally Posted by cubimongoloid

The thing here is the lecturer provide bintree.h and binnode.h (his own work so you have to implement it in to your assignment. Because when submit, i can online submit 1 file then it will be combined with two those file to make the app work.

---

So, you are only supposed to submit the file that implements the main function that reads in words and prints the words and their corresponding counts, but you also have to implement, but not submit the code for, an AVL tree using the interface provided by your lecturer?

yes. Just that. That is the template of bintree in the lecture which we may or maynot need to understand (hhaha...:D) but we can still write the code.

This is the first subject about programming at uni but it turns out so hard for me. We had Java before but means nothing. last 2 assignment i did try best but still need some help.

Anyway, i think the basic concept for solving the problem is the same. This assignment we don't know his input file to test. So we have to make it ourselves to get an output.

The problems is the multi dilimiter in one file. i can be mixed up every where in the file.

Quote:

---

Originally Posted by cubimongoloid

The app will read the file with multiple dilimiter in 1 file. As i have searching on the Internet, they said that we have to overload getline or checking each char to compare with dilimiter.

---

As I have noted, I would prefer overloading operator>>. You could overload getline(), but using a Word class would make things easier.

So, once you have implemented the Word class and tested it with std::map, you can then adapt it to work with bintree. Your lecturer's bintree class template provides the interface of an AVL tree rather than a map, so you would need to manually associate a key (the Word object) with a value (the count). Then can be done with yet another class, but this time one that is much smaller since all it does is model a key/value pair.

Keep in mind: concentrate on parsing the input correctly first. You can implement the AVL tree later when you have confidence that your parsing is correct.

It seems to be stupid but how can i parsing delimiter inside operator>>

Code:

---

stream >> word.s;
 and
words w(temp);

---

the app will read the line then put temp into istream OR istream do the part put temp in to buffer then ostream will print.

Could i get a hint of how can i compare separator? is it as normal as if else...???

Quote:

---

Originally Posted by cubimongoloid

the app will read the line then put temp into istream OR istream do the part put temp in to buffer then ostream will print.

---

I suggest that you store a std::string as a member variable for the Word object. You will then store the word read into that std::string, and print that std::string to print the Word object.

Quote:

---

Originally Posted by cubimongoloid

Could i get a hint of how can i compare separator? is it as normal as if else...???

---

You could read character by character, ignoring separator characters (including periods) until you read a character that should be in a word, then keep reading until you reach a separator character (with special handling for periods). You may want to place that last separator character back into the input stream with the putback() member function of std::istream.

Should we define in Words class the string and double for the decimal number. Because it also will be read (u can have a look back to the result). i read the book, it said cin on istream will be continued and separated by white space.

Quote:

---

Originally Posted by cubimongoloid

Should we define in Words class the string and double for the decimal number.

---

No, work with words. Trying to turn the class into a numeric type would just complicate the issue.

Quote:

---

Originally Posted by cubimongoloid

i read the book, it said cin on istream will be continued and separated by white space.

---

Yes, but you have more than whitespace to think about.

i have try but still not know that to getline into istream. Most of the example is use cin for istream.
So should i call the cin instead of getline. Because they are at 2 separate function.

Code:

---

void loadFile(const string file)
{
  ifstream fin;
  fin.open(file.c_str());
  string temp;
 
  if (!fin)
  {
      cout << "\nERROR - Unable to access " << file;
      exit(0);
  }
  else
  {
      cout << "\nfilename : " << file << endl << endl;
      while (fin.good())
      {
        getline(fin, temp);
        words w(temp);
        cout << w;
      }
  }
}
and
istream &operator>> (istream &stream, words &word)
{
  stream >> word.s; //is this put stream into words class
  return stream;
}

---

After you have the line as a string, you should go through the string character by character

Code:

---

std::string new_word;
std::string::const_iterator it = temp.begin();
while(it != temp.end()) {
  if(*it == '>' || *it == '<' || *it == '.') {  // whatever else you are looking for
      // insert new_word into avl tree
      new_word.clear(); // Empty the string
  }
  else {
      new_word += *it;
  }
  it++;
}
// insert the last new_word into the avl tree, because got to the end.

---

That way you have now parsed all the words that you got with getline.

Thx alot. I will try it.

I defined a vector for a word. so when the *itr meet some special symbol, it will finish the vector for a word. For example: Today!. a vector for T o d a y, when *itr see symbol "!" it will terminate and form a Today word which will be added to the tree. But i cannot figure out how to do that.

Code:

---

vector<char> ch;
getline(fin, temp);
        string::const_iterator itr = temp.begin();
        while(itr != temp.end())
        {
            ch.push_back(*itr);
            if(*itr == '>' || *itr == '<' || *itr == '.' || *itr == ' ')
            {
              if (!new_word.empty())
              {
                  //word.insert(words(new_word));  //line not work for me. It was wrong with the template of avl tree
                  //word.insert(new_word(ch)); // instantiated from here
                  new_word.clear(); // Empty the string
                  i++;
              }
            }
            else
            {
              new_word += *itr;
            }
            itr++;
        }

---

The question is "as laserlight said, i can use istream and ostream. Is the way are different or ...???

What is word a vector of? std::strings? If so, then don't make ch a vector<char>, but a std::string instead. (You can do push_back on a string just like a vector.)

I did go to this far. I wanna implement istream and ostream to bintree but hvn't known yet.
This is the code by far i have recognized the duplicate word in the tree. I wanna the istream and ostream to put the count for duplicate word.
1 more trouble is few last word of the file didn't display on the screen and tree.

In some book and template. ostream related to bintree by defined
ostream &operator>> (ostream &os, bintree<words> word);
i did try but it cannot work.

Code:

---

words w(new_word); //for ostream i have to use this word class. It not related to bintree
                      //should i define bintree<words> s in class words instead of string s.
           
            if (isspace(*itr) || *itr == '>' || *itr == '<'  || *itr == '!' || *itr == ',')
            {
              if (word.find(new_word))
              {
                    i++;
                    new_word.clear();
              }
              else
              {
                  word.insert(words(new_word));
                  cout << w; //using ostream to display the output
                  new_word.clear(); // Empty the string
              }
            }
            else
            {
              new_word += *itr;
            }
            itr++;

---

and text file

Code:

---

Today!is-not-a-good-day, the<problem<is<this "<"
More.about.decimal 0.2abc 0.2 .2abc .2 abc.2abc abc.2 abc0.20  .2 . 2
This is the quote "I don't know this will work".
EOF

---

the display shown up till "will" then finish.

thx and regard

That's because after the loop there is something in new_word, but you didn't put it in, because the loop finished. After the while loop, you need to insert into the word vector and you'll have the last part.

I did add the bintree insert outsite the loop. The numNodes() increase but i cannot get the display because: words w(new_word) is inside the loop.

Btw, base on the code above the display go weird.

Today
is-not-a-good-day
(newline here free)
the
problem
is
this
"
"More.about.decimal
... // word continue here until
2This
quote
...
will

num Node is: 23

there are 2 things on the display "More and 2This. two line stick together while others work fine ??? and newline automatically add there ???

Please... :D

I have inserted and printed out the bintree (automatically sorted)
but there still one problem

Code:

---

while (fin.good())

      {

        getline(fin, temp);

        string::const_iterator itr = temp.begin();

        while(itr != temp.end())

        {

            if (isspace(*itr) || *itr == '>' || *itr == '<'  || *itr == '!' || *itr == ',')

            {

              if (word.find(new_word))

              {

                    i++;

                    new_word.clear();

              }

              else

              {

                  word.insert(words(new_word));

                  new_word.clear();

              }

            }

            else

            {

              new_word += *itr;

            }

            itr++;
        }

      }

      word.insert(words(new_word)); // this will insert the last word into bintree, but the problem is the last word is
                                            //the same with one of the word exist. The program is terminated.
      print(word);
  }

}

//print function which called toString above
void print(bintree<words> word)
{
  cout << "COUNT | WORD \n";
  cout << "------+------\n";
  word.print();
  cout << "\nNum Nodes is: " << word.numNodes() << endl;
}

---

Everytime i wanna insert into bintree i have to check it again whether the word is already exist or not.
I'm thinking of a bool function for finding an exsting word then apply to where i wanna insert.

is there any more convinient way to do this???
Thanks