Certain parameters wont work?

Alright, first post, lets hope this is in the right section. Anyway, I've got a function prototype here I'd like you guys to take a look at and tell me if it's just plain wrong. I'm using this as a quick way to format and create my windows for direct3d testing. Here's the prototype:

Code:

---

HWND windowCreator(LPCWSTR className, LPCWSTR windowTitle, HINSTANCE hInst, WNDPROC WndProc, DWORD style=WS_OVERLAPPEDWINDOW);

---

edit: Quick note, I've created with a return type as HWND so I can get the window handle back for later use with direct3d and some windows functions.

I see nothing obviously wrong other than the thread belongs in the Windows section.

You might want to say what the function is supposed to do, and how does it not work.

Alright, thanks, and noted.

Was hoping it was something simple enough to just catch, you know? But that's not the norm so I should have expected that. Anyway, the function itself is for me to easily create a window for some d3d testing/experimenting. The errors I'm getting are syntax like errors, but it's asking that I put extra parentheses in the parameter list, which makes no sense to me. One example: Missing ')' before identifier className

Here's the full code:

Code:

---

        HWND windowCreator(LPCWSTR className, LPCWSTR windowTitle, HINSTANCE hInst, WNDPROC WndProc, DWORD style=WS_OVERLAPPEDWINDOW)
        {
                wc.style                = CS_HREDRAW | CS_VREDRAW;
                wc.lpfnWndProc        = WndProc;
                wc.cbClsExtra        = 0;
                wc.cbWndExtra        = 0;
                wc.hInstance        = hInst;
                wc.hIcon                = ::LoadIcon(0, IDI_APPLICATION);
                wc.hCursor                = ::LoadCursor(0, IDC_ARROW);
                wc.hbrBackground= static_cast<HBRUSH>(::GetStockObject(WHITE_BRUSH));
                wc.lpszMenuName        = NULL;
                wc.lpszClassName= TEXT(className);

                if(!RegisterClass(&wc))
                {
                        MessageBox(0, TEXT("Failed to register windows class."), TEXT("Windows Error"), 0);
                        return 0;
                }



                hWnd = CreateWindow(
                        className,
                        windowTitle,
                        style,
                        CW_USEDEFAULT,
                        CW_USEDEFAULT,
                        windowWidth,
                        windowHeight,
                        0,
                        0,
                        hInst,
                        0);

                if( hWnd == 0 )
                {
                        MessageBox(0, TEXT("Create Window - Failed"), TEXT("Windows Error"), 0);
                        return 0;
                }
                else
                {
                        return hWnd;
                }
        }

---

You probably need to give us a COMPLETE, compilable example - there is nothing DIRECTLY wrong in the code you have posted, but there's tons of things that could be wrong AROUND your code - e.g not including the right include files, syntax errors before the function you posted, etc.

--
Mats

That's pretty much it, I've got it in a class with the variables you see there declared above as global for ease of use while I'm making it. The full .h file is:

Code:

---

#ifndef windowCreator
#define windowCreator
#include <windows.h>


class window
{
        //Global windows based declarations
        HWND hWnd;
        WNDCLASS wc;
        MSG msg;

       
        //Global class-needed declarations
        int windowWidth;
        int windowHeight;
        bool bWindowed;


        window()
        {
                //Class constructor with default values
                windowWidth = 640;
                windowHeight = 480;
                bWindowed = true;
                hWnd = 0;
        }

       

        HWND windowCreator(LPCWSTR className, LPCWSTR windowTitle, HINSTANCE hInst, WNDPROC WndProc, DWORD style=WS_OVERLAPPEDWINDOW)
        {
                wc.style                = CS_HREDRAW | CS_VREDRAW;
                wc.lpfnWndProc        = WndProc;
                wc.cbClsExtra        = 0;
                wc.cbWndExtra        = 0;
                wc.hInstance        = hInst;
                wc.hIcon                = ::LoadIcon(0, IDI_APPLICATION);
                wc.hCursor                = ::LoadCursor(0, IDC_ARROW);
                wc.hbrBackground= static_cast<HBRUSH>(::GetStockObject(WHITE_BRUSH));
                wc.lpszMenuName        = NULL;
                wc.lpszClassName= TEXT(className);

                if(!RegisterClass(&wc))
                {
                        MessageBox(0, TEXT("Failed to register windows class."), TEXT("Windows Error"), 0);
                        return 0;
                }



                hWnd = CreateWindow(
                        className,
                        windowTitle,
                        style,
                        CW_USEDEFAULT,
                        CW_USEDEFAULT,
                        windowWidth,
                        windowHeight,
                        0,
                        0,
                        hInst,
                        0);

                if( hWnd == 0 )
                {
                        MessageBox(0, Text("Create Window - Failed"), TEXT("Windows Error"), 0);
                        return 0;
                }
                else
                {
                        return hWnd;
                }
        }


};
#endif

---

If you either name your include guard or windowCreator function to different names, it will get a bit further - you are then using the TEXT macro incorrectly.

[The first problem is caused by windowCreator function name being removed by the preprocessor - so you get a bunch of function parameters immediately after HWND, which confuses the compiler a tad].

--
Mats

Code:

---

#pragma comment(lib, "user32.lib")
#pragma comment(lib, "gdi32.lib")
#include <windows.h>
#include <tchar.h>

LRESULT CALLBACK WndProc(HWND,UINT,WPARAM,LPARAM);

class window
{
        public:

        //Global windows based declarations
        HWND hWnd;
        WNDCLASS wc;
        MSG msg;
        //Global class-needed declarations
        int windowWidth;
        int windowHeight;
        bool bWindowed;

        window()
        {
                //Class constructor with default values
                windowWidth = 640;
                windowHeight = 480;
                bWindowed = true;
                hWnd = 0;
        }

        HWND windowCreator(LPCSTR className, LPCSTR windowTitle, HINSTANCE hInst, WNDPROC WndProc, DWORD style=WS_OVERLAPPEDWINDOW)
        {
                memset(&wc, 0, sizeof(WNDCLASS));

                wc.style        = CS_HREDRAW | CS_VREDRAW;
                wc.lpfnWndProc  = WndProc;
                wc.cbClsExtra  = 0;
                wc.cbWndExtra  = 0;
                wc.hInstance    = hInst;
                wc.hIcon        = ::LoadIcon(0, IDI_APPLICATION);
                wc.hCursor      = ::LoadCursor(0, IDC_ARROW);
                wc.hbrBackground= static_cast<HBRUSH>(::GetStockObject(WHITE_BRUSH));
                wc.lpszMenuName = NULL;
                wc.lpszClassName= TEXT(className);

                if(!RegisterClass(&wc))
                {
                        MessageBox(0, TEXT("Failed to register windows class."), TEXT("Windows Error"), 0);
                        return 0;
                }
                hWnd = CreateWindow(
                        className,
                        windowTitle,
                        style,
                        CW_USEDEFAULT,
                        CW_USEDEFAULT,
                        windowWidth,
                        windowHeight,
                        0,
                        0,
                        hInst,
                        0);

                if( hWnd == 0 )
                {
                        MessageBox(0, TEXT("Create Window - Failed"), TEXT("Windows Error"), 0);
                        return 0;
                }
                else
                {
                        return hWnd;
                }
        }
};

int WINAPI WinMain(HINSTANCE hInstance,HINSTANCE hPrevInstance,
                                        LPSTR lpCmdLine,int nCmdShow)
{
        MSG Msg;
        HWND hwnd;
        TCHAR chClassName[]=TEXT("Testing");
        window win1;

        hwnd = win1.windowCreator(chClassName, "Mywindow", hInstance, WndProc );
        if(hwnd==NULL)
        {
                MessageBox(0,"Window Creation Failed!","Error",MB_ICONSTOP|MB_OK);
                return 0;
        }
        ShowWindow(hwnd,nCmdShow);
        UpdateWindow(hwnd);
        while(GetMessage(&Msg,NULL,0,0))
        {
                TranslateMessage(&Msg);
                DispatchMessage(&Msg);
        }
        return Msg.wParam;
}
LRESULT CALLBACK WndProc(HWND hwnd,UINT msg,WPARAM wParam,LPARAM lParam)
{
        switch(msg)
        {
                case WM_CLOSE:
                        DestroyWindow(hwnd);
                        break;
                case WM_DESTROY:
                        PostQuitMessage (0);
                        break;
                default:
                        return DefWindowProc(hwnd,msg,wParam,lParam);
        }
        return 0;
}

---

Thanks guys, it was that I had a function with the same name as the #ifndef/#define statements. Appreciate it.