Can anyone take a crack at this for me?

I'm trying to do some homework involving custom libraries and such, which surprisingly seems to have turned out alright. The main body of my program is giving me trouble though:

Code:

---

/*

Assignment 4 [Source]- Random Number Game
*/

/*============================================================================================================*/
#include <stdio.h>
#include <stdlib.h>
#include "game.h"

/*Define variables.*/
int z;
int v = 0;
int r = 0;
char go; error

/*============================================================================================================*/
int main (void)
{

/*================================================*/
/*Function 1- Display header.*/
print_head(); /*Call header function from game.h*/

/*================================================*/
/*Function 2- Generate number and read guess.*/
while(v == 0)
{ /*Start the game.*/

z = 1 + rand() %1000; /*Generate random number between 1 and 1000.*/

/*Read guess from the user and assign to v.*/
        printf("I have a number between 1 and 1000.\n Can you guess my number?\n Please type your first guess:");
                v = 10001; /*Force start block to end loop.*/

} /*Close start of game.*/

while(v != 0)
{ /*Open the game's main body.*/

        scanf("%i", &v); /*Read the user's guess and store at v.*/

/*================================================*/
/*Function 3- Call CONT from game.h*/
CONT();

/*================================================*/
/*Function 4- Call GES from game.h IF the guess is incorrect.*/
if(v != z)
{
GES();
}

/*================================================*/
/*Function 5- Ask the user to restart the game or end the program.*/
if(v == z) /*Open restart block.*/
{
        printf("Would you like to play again?(y/n):");
        scanf("%c", &go);

if(go == y || go == Y) /*Use input "Yes" to re-enter the start of the game.*/ error
{
        v = 0;
}

} /*Close restart block.*/

/*================================================*/
} /*Close the game's main body.*/

/*================================================*/


return 0;
} /*Close the main function.*/
/*============================================================================================================*/

---

I marked what the debug told me. Can anyone help?

I believe it's expecting:

go == 'y'

or

go == 'Y'

but not

go == y

Since you don't indent worth a diddly, I can't help you with the return error.

Code:

---

} /*Close the main function.*/
/*============================================================================================================*/



return 0; ***ERROR?***
} ***ERROR?***

---

Why do you have code after the brace which closes the main function?

Quote:

---

Originally Posted by bithub

Code:

---

} /*Close the main function.*/
/*============================================================================================================*/



return 0; ***ERROR?***
} ***ERROR?***

---

Why do you have code after the brace which closes the main function?

---

Yeah, figured that one out after looking harder for a second. :x

Quote:

---

I believe it's expecting:

go == 'y'

or

go == 'Y'

but not

go == y

Since you don't indent worth a diddly, I can't help you with the return error.

---

Thaaaank you.

Oh great, now it's letting me know about more problems. I knew there had to be something wrong with my header/definitions.

Quote:

---

Source.obj : error LNK2001: unresolved external symbol _GES
Source.obj : error LNK2001: unresolved external symbol _CONT
Source.obj : error LNK2001: unresolved external symbol _print_head
Debug/Source.exe : fatal error LNK1120: 3 unresolved externals
Error executing link.exe.

---

game.h:

Code:

---

#define NAME "Mitch Trahan"
#define DATE "4/21/2009"
#define TITLE "RANDOM NUMBER GAME"

/*=================================================================================================*/

/*This function will display the header*/
void print_head(void);

/*=================================================================================================*/

/*This function will count the number of guesses and evaluate the user.*/
void CONT(void);

/*=================================================================================================*/

/*This function will check the guess and instruct the user.*/
void GES(void);

/*=================================================================================================*/

---

game.c

Code:

---

#include <stdio.h>
#include "game.h"

/*================================================================================================*/
/*Define function print_head.
print_head- Display header.
*/

void print_head(void)
{
printf("=*=*=*=*=*=*=*=*=*=*=*=*=*=*=*=*=*=*=");
        printf("\nProgram by: ");

        printf(NAME);

        printf("\nDate: ");

        printf(DATE);

        printf("\n");
        printf(TITLE);
        printf("\n");

printf("=*=*=*=*=*=*=*=*=*=*=*=*=*=*=*=*=*=*=");
       
        printf("\n");
return;
}

/*================================================================================================*/
/*
Define function CONT.
CONT- Gather the number of guesses and evaluate the user.
*/
void CONT(void)
{
        ++r; /*Count the number of guesses and store the tally at "r"*/

if(z == v) /*Once the user has guessed the correct number, begin evaluation.*/
{

                printf("Excellent! You guessed the number!"); /*Inform user of success.*/

                printf("\nIt took you %i tries to guess correctly.\n", r); /*Display counted attempts.*/

if(r > 10)
{
                printf("You should be able to do better!\n");
}
if(r == 10)
{
                printf("Aha! You know the secret!\n");
}
if(r < 10)
{
                printf("Either you know the secret or you got lucky!\n");
}

} /*Close the evaluation.*/


return;
}

/*================================================================================================*/
/*Define function GES.
GES- Run the user's input against the random number generated.
*/
void GES(void)
{

if(v > z)
{
        printf("Too high, try again.\n");
}
if(v < z)
{
        printf("Too low, try again.\n");
}

return;
}

---

Perhaps you haven't compiled "game.c" and linked with your program (in IDE's that's what projects are for).

There may also be problems with your use of global variables (shouldn't they be extern and declared in a header?). In any case, one should be able to program a simple number guessing game without relying on global variables.

Are you actually linking your files when you compile them?

Quote:

---

gcc -o someprog someprog.c game.c -Wall -pedantic

---

You need to be including all of the C or object files for them to be linked correctly.


Quzah.

I actually hadn't linked them...thanks.

There's definitely a problem with my variables, as the error that I'm getting now is calling them all undeclared. I've no concept of "global variables" or "external variables" so I'm about to go through my book for that. Thanks for all of the help.

All right! Got it running. Have a few things to iron out, but it works now so all is well. Thanks again.

Well, for some reason the program sticks to only one function at a time. I can't get it to run through the whole code, right now it runs to int CONT (void); , then loops back to the scanf(), and ends when the number is guessed.

Before I included the redundant IF statement before int CONT (void), the program skipped it and went to int GES (void) and then looped directly to scanf(), exiting the entire program if the number is guessed. So I can get one or the other to work, but not both. Shouldn't the program move on down the line after one function is executed?

Code:

---

/*============================================================================================================*/
#include <stdio.h>
#include <stdlib.h>
#include "game.h"

int z;
int v = 0;
int r = 0;
char go = 'y';


/*============================================================================================================*/
int main (void)
{

/*================================================*/
/*Function 1- Display header.*/
print_head(); /*Call header function from game.h*/

/*================================================*/
/*Function 2- Generate number and read guess.*/
while(go == 'y' || go == 'Y')
{ /*Start the game.*/

        z = 1 + rand() %1000; /*Generate random number between 1 and 1000.*/

/*Read guess from the user and assign to v.*/
        printf("I have a number between 1 and 1000.\n Can you guess my number?\n Please type your first guess:");
       
                go = 't'; /*Force start block to end loop.*/
       
} /*Close start of game.*/

while(go == 't')
{ /*Open the game's main body.*/

        scanf("%i", &v); /*Read the user's guess and store at v.*/

/*================================================*/
/*Function 3- Call CONT from game.h*/
if(z != v || z == v)
{
        int CONT(void);
}

/*================================================*/
/*Function 4- Call GES from game.h IF the guess is incorrect.*/
if(v != z)
{
        int GES(void);
}


/*================================================*/
/*Function 5- Ask the user to restart the game or end the program.*/
if(v == z) /*Open restart block.*/
{
        printf("Would you like to play again?(y/n):");
        scanf("%c", &go);

if(go == 'y' || go == 'Y') /*Use input "Yes" to re-enter the start of the game.*/
{
        v = 0;
        r = 0;
}

} /*Close restart block.*/

/*================================================*/
} /*Close the game's main body.*/

/*================================================*/

return 0;
} /*Close the main function.*/
/*============================================================================================================*/

---

Definitions:

Code:

---

#include <stdio.h>
#include "game.h"


/*================================================================================================*/
/*Define function print_head.
print_head- Display header.
*/

void print_head(void)
{
printf("=*=*=*=*=*=*=*=*=*=*=*=*=*=*=*=*=*=*=");
        printf("\nProgram by: ");

        printf(NAME);

        printf("\nDate: ");

        printf(DATE);

        printf("\n");
        printf(TITLE);
        printf("\n");

printf("=*=*=*=*=*=*=*=*=*=*=*=*=*=*=*=*=*=*=");
       
        printf("\n");
return;
}

/*================================================================================================*/
/*
Define function CONT.
CONT- Gather the number of guesses and evaluate the user.
*/
int CONT(void)
{
        ++r; /*Count the number of guesses and store the tally at "r"*/

if(v == z) /*Once the user has guessed the correct number, begin evaluation.*/
{

                printf("Excellent! You guessed the number!"); /*Inform user of success.*/

                printf("\nIt took you %i tries to guess correctly.\n", r); /*Display counted attempts.*/

if(r > 10)
{
                printf("You should be able to do better!\n");
}
if(r == 10)
{
                printf("Aha! You know the secret!\n");
}
if(r < 10)
{
                printf("Either you know the secret or you got lucky!\n");
}

} /*Close the evaluation.*/

return 0;
}

/*================================================================================================*/
/*Define function GES.
GES- Run the user's input against the random number generated.
*/
int GES(void)
{

if(v > z)
{
        printf("Too high, try again.\n");
}
if(v < z)
{
        printf("Too low, try again.\n");
}

return 0;
}

---

Code:

---

/*================================================*/
/*Function 3- Call CONT from game.h*/
if(z != v || z == v)
{
        int CONT(void);
}

---

That is not how you call a function, that is how you declare a function. To call it, you would do:

Code:

---

CONT();

---

Quote:

---

Originally Posted by bithub

Code:

---

/*================================================*/
/*Function 3- Call CONT from game.h*/
if(z != v || z == v)
{
        int CONT(void);
}

---

That is not how you call a function, that is how you declare a function. To call it, you would do:

Code:

---

CONT();

---

---

Ah, yeah I've been playing around with that trying to get it work. Wasn't sure.

Still doesn't want to go through all of the functions though.

Does return 0; close the entire program? Should I change the value for return in my functions?

return 0; just returns from a function. It will only end the program if you are returning from the main() function.

Quote:

---

Originally Posted by StateofMind

Ah, yeah I've been playing around with that trying to get it work. Wasn't sure.

Still doesn't want to go through all of the functions though.

Does return 0; close the entire program? Should I change the value for return in my functions?

---

Your code is incredibly hard to read. Please, post it with proper indentation. If we can't read it without massacring brain cells, we can't help you out.

But, to answer your question. When you 'call' return and some value, in any function(Except void functions, which don't return anything), it will close the function. If it's main you're returning from, you're effectively closing the program. If it's a function, then you're ending that function, returning control to the callee function, which will continue on with its own code.

Sorry about that. I think I've gone overboard with the /*comments*/. The color coding makes it a lot more readable, but pasting it somewhere else makes it look terrible. I'll try to fix it up.

Ok I went through and tried to make it easier to read. I still can't figure out why the program isn't going through its sequence like normal. After the first value is entered for "v", it runs through GES (which it should, but I don't know if it's using CONT to count the attempts or not) but then the program closes as soon as the correct number is found. I don't understand how choosing the correct number is causing the program to shut down... It should enter CONT and display the information there, then run through the "restart block" at the bottom of the program. Shouldn't it?

Definitions:

Code:

---

#include <stdio.h>
#include "game.h"




/*Define function print_head.
print_head- Display header.
*/

void print_head(void)
{
        printf("=*=*=*=*=*=*=*=*=*=*=*=*=*=*=*=*=*=*=");
       
        printf("\nProgram by: ");

        printf(NAME);

        printf("\nDate: ");

        printf(DATE);

        printf("\n");
       
        printf(TITLE);
       
        printf("\n");

        printf("=*=*=*=*=*=*=*=*=*=*=*=*=*=*=*=*=*=*=");
       
        printf("\n");

return;
}




/*
Define function CONT.
CONT- Gather the number of guesses and evaluate the user.
*/

int CONT(void)
{
        ++r; /*Count the number of guesses and store the tally at "r"*/

        if(v == z) /*Once the user has guessed the correct number, begin evaluation.*/
        {
               
                printf("Excellent! You guessed the number!"); /*Inform user of success.*/

                printf("\nIt took you %i tries to guess correctly.\n", r); /*Display counted attempts.*/


                if(r > 10)
                {
                        printf("You should be able to do better!\n");
                }
                if(r == 10)
                {
                        printf("Aha! You know the secret!\n");
                }
                if(r < 10)
                {
                        printf("Either you know the secret or you got lucky!\n");
                }

        } /*Close the evaluation.*/

return 0;
}




/*Define function GES.
GES- Run the user's input against the random number generated.
*/

int GES(void)
{

        if(v > z)
        {
                printf("Too high, try again.\n");
        }
        if(v < z)
        {
                printf("Too low, try again.\n");
        }

return 0;
}

---

Body:

Code:

---

#include <stdio.h>
#include <stdlib.h>
#include "game.h"


int z;
int v = 0;
int r = 0;
char go = 'y';



int main (void)
{


/*FUNCTION 1- Display header.*/
print_head(); /*Call header function from game.h*/



/*FUNCTION 2- Generate number and ask for guess.*/
while(go == 'y' || go == 'Y')
{

        z = 1 + rand() %1000; /*Generate random number between 1 and 1000.*/

        /*Read guess from the user and assign to v.*/
        printf("I have a number between 1 and 1000.\nCan you guess my number?\n\nPlease type your first guess:");
       
        go = 't'; /*Force block to stop loop.*/
       
} /*END F2*/



while(go == 't') /*Begin main body of game.*/
{
       
        scanf("%i", &v); /*Read the user's guess and store at v.*/



/*FUNCTION 3- Call CONT from game.h. CONT will count the attempts and check for accuracy.*/

CONT();



/*FUNCTION 4- Call GES from game.h IF the guess is incorrect. GES will direct the user to the correct number.*/

if(v != z)
{
        GES();
} /*END F4*/



/*FUNCTION 5- Ask the user to restart the game or end the program.*/

if(v == z)
{
        printf("Would you like to play again?(y/n):");
        scanf("%c", &go);

        if(go == 'y' || go == 'Y')
        {
                v = 0;
                r = 0;
        }

} /*End F5*/


} /*Close the game's main body.*/



return 0;
} /*Close the main function.*/

---

Quote:

---

Originally Posted by StateofMind

Ok I went through and tried to make it easier to read. I still can't figure out why the program isn't going through its sequence like normal. After the first value is entered for "v", it runs through GES (which it should, but I don't know if it's using CONT to count the attempts or not) but then the program closes as soon as the correct number is found. I don't understand how choosing the correct number is causing the program to shut down... It should enter CONT and display the information there, then run through the "restart block" at the bottom of the program. Shouldn't it?

Definitions:

Code:

---

#include <stdio.h>
#include "game.h"




/*Define function print_head.
print_head- Display header.
*/

void print_head(void)
{
        printf("=*=*=*=*=*=*=*=*=*=*=*=*=*=*=*=*=*=*=");
       
        printf("\nProgram by: ");

        printf(NAME);

        printf("\nDate: ");

        printf(DATE);

        printf("\n");
       
        printf(TITLE);
       
        printf("\n");

        printf("=*=*=*=*=*=*=*=*=*=*=*=*=*=*=*=*=*=*=");
       
        printf("\n");

return;
}




/*
Define function CONT.
CONT- Gather the number of guesses and evaluate the user.
*/

int CONT(void)
{
        ++r; /*Count the number of guesses and store the tally at "r"*/

        if(v == z) /*Once the user has guessed the correct number, begin evaluation.*/
        {
               
                printf("Excellent! You guessed the number!"); /*Inform user of success.*/

                printf("\nIt took you %i tries to guess correctly.\n", r); /*Display counted attempts.*/


                if(r > 10)
                {
                        printf("You should be able to do better!\n");
                }
                if(r == 10)
                {
                        printf("Aha! You know the secret!\n");
                }
                if(r < 10)
                {
                        printf("Either you know the secret or you got lucky!\n");
                }

        } /*Close the evaluation.*/

return 0;
}




/*Define function GES.
GES- Run the user's input against the random number generated.
*/

int GES(void)
{

        if(v > z)
        {
                printf("Too high, try again.\n");
        }
        if(v < z)
        {
                printf("Too low, try again.\n");
        }

return 0;
}

---

Body:

Code:

---

#include <stdio.h>
#include <stdlib.h>
#include "game.h"


int z;
int v = 0;
int r = 0;
char go = 'y';



int main (void)
{


/*FUNCTION 1- Display header.*/
print_head(); /*Call header function from game.h*/



/*FUNCTION 2- Generate number and ask for guess.*/
while(go == 'y' || go == 'Y')
{

        z = 1 + rand() %1000; /*Generate random number between 1 and 1000.*/

        /*Read guess from the user and assign to v.*/
        printf("I have a number between 1 and 1000.\nCan you guess my number?\n\nPlease type your first guess:");
       
        go = 't'; /*Force block to stop loop.*/
       
} /*END F2*/



while(go == 't') /*Begin main body of game.*/
{
       
        scanf("%i", &v); /*Read the user's guess and store at v.*/



/*FUNCTION 3- Call CONT from game.h. CONT will count the attempts and check for accuracy.*/

CONT();



/*FUNCTION 4- Call GES from game.h IF the guess is incorrect. GES will direct the user to the correct number.*/

if(v != z)
{
        GES();
} /*END F4*/



/*FUNCTION 5- Ask the user to restart the game or end the program.*/

if(v == z)
{
        printf("Would you like to play again?(y/n):");
        scanf("%c", &go);

        if(go == 'y' || go == 'Y')
        {
                v = 0;
                r = 0;
        }

} /*End F5*/


} /*Close the game's main body.*/



return 0;
} /*Close the main function.*/

---

---

There are a few.. errors in the code. As far as I can see, it should compile, but the code is badly designed, and will inevitably result in strange stuff which is hard to debug, just like your are experiencing now, due to global variables and things like that.

I would personally write the code from the beginning, just taking it nice and easy, and taking some time to think about how it should be implemented, before you go ahead and write all of it. Then, when you've got an idea in your head, or on paper, implement the first part, then try it out, then the next, try it, and rinse and repeat.

I'm not sure what the program must feature, since this is a homework assignment, but there is really no need for dividing this up into functions, considering the complexity of the program.

Like I mentioned, instead of using global variables, pass them to your functions(If you insist on using them).

I just tried compiling your code and running it, and it seems to work fine, in spite of the 'design problems'. What seems to be the problem?

i havent read code but i m seeing you have global variables inside i m sure thats the problem try debugging it lil bit by printing out there values.
also some functions are completely useless like that checking in GES u can make it somewhere else functions are only used where you dont do stuff more than once but checking and stuff like thats its better to have them in main because your confusing yourself.

Quote:

---

Originally Posted by IceDane

There are a few.. errors in the code. As far as I can see, it should compile, but the code is badly designed, and will inevitably result in strange stuff which is hard to debug, just like your are experiencing now, due to global variables and things like that.

I would personally write the code from the beginning, just taking it nice and easy, and taking some time to think about how it should be implemented, before you go ahead and write all of it. Then, when you've got an idea in your head, or on paper, implement the first part, then try it out, then the next, try it, and rinse and repeat.

I'm not sure what the program must feature, since this is a homework assignment, but there is really no need for dividing this up into functions, considering the complexity of the program.

Like I mentioned, instead of using global variables, pass them to your functions(If you insist on using them).

I just tried compiling your code and running it, and it seems to work fine, in spite of the 'design problems'. What seems to be the problem?

---

It compiles for me with no errors, but the program won't run through all of the functions. It works fine and goes through GES like it should (as far as I can tell; like I mentioned, I don't know if CONT is running and counting the attempts before it gets to GES or not), but once the correct number is guessed- the program exits.

The assignment was to create our own functions, using a header file for prototypes, a c file for definitions, and a c file for the main body of the program. Apparently I still don't know what a global variable is. I set this up in my header file:

Code:

---

extern int z;
extern int v;
extern int r;
extern char go;

---

Quote:

---

Originally Posted by elwad

i havent read code but i m seeing you have global variables inside i m sure thats the problem try debugging it lil bit by printing out there values.
also some functions are completely useless like that checking in GES u can make it somewhere else functions are only used where you dont do stuff more than once but checking and stuff like thats its better to have them in main because your confusing yourself.

---

Yeah, and that threw me off a lot. The assignment says to use a separate function for checking the guess and for counting it. I could probably make this program run a lot easier without going through all of this, but I guess he's wanting us to just practice making our own functions.

You may need to add a loop to validate their input. Or, you may need to clear the input stream after calling it. Typically when using scanf people encounter left over characters in the input stream, which cause it to skip the next call to scanf. There is a section in the FAQ which covers flushing the input stream.

What happens when you ask it for one character, such as 'y' or 'n'? Well you actually send it a couple of characters, because you have to press ENTER to make it take your input. Unless you handle the fact that you've sent ENTER also, it's going to leave that there, and read it on your next call.


Quzah.