sorting an array of structures

***THE TITLE SHOULD SAY SORTING A STRUCTURE NOT AN ARRAY!!!***


ok this is the last part i need finished for this program and its causing quite a headache.

basically im storing data in a structure and it needs to be sorted. i have figured out the general outline from information ive found on here and what ive been able to work on.

when i compile the code i am getting these errors:

Code:

---

64: parse error before `temp'
66: incompatible types in assignment

---

and of course here is the code for the program:

Code:

---

#include <stdio.h>

/* Define structure */
struct info
{
        long int accntNum;
        char name[25];
        float balance;
};

/* Begin main */
main()
{
        /* Declare variables */
        struct info client[25];
        int temp = 0;
        int x, y, numClient;
       
        /* Display opening message */
        printf ("Welcome to Client Account Information Services\n\n");
       
        /* Prompt for how many clients will have info entered */
        printf ("Enter number of clients to be used: ");
        scanf ("%i", &numClient);
       
        /* Prompt for user to enter each clients info */
        for (x = 0; x < numClient; x++)
        {
                printf ("\nEnter account number: ", x + 1);
                scanf ("%ld", &client[x].accntNum);
               
                fflush(stdin); /* Remove extraneous characters */
                printf ("Enter last name: ", x + 1);
                gets (client[x].name);
                fflush(stdin); /* Remove extraneous characters */
               
                printf ("Enter balance: ", x + 1);
                scanf ("%f", &client[x].balance);
        } /* end for */
       
        /* Sort array in ascending order by account number */
        for (y = 1; y < x - 1; y++)
        {
                for (x = 1; x < numClient; x++)
                {
                        if (client[x].accntNum > client[x + 1].accntNum)
                        {
                                info temp = client[x];
                                client[x] = client[x + 1];
                                client[x + 1] =  temp;
                        } /* end if */
                } /* end for */
        } /* end for */

        /* Display each clients information */
        printf ("\nACCOUNT        LAST NAME        BALANCE");
        for (x = 0; x < numClient; x++)
        {
                printf ("\n%7d %17s %15.2f", client[x].accntNum, client[x].name, client[x].balance);
        } /* end for */
       
        printf ("\n");
        return 0;
       
} /* end main */

---

basically just need to figure out what is not correct when i am calling the 'info temp = client[x]; line or just before it.

all help is appreciated!

(i also realize this similar question has been asked recently. i have viewed those posts but it has only got me stuck at this point. i have a feeling its something simple i am not noticing, but sometimes we all need a fresh set of eyes to look at things)

i dont know much about structures but just do this

Code:

---

struct info temp=client[x];

---

it should work fine

As stated above, that makes everything simpler.

You'll need to start your sorting at subscript 0, not 1.

hmm ok now it compiles, but its not sorting.

any ideas?

basically its not sorting anything and my third line is coming up with garbage information.

when i ran the same code its getting sorted according to the account number.ok now i see its working fine for 2 accounts.

its acting kind of strange now for me. it just worked with 5 accounts, but wont work for 2, 3, or 4 accounts.

yep just ran 2 accounts, and its not sorting for me. hmmm

ahhhhhh got it fixed now!

thanks for all the help!

Quote:

---

Originally Posted by kisiellll

ahhhhhh got it fixed now!

thanks for all the help!

---

what did you do.

I'm not sure of your sorting algo. The x+1 looks quite wrong. You should be comparing x with y subscripts, in the array. Array[x+1] will be 1 subscript too high when x is at the top of the array (one less than max Array Size).

This is a known good sorter for small arrays.

Code:

---

struct client temp;

for(i = 0; i < MaxArray-1; i++)  {
  for(j = i + 1; j < MaxArray; j++)  {
      if(client[i].accnum > client[j].accnum)  {
        temp = client[i];
        client[i] = client[j];
        client[j] = temp;
      }
  }
}

---

ok well i actually never fixed it. i modified some code somewhat like Adak just posted and it looked workable somewhat, but i was still getting junk.

i just used Adaks example and it seems to be good so far.

thanks adak

by the way never use gets.see the faq section of this site.

Your quite welcome. I've been using that code for sorting for a very long time.

Quote:

---

Originally Posted by Adak

I'm not sure of your sorting algo. The x+1 looks quite wrong. You should be comparing x with y subscripts, in the array.

---

No. Never say that someone should use that sorting algorithm instead of BubbleSort. BubbleSort is better, largely because it is stable whereas that sorting algorithm is not. [x+1] or [x-1] is simply how you compare an item adjacent to item x.

The problem was that this

Code:

---

                for (x = 1; x < numClient; x++)

---

should have been

Code:

---

                for (x = 0; x < numClient-1; x++)

---

.Either that or it should have been [x-1]

Are you missing something in here?:

Code:

---

printf ("\nEnter account number: ", x + 1);

...

printf ("Enter balance: ", x + 1);

---

fflush is not defined for input streams:

Code:

---

fflush(stdin); /* Remove extraneous characters */

---

You are doing nothing to protect against a user entering more than 25 users. If they type in 50 for the answer to the "Enter the number of clients" question what happens?

Code:

---

/* Declare variables */
struct info client[25];

...

printf ("Enter number of clients to be used: ");
scanf ("%i", &numClient);
       
/* Prompt for user to enter each clients info */
for (x = 0; x < numClient; x++)
{

---