crazy if statement

hi i have this code

Code:

---

#include <stdlib.h>
#include <stdio.h>
#include <math.h>
//#include <iof1.h>
#include <stdarg.h>
#include <time.h>


int main()
{
        int PORTE,i;
        int trigarray[5];
        int trigmask;
        int totalmask;
        int trig;

    trigarray[0]=0;
    trigarray[1]=0;
    trigarray[2]=0;
    trigarray[3]=0;
    trigarray[4]=0;
    trigarray[5]=0;


    while(1)
    {
        PORTE=4;

  if((PORTE=1)&& (trigarray[0]==0)){trigarray[0]=1; trig=1;}
  if((PORTE=2) &&(trigarray[1]==0)){trigarray[1]=1; trig=2;}
  if((PORTE=4) &&(trigarray[2]==0)){trigarray[2]=1; trig=4;}
  if((PORTE=8) &&(trigarray[3]==0)){trigarray[3]=1; trig=8;}
  if((PORTE=16) &&(trigarray[4]==0)){trigarray[4]=1; trig=16;}
  if((PORTE=32) &&(trigarray[5]==0)){trigarray[5]=1; trig=32;}


totalmask+=trig;
printf("%d",totalmask);;

    }
}

---

and what i want it to only run each of the if statement so it doesnt mess up my mask

sooo i only want the because coz i need the while loop it will bump my total mask up beacuse it will keep running the same if statement soo i try to use trigarray and set it to 1 and make the if statements need to requirements to run but its not working my knowledge is not that great can you guys help?

your code has infinite while loop.

your explanation why it should not run infinitely and when it should exit tell me nothing.

so could you explain once again what do you want to achieve? and why do you need a loop?

Quote:

---

and what i want it to only run each of the if statement so it doesnt mess up my mask

---

I take this to mean that you only want it to run one of the if statements? . . .

Code:

---

  if((PORTE=1)&& (trigarray[0]==0)){trigarray[0]=1; trig=1;}
  else if((PORTE=2) &&(trigarray[1]==0)){trigarray[1]=1; trig=2;}
  else if((PORTE=4) &&(trigarray[2]==0)){trigarray[2]=1; trig=4;}
  else if((PORTE=8) &&(trigarray[3]==0)){trigarray[3]=1; trig=8;}
  else if((PORTE=16) &&(trigarray[4]==0)){trigarray[4]=1; trig=16;}
  else if((PORTE=32) &&(trigarray[5]==0)){trigarray[5]=1; trig=32;}

---

, in that case, that should be what you're looking for.

Also, as vart points out, you have a nice infinite loop up there.

May I point you here as well?

if assignments in the ifs are by design - this code is alitle bit obfuscated and tells me nothing about its purpose...

well i want to build up a mask by adding 1 , 2 ,4 ,8 ,16 , 32 which i will then use to make my lights flash but i can only have the 1 be used once or the 2 be used once or the 18 . so i can get get a maximum of 63 if all the ifs add up the final mask.

its like i only want to allow the if statement to only run once but allow the others to run but when one of them have been used stop it from being used

its a little hard to understand maybe that helped


im using this code as if the switch is flicked on make the light blink dont keep running the if statement and if the switch is flicked back down the light will still be blinking

So are you looking for something that toggles bits on and off, then? . . .

what you want - is bit manipulation

instead of + use

mask |= (1 << n) ; to set the bit n to 1
and
mask &= ~(1<<n); to set it to 0

I still cannot understand the loop procedure you want to achieve

could you write it down in word like

1st iteration set bit 1
2nd iteration clear bit 1 set bit 2
...
32st iteration clear bit 31 set bit 32
exit loop
clear bit 32

or something like that

yea that sounds kinda what im trying to do when its on stay on and dont change kinda thing

Quote:

---

Originally Posted by jamespond88

yea that sounds kinda what im trying to do when its on stay on and dont change kinda thing

---

kinda very far from explanation I have asked

soz i was replying to the other guy i think i want to toggle i think what i want is

if (port1)&&(toggle off) mask=X, toggle on

so when it then comes back around it wont execute that if because toggle is now on

Well . . . .

Just go something like this to set a bit . . .

Code:

---

/* to set a bit on . . . in this case, the third */
flags |= 0x08;
/* to remove a bit */
flags &= ~0x08;

---

Make sense? The ~ operator inverts all the bits in a given variable.

Quote:

---

Originally Posted by Nightowl

Well . . . .

Just go something like this to set a bit . . .

Code:

---

/* to set a bit on . . . in this case, the third */
flags |= 0x08;
/* to remove a bit */
flags &= ~0x08;

---

Make sense? The ~ operator inverts all the bits in a given variable.

---

i dont understand if i set the"bit" on what will happen it dont know about bit shifting ect

Quote:

---

Originally Posted by jamespond88

i dont understand if i set the"bit" on what will happen it dont know about bit shifting ect

---

I'm afraid I can't explain any further before you explain what you're looking for. We're not psychic! We cannot read your mind. You have to explain what the problem is, in enough detail for someone like me, without your previous experiences, to come in and help solve the problem.

Explain the problem further, then me and vart might be able to help you.

okky i will try and explain
i have a bigger program which i will put all this into. i have a while infinity loop in my main program becasue it is responsible for making the zones flash


zone1=1 000001
zone2=2 000010
zone3=4 000100
zone4=8 001000
zone5=16 010000
zone6=32 100000

these all need to be toggled on ONCE because if zone 1 is used once it will mess up my binary mask. soo thats what i was trying to do with the if statement

if(TOGGLE=0)&&(zone1) toggle=1

soo it has to have 2 true requirements for it to run the if but after it runs it once toggle=1 soo only 1 of the requirements is now true so that if will not run

sorry im not the best of explaining things

So, you want to toggle everything on once, then just leave it? Toggle everything on within the amount of time it takes to run 5 instances of a while loop? Or are you thinking of blinking lights?

I'm sorry, but I don't understand completely what you're trying to do here.

no i dont want them all on at once like when zone 1 has been used toggle that on soo it cant be used again so i dont get 1 + 1 then when zone 2 is used toggle that on so i dont get 2+2

just so it stops adding up the values wrong to stop my binary mask

. . . there's a reason why me and vart suggested the code that we did.

Here's an example:

Code:

---

unsigned char x = 0;
/* x before: 00000000 */
x |= 0x08;
/* x now: 00001000 */
x |= 0x04;
/* x now: 00001100 */
x &= ~0x08;
/* x now: 00000100 */

---

It sets *only* that bit, nothing else.

The binary mask will be fine, that's how you handle binary masks in C.

okky it sounds kind of what im after how do i go about doing it ?

. . . read the above message(s). Me and vart have explained this no less than 3 times so far.

Quote:

---

Originally Posted by jamespond88

okky it sounds kind of what im after how do i go about doing it ?

---

Especially for you I have changed my signature

. . . and I would have too, but it would put it over 500 chars.

Point is, we're here to help. We're not here to do your work for you.

Figure out as much as you can yourself, then come back once you have a solid question that actually merits some help. I highly recommend the link in my signature to Eric S. Raymond's "How to ask Smart Questions".

i dont want you to do it but you putting a peice of code in is not making me learn i dont understand the bit of code

Then what do you not understand about it?? Clarify. Elaborate.

you have

Quote:

---

unsigned char x = 0;
/* x before: 00000000 */
x |= 0x08;
/* x now: 00001000 */
x |= 0x04;
/* x now: 00001100 */
x &= ~0x08;
/* x now: 00000100 */

---

is x a int?

and will this stay toggled and not change any of the values when they are up?

and

Uhm... How come nobody has noticed that you are accidentally using '=' instead of '=='?

Correct. x, in this case, is actually an unsigned char, or an 8-bit integer.

When you toggle a bit to ON, it does not touch the other bits in the mask, no.

EDIT: I noticed that, brewbuck. Didn't think to mention it, because the whole thing seemed wrong.

Quote:

---

Originally Posted by brewbuck

Uhm... How come nobody has noticed that you are accidentally using '=' instead of '=='?

---

because somebody namely me has noticed. But OP could not elaborate if it was really accidentally or intentionally