Vector subscript out of range? (Sudoku)

Hi guys, please bare with me, i'm a bit of a newbie to C++. I'm trying to write a Sudoku puzzle. I'm trying to get the program to ask the user a number between 0-80 (which represents the board position) so that the user can input a number 1-9 in to that place.

My code is probably too long, probably is a shorter way of doing it. Here's my code.

[fixed] The problem: it says the "Vector subscript out of range", i presume the problem is where i've put the code in bold (look) below. How can I fix this?

(look at post #10 for my code)

You have a vector with 9 elements, numbered from 0..8 - you probably want a vector of vector.

I'm not sure what you expect this to do:

Code:

---

cout << "\n\t" << board[0, 1, 2] << "      |" << board[3, 4, 5] << "        | " << board[6, 7, 8];

---

But I expect it is not doing what you expect, as what it is actually being done is:

Code:

---

cout << "\n\t" << board[2] << "      |" << board[5] << "        | " << board[8];

---

--
Mats

Well what do you think this does? vector's subscript operator does not take multiple indices.

Based on this:

Code:

---

const int NUM_SQUARES = 9;
vector<char> board(NUM_SQUARES, EMPTY);

---

It looks like your vector has a size of 9.

Now, board[0, 1, 2] is actually board[2]. The comma operator is effect, thus 0, 1, 2 is evaluated as 2. Once we go to board[9, 10, 11], we see that we are accessing board[11], which is out of bounds. Actually, even board[9] is out of bounds. You probably want to print board[0] to board[8] in turn.

Quote:

---

Originally Posted by matsp

You have a vector with 9 elements, numbered from 0..8 - you probably want a vector of vector.

I'm not sure what you expect this to do:

Code:

---

cout << "\n\t" << board[0, 1, 2] << "      |" << board[3, 4, 5] << "        | " << board[6, 7, 8];

---

But I expect it is not doing what you expect, as what it is actually being done is:

Code:

---

cout << "\n\t" << board[2] << "      |" << board[5] << "        | " << board[8];

---

--
Mats

---

Well the number 0-80 represents the cell location, the program asks the user to input say cell location 15, then a number 1-9.

To be honest i don't really know how to tackle this. :confused:

Quote:

---

Originally Posted by laserlight

Based on this:

Code:

---

const int NUM_SQUARES = 9;
vector<char> board(NUM_SQUARES, EMPTY);

---

It looks like your vector has a size of 9.

Now, board[0, 1, 2] is actually board[2]. The comma operator is effect, thus 0, 1, 2 is evaluated as 2. Once we go to board[9, 10, 11], we see that we are accessing board[11], which is out of bounds. Actually, even board[9] is out of bounds. You probably want to print board[0] to board[8] in turn.

---

Ahh.. ok, i'll go try it again, thanks.

Quote:

---

Originally Posted by mt1

Well the number 0-80 represents the cell location, the program asks the user to input say cell location 15, then a number 1-9.

To be honest i don't really know how to tackle this. :confused:

---

Yes, so you may not need a vector of vectors, just an array of 81 elements.

--
Mats

Quote:

---

Originally Posted by matsp

Yes, so you may not need a vector of vectors, just an array of 81 elements.

--
Mats

---

Yep, I got it now, just going to take me a while lmao. Thanks all.

Well, if you try to control your laughter, you may get there a bit quicker! ;)

And remember, in a year or two, you'll think "and why did I think that was so hard..."?

--
Mats

Is there not another way to do this?

Code:

---

// Sudoku

#include <iostream>
#include <string>
#include <vector>
#include <windows.h>

using namespace std;

// function prototypes
void instructions();
void displayBoard(const vector<char>& board);

// main function
int main()
{
    const int NUM_SQUARES = 81;
    vector<char> board(NUM_SQUARES);
       
    instructions();
Sleep(2000);
    displayBoard(board);

    return 0;
}

// functions
void instructions()
{
    cout << "Welcome to Sudoku!" << endl << endl;
    cout << "Make your move known by entering a number, 0 - 80." << endl;
    cout << "The number corresponds to the desired board position, as illustrated: " << endl;
        cout <<  endl;
   
    cout << "      0  1  2 | 3  4  5 | 6  7  8 |\n";
    cout << "      9  10 11| 12 13 14| 15 16 17|\n";
    cout << "      18 19 20| 21 22 23| 24 25 26|\n";
    cout << "      -----------------------------\n";
    cout << "      27 28 29| 30 31 32| 33 34 35|\n";
    cout << "      36 37 38| 39 40 41| 42 43 44|\n";
    cout << "      45 46 47| 48 49 50| 51 52 53|\n";
    cout << "      -----------------------------\n";
    cout << "      54 55 56| 57 58 59| 60 61 62|\n";
    cout << "      63 64 65| 66 67 68| 69 70 71|\n";
    cout << "      72 73 74| 75 76 77| 78 79 80|\n\n";

    cout << "Here comes the puzzle.\n\n";
}


void displayBoard(const vector<char>& board)
{
cout << "\n\t" << board[0] << "  5" << "  1" << "| 7" << " " << board[4] << " " << board[5] << "  | " << board[6] << "  6" << "  2";
cout << "\n\t9"<< " " << board[10] << " " << board[11] << "  | " << board[12] << " " << board[13] << "  6" << " | " << board[15] << " " << board[16] << "  8" << board[17];
cout << "\n\t8"<< "  3" << " " << board[20] << " | " << board[21] << " " << board[22] << "  2" << " | " << "1";
cout << "\n\t" << "---------------------------";

        cin.get();
}

---

You mean setting up the "constant" (already filled in) values?

You could just put them into your vector before you show the board the first time.

--
Mats

Quote:

---

Originally Posted by matsp

You mean setting up the "constant" (already filled in) values?

You could just put them into your vector before you show the board the first time.

--
Mats

---

Yes.

Don't understand?

Eventually you'll need to start using loops (and even nested loops), e.g to display the contents of the vector.

And aside, your sleep function is terrible. On Windows include "windows.h" and just use the Sleep function. Linux should have a corresponding function sleep. There is no point in heating the processor to do nothing useful.

Quote:

---

Originally Posted by anon

Eventually you'll need to start using loops (and even nested loops), e.g to display the contents of the vector.

And aside, your sleep function is terrible. On Windows include "windows.h" and just use the Sleep function. Linux should have a corresponding function sleep. There is no point in heating the processor to do nothing useful.

---

Changed thanks. I'm still not too sure how to tackle this.

Can you describe what it is that you are trying to tackle?

--
Mats

Quote:

---

Originally Posted by matsp

Can you describe what it is that you are trying to tackle?

--
Mats

---

1. The void displayboard function, "You could just put them into your vector before you show the board the first time. " I don't know what you mean by this.

2. I'm still trying to get my program to recognise each cell location so that when the user inputs 1-9 it will be put in to that cell, but before doing that i need enter the constants ike you said earlier, however the way i'm doing it would take forever.

So, how much do you understand about manipulating vectors in general - how would you put the number 6 in cell number 7 of a vector? Now, if you know that, how would you fill in the constant part of the Sudoku puzzle?

Also, what sort of input have you dealt with so far?

--
Mats

Quote:

---

Originally Posted by matsp

So, how much do you understand about manipulating vectors in general - how would you put the number 6 in cell number 7 of a vector? Now, if you know that, how would you fill in the constant part of the Sudoku puzzle?

Also, what sort of input have you dealt with so far?

--
Mats

---

Never dealt with vectors before, was just an idea I cam across whilst reading my book, thought I could adapt from the Tic Tac Toe program from the book. I tried to adapt from it but it's proving a bit complicated...

Code:

---

void instructions()
{
    cout << "Welcome to the ultimate man-machine showdown: Tic-Tac-Toe.\n";
    cout << "--where human brain is pit against silicon processor\n\n";

    cout << "Make your move known by entering a number, 0 - 8.  The number\n";
    cout << "corresponds to the desired board position, as illustrated:\n\n";
   
    cout << "      0 | 1 | 2\n";
    cout << "      ---------\n";
    cout << "      3 | 4 | 5\n";
    cout << "      ---------\n";
    cout << "      6 | 7 | 8\n\n";

    cout << "Prepare yourself, human.  The battle is about to begin.\n\n";
}

---

about input, the only input i've done is something like this

Code:

---

#include <iostream>
using namespace std;

int main()
{       
        //        Declarations
        double celsius, fahrenheit;

        //        Input
        cout << "Enter temperature in Celsius: ";
        cin >> celsius;
        cout << endl;

        //        Calculation
        fahrenheit = (celsius*9)/5 +32;

        //        Output
        cout << celsius << " Celsius is (approx.) ";
        cout << fahrenheit  << "F.";
        cout << endl << endl;

        return 0;
}

---

So, given what you know of the vectors and cin >>.

--
Mats

Quote:

---

Originally Posted by matsp

So, how much do you understand about manipulating vectors in general - how would you put the number 6 in cell number 7 of a vector? Now, if you know that, how would you fill in the constant part of the Sudoku puzzle?

Also, what sort of input have you dealt with so far?

--
Mats

---

cout << " " << board[7];

cin >> board[7];

*shrugs*

Quote:

---

Originally Posted by mt1

cout << " " << board[7];

cin >> board[7];

*shrugs*

---

Right, I think you need to learn a bit more about vectors and input/output (I/O) before you try to write a rather complex program.

I'm sorry, but holding your hand through this is probably a bit too much for me to cope with. Try looking at the tutorials on www.cprogramming.com - I'm pretty sure there is a section on vectors. And another on covers simple input & output.

--
Mats

Quote:

---

Originally Posted by matsp

Right, I think you need to learn a bit more about vectors and input/output (I/O) before you try to write a rather complex program.

I'm sorry, but holding your hand through this is probably a bit too much for me to cope with. Try looking at the tutorials on www.cprogramming.com - I'm pretty sure there is a section on vectors. And another on covers simple input & output.

--
Mats

---

Ok.

I can see file I/O but that's probably not what i'm looking for? Can't see anything about vectors.

Quote:

---

Originally Posted by mt1

Ok.

I can see file I/O but that's probably not what i'm looking for? Can't see anything about vectors.

---

http://www.cprogramming.com/tutorial/stl/vector.html