While Loop Query - code displayed

Hi,

Anybody know why the code within the while loop won't function correctly? I basically want the user to enter letters until they run out of lives. But it keeps printing the text incorretly and not returning the correct answers.

Code:

---


while (lives !=0)

{

printf("\n\nPlease select a letter: ");
scanf("%c", &letter);


for (x=0; x < number; x++)

{
        this_guess == 0;
        if (letter == gameword[x])
                {
                        guessedword[x] = letter;
                        printf("Well done, you have chosen a correct letter:  %s\n", guessedword);
                        this_guess[x] = 1;
                }

  if (this_guess[x] == 0)
                {

                        printf("incorrect guess");
        lives--;

                }

}
}

---

Thanks

you should decide what should be done inside while loop and what - inside the for loop

Can you not have a for loop inside a while loop? Sorry for the ignorance i've only been programming for a few weeks.

Thanks

you do not need the subscript [x] on thisguess. And you have the brackets in the wrong places.

Code:

---

while (lives !=0) {
  printf("\n\nPlease select a letter: ");
  scanf("%c", &letter);

  this_guess = 0;  // This needs to be outside the for loop
  for (x=0; x < number; x++) {   
    if (letter == gameword[x]) {
      guessedword[x] = letter;
      printf("Well done, you have chosen a correct letter:  %s\n", guessedword);
      this_guess = 1;
    }
  } // End for loop here
  if (this_guess == 0)  { //This needs to be after the for loop.
    printf("incorrect guess");
    lives--;
  }
}

---

Quote:

---

Originally Posted by darren78

Can you not have a for loop inside a while loop?

---

Of course you can. I would love it if you would indent them appropriately tho. (I think vart means something different.)

One possible problem I noticed is that this:

Code:

---

        this_guess == 0;

---

should be this

Code:

---

        this_guess = 0;

---

Way, way back when I started with C I actually mixed this up so much I took a big red marker and scrawled
==
on my keyboard above the function keys.

Yeah I fixed that but forgot to note it.

Excellent....thanks for your time guys.

I have done everything above, but it seems to be looping through the while loop twice but only picking up certain parts. If i enter a letter, it will go through the loop correctly and then go through it again but will print out "please choose a letter" "incorrect guess" and will deduct a life?

Eh?

Any ideas?

Thanks very much.

Quote:

---

Originally Posted by darren78

Excellent....thanks for your time guys.

I have done everything above, but it seems to be looping through the while loop twice but only picking up certain parts. If i enter a letter, it will go through the loop correctly and then go through it again but will print out "please choose a letter" "incorrect guess" and will deduct a life?

Eh?

Any ideas?

Thanks very much.

---

We had someone ask the same question (in the context of a remote control, as I recall) just yesterday or so, so a board search may be useful here.

Probably something to do with the scanf picking up the '\n' character or something... I can't remember the fix to that though...

Put a getchar(); line after each scanf() call. Pulls that newline right off there.

What if the user types "hello" then hits enter...

I would suggest putting...

Code:

---

while (lives !=0) {
  printf("\n\nPlease select a letter: ");
  scanf("%c", &letter);

  if (letter != '\n') {  // Only accepts the letters
    this_guess = 0;  // This needs to be outside the for loop
    for (x=0; x < number; x++) {   
      if (letter == gameword[x]) {
        guessedword[x] = letter;
        printf("Well done, you have chosen a correct letter:  %s\n", guessedword);
        this_guess = 1;
      }
    }
  } // End for loop here
  if (this_guess == 0)  { //This needs to be after the for loop.
    printf("incorrect guess");
    lives--;
  }
}

---

note the if statement...

incidentally, now if the user types several letters, your program will count/test/reject each one in turn until it hits the '\n'

Just a warning - your program accepts ANY character, including numbers, &, !, etc...

Thanks all for your help.

Will give it a go after dinner.

No Problemmo