Hex editor problem

I wrote a hex viewer with the following code

Code:

---

#include <stdio.h>
#include <sys/stat.h>
#include <sys/types.h>
#include <time.h>

int main(int argc, char *argv[])
{
        struct stat fbuf;
        FILE *dump;
        int i;
        int x = 0;
        unsigned int size;
        if(argc<2)
        {
                puts("Format: HEXDUMP filename");
                exit(0);
        }
        dump = fopen(argv[1],"rb");
        if(dump == NULL)
        {
                printf("Error opening %s.",argv[1]);
                exit(0);
        }
        size = stat(argv[1],&fbuf);
        size = fbuf.st_size;
        while(i=fgetc(dump), size != 0)
        {
                printf("%0.2X ",i);
                x++;
                size--;
            if(!(x%16))
                {
                        putchar('\n');
                }
        }
        fclose(dump);
        return(0);
}

---

What do I do so I can actually EDIT the info?

Same as any other editor.

You read (some) of the file into a buffer.
You create a visual representation of the file.
You ask the user what they want to change (maybe they just point and click, or move a cursor).
When they hit "save" you write the file.

I don't understand????!!!!!

How about beginning with the simple stuff, like which OS/Compiler you're using, and what kind of user interface (console, GUI), and whether you're going to use some kind of library to manage the screen / input.

I am using Vista and XP. I use gcc for a compiler, and I am using a console interface. SIDE NOTE: can gcc make DOS-compatible 16-bit apps?

With console you might really want to use some non standard library to handle the screen. One of the simple (and still usable) libraries is ncurses.

Other than that, it is pretty much what salem said. All editors tend to do those things. 1. Read file (or piece of large file) in memory buffer, give it on user's display, allow editing, and when save is requested, write buffer back to a file.

EDIT: And if it was not console, then you did want to use non standard library :)

But how do you allow editing?

Thats up to the editing interface you design. You can for example allow user to hit E (as edit key), or A as add key, enter the location of the new mark, and then give the new mark. It is easy for you to handle, but I doubt your editor becomes popular :)

Or then you want to allow user to move the cursor on screen and update contents (here's when ncurses will be handy) as most editors do.

Or then you can just invent something funny and original, perhaps allow user to enter new chars using on morse codes and mouse button?

Sorry, I know I am not giving the answer you want to read, but I really cannot give it. I just suggest you to browse some library which allows you to handle cursor on screen more efficiently than standard C libraries, (and as I said, ncurses is one option, though not the only),

Let me rephrase that, How can you allow editing using the standard C library?I do not want to use the mouse.

Quote:

---

But how do you allow editing?

---

AFAIK you dont 'edit' files on disk. You load them into RAM, edit them in RAM, then write the content out to disk when you want to save it. Currently you're just reading a character at a time and printing it out to the screen. So, what you need to do is:

1) Learn how to allocate memory for your file (plus some extra incase you want to add something)
2) Load the file into memory
3) Edit the content in memory
4) Learn how to write the content out to disk

Try googling 'malloc' and 'fwrite'

I know how to use malloc and fwrite. What I want to know is how to put characters on the screen and let users edit them. My problem isn't in the loading or saving, it's the editing.

If you want to move the cursor and allow the editing as normal editors do... ...Then I really doubt you want to use only standard C libraries. If you do, and if you manage to do it, I am really interested seeing how you solved the problem :)

Well the first step is, obviously, to make a representation in RAM. Which is something you havent shown yet. I'd recommend you start with that.

Libraries are written using standard C keywords. There has to be a way to do it. What about inline asm?

So, like... load something from disk, then use malloc to allow space for it... I'm starting to get the picture, but what would I do? Store it in an array? I can make a program that will edit a structure, but a string is harder. Would I represent it as a long string?

Quote:

---

but what would I do? Store it in an array?

---

Yeah basically. How you represent it is up to you. A long string is simple to implement, but can be inefficient when you want to insert characters into the middle of it. But as its the easiest, I'd probably go for that first.

You can keep the data as it is. I guess most hexa editors do that. Then you can print the file contents in one byte chunks with %x specifier. You can edit cretain spot in the buffer easily. You can add data in buffer, by moving rest of the stuff, or you can internally use more than 1 buffer and just combine them when you do the output to screen (or file). This is all easy. But try moving cursor with standard C, try getting it's position, try... It propably is doable, but being honest... I have no idea how to do that (especially no idea how to do that portably) with standard C. THat's why I asked you to show me how you did it when you're done.

But is there any code I can use to let the user move the cursor over the text?