Removing from a list

I'm iterating over a list and I want to remove certain elements from the list but because the list is resizable I'm not quite sure how to do it. In java I would think to use a list iterator. Here's my basic code:

Code:

---

for(list<Obj*>::iterator it = myQueue.begin();it!=myQueue.end();it++)
{
                if(some condition)
                {
                      myQueue.erase(it);
                      it--;
                }
}

---

But the list resizes so if I remove the last element then it will never equal to myQueue.end(). The thing I don't understand is, does myQueue.end point to the last element in the list? I've seen this type of loop used a lot to iterate over a loop but it looks like it will always miss the last element because of the != case, unless the for condition is evaluated at the end.

Code:

---

myQueue.erase(it);

---

should be:

Code:

---

it = myQueue.erase(it);

---

See: Chapter 84. Prefer algorithm calls to handwritten loops

Should I take out the it--?

Quote:

---

Originally Posted by jcafaro10

Should I take out the it--?

---

Since erase() returns an iterator to the element after the one that was erased, I think you'll need it in there, otherwise you'll be skipping over some elements without checking if they match your condition.

The idomatic form of erasing certain elements whilst iterating through a container is:

Code:

---

for (ContainerType::iterator it = container.begin(); it!=container.end(); )
{
        if (condition)
                it = container.erase(it);
        else
                ++it;
}

---

Note the empty part of the for loop between the last semicolon and the close bracket. Use this loop form every time and you wont have any trouble.

There are other options such as the erase/remove_if method that allow you to do the whole thing in one line too.