Storing Words from a text file

Hey I have to write a program that reads a text file that contains a list of words, 1 word per line. I have to store the unique words and count the occurrences of each unique word. When the file is completely read, I have to print the words and the number of occurrences to a text file. The output should be the words in alphabetical order along with the number of times they occur. Then print to the file some statistics.


I have to use character arrays instead of strings. I must use a linear search to determine if a word is in the array. The array is an array of structures and that the key is a char array so the string comparison must be used. The search task should be a separate function.
The search must be a separate function that returns an integer values. I cant use a for loop and the function must have only one return statement.

The linear seach looks something like this-

Code:

---

int search (int list [], int size, int key)
{
    int pos = 0;
    while (pos < size && list[pos] != key)
        pos++;
    if (pos == size)
        pos = -1;
    return pos;
}

---

But Before I search I need to store, which is what I'm having problems with. Heres my store function-

Code:

---

void displayFile (char fileName[], words array[] )
{
        int i = 0;
    ifstream inFile;
       
    char line [101];
       
        inFile.open(fileName);

 while (inFile.getline(line,101))
 { 
        cout << line << endl;
    array[i].word = line;
    i++;
 } 
        inFile.close();

}

---

Where array, is an array of structs made up of character array"word" and an integer "count". Any help on storing the words and the number of words in the array would be helpfull.

Unless I misunderstood something it looks like you have the storing of the word done already, and just need the number of repetitions of the word, right? (i hope?). Each time you read in a line do a linear search on the array of words to see if it already exists.

Code:

---

void displayFile (char fileName[], words array[] )
{
        int i = 0;
    ifstream inFile;
       
    char line [101];
       
        inFile.open(fileName);

 while (inFile.getline(line,101))
 { 
        cout << line << endl;
//shove the search function in here
    array[i].word = line;
    i++;
 } 
        inFile.close();

}

---

Man, all those restrictions... you're really taking the fun out of this, otherwise the whole program would be just a few lines of code using a std::map<std::string,int> container.

Sorry about the first post I wasnt clear with my question. I'm still having trouble on the storing part.

I want to store a text file line by line, where theres one word per line. I tried to store each line with a character array with

array[i].word = line;

but I get the syntax error of "'=': left operand must be a 1-value" so I tried

line = array[i].word;

but that didnt work neither.

Any help would be appreciated.

If you have to use character arrays, then you need to use strcpy to copy a string from one place to another.

Thanks you that worked. I'm now trying to use strncmp to find out the number of unique words (or lines) in the text file. I tried to use-

Code:

---

for( j=0; j<101; j++)
 {       
        n = strcmp( array[j].word, array[j+1]);
       
        if(n != 0);
        uni++;
 }

cout << uni<< endl;
}

---

However that didnt work. I also tried to copy the array again to another character array like this-

for (k=0; k<101; k++)
strncpy(character[k], array[k].word, 20);

and then comparing those two arrays, but that also gave me a syntax error. My instructer gives me these instuctions-

You must use the linear search algorithm to determine if a word is in the array. Remember that the array is an array of structures and that the key is a string (char array) so the string comparison must be used. The search task should be a separate function.
The search must be a separate function that returns an integer values. Do not use a for loop and the function must have only one return statement.

He said not to use a for loop, but I really didnt know another way to go about it. But my for loop doesnt even work.

Well, there are other loops beside for loops. Which is good, because you don't want to hard code 101 in there, I don't think.

Anyway, I don't see what you were trying to do with strncpy, so I can't say anything about that. Your strcmp needs to compare the word you're searching for (which isn't necessarily a word on the list, I think?) with the words that are in the array.

I need to compare words in a text file. In the text file there is only 1 word per line. I need to store the words, count the unique words, and do some other stats. I just realized that my strcmp will only compare 0-1, 1-2, 2-3 ect. Never 0-3. Also there is a max of 100 lines, and a max word length of 20. So I have to use linear search. I'll try that right now, I just wanted to clear some stuff up for you. Thanks for helping.

You would be better off not ever writing a duplicate word to your array. You can do this by reading a line and then searching your array of words for the just-read word. If found, bump the word count. Else, add it to the array and set the count to 1.

You would be better off not ever writing a duplicate word to your array. You can do this by reading a line and then searching your array of words for the just-read word. If found, bump the word count. Else, add it to the array and set the count to 1.

I have a couple of questions about this. Before I compare I need to store the words in an array, so if I compare "line" to "array[i].word" they would always be equal. So I used strcpm(line, array[i+1]). Heres my code-

Code:

---

while (inFile.getline(line,101))
 { 
       
 
  strncpy(array[i].word, line, 20);
       
  n = (strcmp(line, array[i+1].word);

  if( n == 0)
        count++

else {}
       
       
        i++;
   
 }

---

I dont know what to put with the else statment. Should I make a new character array to hold only the uniques words? Also, with this method will array[i].word ever be in the unique array.

Basically, you would do this:

Code:

---

int word_searh( char * word, int size ) {
        int i = size ;
        while (i) {
                if (strcmp(word, words[i-1].word == 0) {
                        words[i-1].count++
                        return size ;  // existing word count bumped, return size of array
            }
          i-- ;
        }
        // Since we got here, the word does not exist. Add it
        strcpy(words[size].word, word) ;
        words[size].count = 1 ;
        return size+1 ;  // new size of array 
}

while (inFile.getline(line,101)) {

        // Search "words" array for a match andadd if new, else
        // bump word count if found
        size = word_search(line, size) ; 
 }

---

NOT SYNTAX CHECKED!! - but that's the concept.

Surely i needs to change in the while-loop?

--
Mats

Fixed it. Thanks.

Ok, heres my revised code-

Code:

---

#include <iostream>
#include <fstream>
#include <cstdlib>
#include <string>
#include <iomanip>
using namespace std;

    int const wordLength = 21;
        int const Num = 100;
        int const fileSize = 255;

        struct words
        {
                char word[wordLength];
                int count;       
        };


       
int storeFile( char [], words []);
void wordSearchSetup(char[], int, words[]);
int wordSearch(char[], int, words[]);

void main ()
{
    int count;
        char fileName[fileSize];
       
        cout << "Please enter the name of the file you wish to open: "<< endl;
        cin.getline(fileName,fileSize);
       
        words array[Num];
       
        count = storeFile (fileName, array);
               
       
        cin.ignore();
}

int storeFile (char fileName[], words array[] )
{       
        int count = 0;
        int i = 0;
    ifstream inFile;
    char line [Num];
       
        inFile.open(fileName);

        while (inFile.getline(line,Num))
        { 
    strncpy(array[i].word, line, wordLength);
        count++;
        i++; 
        } 
       
        inFile.close();

        wordSearchSetup( fileName, count, array);
  return count;
}

void wordSearchSetup(char fileName[], int count, words array[])
{
        char line[Num];
        int i = 0;
        int size;
        ifstream inFile;
        inFile.open(fileName);
       
        while (inFile.getline(line,Num))
        size = wordSearch(line, count, array);
 
        cout << size << endl;

       
}


int wordSearch( char line[], int count, words array[])
{
        int i = count;
       
        while (i)
        {
                if (strcmp(line, array[i-1].word) == 0)
                {
                        array[i-1].count++;
                        return  count; 
        }
          i-- ;
        }
   
        strcpy(array[count].word, line) ;
        array[count].count = 1 ;
        return count+1; 
}

---

My search functions still arent giving me the results I want, it just returns the number of words, not unique words.

Yuk. You're making two passes thru the code when one is enough.

Seeing as you still have work to do, I'll help you over this hump, and you can finish it be doing the proper reporting of stats at the end.

Code:

---

#include <iostream>
#include <fstream>
#include <cstdlib>
#include <string>
#include <iomanip>
using namespace std;

int const wordLength = 21;
int const Num = 100;
int const fileSize = 255;

struct words
{
        char word[wordLength];
        int count;       
};


       
int storeFile( char [], words []);
//void wordSearchSetup(char[], int, words[]);
int wordSearch(char word[], int array_size, words * array);

int main ()
{
        int count;
        char fileName[fileSize];
        count = 0 ;
        cout << "Please enter the name of the file you wish to open: "<< endl;
        cin.getline(fileName,fileSize);
        if (!cin.good() ) {
                cout << "Error reading cin..." << endl ;
                return -1 ;
        }
       
        words array[Num];
       
        count = storeFile(fileName, array);
        cin.ignore();
}

int storeFile (char fileName[], words array[] )
{       
        //int count = 0;
        int i = 0;
        ifstream inFile;
        char line [Num];
        int array_size = 0 ;  // Count of unique words in array
        inFile.open(fileName);

        while (inFile.getline(line,Num))
        { 
                array_size = wordSearch(line, array_size, array);
                //strncpy(array[i].word, line, wordLength);
                //count++;
                i++;  // Words read
        } 
       
        inFile.close();

        //wordSearchSetup( fileName, count, array);
        return count;
}

/*
void wordSearchSetup(char fileName[], int count, words array[])
{
        char line[Num];
        //int i = 0;
        int size;
        ifstream inFile;
        inFile.open(fileName);
       
        while (inFile.getline(line,Num))
        size = wordSearch(line, count, array);
 
        cout << size << endl;       
}
*/

int wordSearch( char line[], int array_size, words * array)
{
        int i = array_size ;  // Start search at the end of the array
       
        while (i && array_size > 0)  // Don't do is there are no elements in array
        {
                if (strcmp(line, array[i-1].word) == 0)  // do the words match?
                {
                        array[i-1].count++;  // Yes, bump the count and return
                        return  array_size ;  // Array size did not change
                }
                i-- ;  // index backwards into array
        }
    // If we got here, we found a unique word.  Add it at the end and return
        strcpy(array[array_size].word, line) ;
        array[array_size].count = 1 ;
        return array_size+1; 
}

---

Thanks a lot, that helps a lot. I'm on my last stat, I have to find the most commonly occuring word(s). Heres my function-

Code:

---

void commonWord(double count[], int array_length, words array[])
{
        int commonCount[Num];
        int max;
        max = count[0];
        int j = 0;
        int i = 0;
        int k = 0;
       
        for(i = 1; i<array_length; i++)
        {
                if(count[i] > max)
                        max = count[i];
                else if( count[i] == max)
                        {
                                commonCount[j] = i;
                                j++;
                        }       
        }
       
        cout<< "The most commonly occuring words are: "<< endl;
       
        for( k = 0; k<array_length; k++)
                cout<< array[commonCount[k]].word<< endl;
}

---

I dont get a compile-time error. But when I run the program, I get a message telling me the .exe file stopped working.

I'm now trying to write my stats to a text file, but its only writing two of the stats, and those stats come from the same function.

Heres the code -

Code:

---

#include <iostream>
#include <fstream>
#include <cstdlib>
#include <string>
#include <iomanip>
using namespace std;

int const wordLength = 21;
int const Num = 100;
int const fileSize = 255;

struct words
{
        char word[wordLength];
        int count;       
};


       
void storeFile(char[], char [], words []);
void displayFile(char[], char[], words[]);
int wordSearch(char word[], int array_size, words []);
void sortSetup(char[], words [], int);
int sort (words [], int, int);
void averageLength(char[], words[], int);
void Occurrence(char[], words[], int);
void commonWord(char[], double[], int, words []);
void averageOccurrence(char[], words[], int);

int main ()
{
       
        words array[Num];
        char fileName[fileSize];
        char out_file_name[fileSize];
       
        cout << "Please enter the name of the file you wish to open: "<< endl;
        cin.getline(fileName,fileSize);
       
        if (!cin.good() ) {
                cout << "Error reading cin..." << endl ;
                return -1 ;
        }
       
        cout<<"Please enter the name of the  file you wish to send the data too" << endl;
        cin.getline(out_file_name,fileSize);
       
        displayFile(out_file_name, fileName, array);
        storeFile(out_file_name, fileName, array);
       
        cin.ignore();
}

void storeFile (char out_file_name[], char fileName[], words array[] )
{       
        ofstream outFile;
        outFile.open(out_file_name);
       
        int i = 0;
        ifstream inFile;
        char line [Num];
        int array_size = 0 ; 
        inFile.open(fileName);

        while (inFile.getline(line,Num))
        { 
                array_size = wordSearch(line, array_size, array);

                i++;   
        } 
       
        inFile.close();

        outFile<< "The number of unique words are: "<< array_size << endl;
        outFile<< "total number of words are: " << i << endl;
        outFile<< endl;

}

 int wordSearch( char line[], int array_size, words array[])
{
        int i = array_size ; 
       
       
        while (i && array_size > 0) 
        {
                if (strcmp(line, array[i-1].word) == 0) 
                {
                        array[i-1].count++; 
                        return  array_size ; 
                }
                i-- ; 
        }
   
        strcpy(array[array_size].word, line) ;
        array[array_size].count = 1 ;
        return array_size+1; 
}

void displayFile (char out_file_name[], char fileName[], words array[] )
{
        int i = 0;
        char line [Num];
       
        ifstream inFile;
        inFile.open(fileName);
       
       
        while (inFile.getline(line,Num))
        { 
       
                strncpy(array[i].word, line, wordLength);
                i++;
        } 
       
    sortSetup(out_file_name, array, i);
    averageLength(out_file_name, array, i);
        Occurrence(out_file_name, array, i);
        averageOccurrence(out_file_name, array, i);
       
        inFile.close();
}

void sortSetup (char out_file_name[], words array [], int array_length)
{
        ofstream outFile;
        outFile.open(out_file_name);
               
        char temp[wordLength];
    int position;
    int i = array_length;
       
    for (int loop = 0; loop < array_length - 1; loop++)
    {
        position = sort (array, loop, array_length - 1);
        if (position != loop)
        {
            strcpy(temp, array[position].word);
            strcpy(array[position].word, array[loop].word);
            strcpy(array[loop].word, temp);
        }
    }
       
        outFile << "The words in alphabetical order are:"<< endl;

        for (int j = 0; j< array_length; j++)
        {
                if(strcmp(array[j].word,array[j-1].word)!=0)
                        outFile << array[j].word << endl;
        }       
       
        outFile << endl;
}


int sort (words array[], int start, int stop)
{
    int n;
        int loc = start;
    for (int pos = start + 1; pos <= stop; pos++)
    {   
                n = (strcmp(array[pos].word, array[loc].word));
               
                if (n < 0)
            loc = pos;
    }
        return loc;
}

void averageLength(char out_file_name[], words array[], int i)
{
        ofstream outFile;
        outFile.open(out_file_name);
       
        double average = 0;
        for(int j = 0; j<i; j++)
                average = average + strlen(array[j].word);
       
        average = average/i;
       
        outFile << "The average length of the words are: " << average <<endl;
        outFile << endl;
}       

void Occurrence(char out_file_name[], words array[], int array_length)
{
        ofstream outFile;
        outFile.open(out_file_name);
       
        int n;
        char cmp_array[wordLength];
        double count[Num];
       
        for( int i= 0; i< array_length; i++)
        {       
                strcpy(cmp_array, array[i].word);
                count[i] = 0;
                for (int j=0; j<array_length; j++)
                {
                        n = (strcmp(array[j].word, cmp_array));
                        if(n == 0)
                        count[i]++;
                }
        }
       
        outFile<<"The unique words and the number of times they appear in the text file appears asthe following:"<< endl;
        outFile<<"word/times it appears:" << endl;
        outFile<< endl;
        for (int k = 0; k< array_length; k++)
        {
                if(strcmp(array[k].word,array[k-1].word)!=0)
                        outFile <<array[k].word << " / " << count[k] <<  endl;
        }
       
        outFile<<endl;
        commonWord(out_file_name, count, array_length, array);
}


void commonWord(char out_file_name[], double count[], int array_length, words array[])
{
        ofstream outFile;
        outFile.open(out_file_name);
       
        int count_max;
        count_max = count[0];
        int j = 0;
        int i = 0;
       
       
        for(i = 1; i<array_length; i++)
        {
                if(count[i] > count_max)
                        count_max = count[i];
        }

        outFile<< "The word(s) that occur the most are: "<< endl;
       
        for( j = 0;  j<array_length; j++)
        {
                if(strcmp(array[j].word,array[j-1].word)!=0)
                {
                  if(count[j] == count_max)
               
                        outFile << array[j].word<< endl;
                }       
        }               

        outFile<< endl;
}               

void averageOccurrence(char out_file_name[], words array[], int array_length)
{
        ofstream outFile;
        outFile.open(out_file_name);
       
        int n;
        char cmp_array[wordLength];
        double count[Num];
       
        for( int i= 0; i< array_length; i++)
        {       
                strcpy(cmp_array, array[i].word);
                count[i] = 0;
                for (int j=0; j<array_length; j++)
                {
                        n = (strcmp(array[j].word, cmp_array));
                        if(n == 0)
                        count[i]++;
                }
        }
       
        outFile<<"The average occurence of a word appears as the following:" << endl; outFile <<"word/average appearence:" << endl;
        outFile<< endl;
        for (int k = 0; k< array_length; k++)
        {
                if(strcmp(array[k].word,array[k-1].word)!=0)
                        outFile <<array[k].word << " / " << count[k]/array_length <<  endl;
        }
       
        outFile<<endl;
}#include <iostream>
#include <fstream>
#include <cstdlib>
#include <string>
#include <iomanip>
using namespace std;

int const wordLength = 21;
int const Num = 100;
int const fileSize = 255;

struct words
{
        char word[wordLength];
        int count;       
};


       
void storeFile(char[], char [], words []);
void displayFile(char[], char[], words[]);
int wordSearch(char word[], int array_size, words []);
void sortSetup(char[], words [], int);
int sort (words [], int, int);
void averageLength(char[], words[], int);
void Occurrence(char[], words[], int);
void commonWord(char[], double[], int, words []);
void averageOccurrence(char[], words[], int);

int main ()
{
       
        words array[Num];
        char fileName[fileSize];
        char out_file_name[fileSize];
       
        cout << "Please enter the name of the file you wish to open: "<< endl;
        cin.getline(fileName,fileSize);
       
        if (!cin.good() ) {
                cout << "Error reading cin..." << endl ;
                return -1 ;
        }
       
        cout<<"Please enter the name of the  file you wish to send the data too" << endl;
        cin.getline(out_file_name,fileSize);
       
        displayFile(out_file_name, fileName, array);
        storeFile(out_file_name, fileName, array);
       
        cin.ignore();
}

void storeFile (char out_file_name[], char fileName[], words array[] )
{       
        ofstream outFile;
        outFile.open(out_file_name);
       
        int i = 0;
        ifstream inFile;
        char line [Num];
        int array_size = 0 ; 
        inFile.open(fileName);

        while (inFile.getline(line,Num))
        { 
                array_size = wordSearch(line, array_size, array);

                i++;   
        } 
       
        inFile.close();

        outFile<< "The number of unique words are: "<< array_size << endl;
        outFile<< "total number of words are: " << i << endl;
        outFile<< endl;

}

 int wordSearch( char line[], int array_size, words array[])
{
        int i = array_size ; 
       
       
        while (i && array_size > 0) 
        {
                if (strcmp(line, array[i-1].word) == 0) 
                {
                        array[i-1].count++; 
                        return  array_size ; 
                }
                i-- ; 
        }
   
        strcpy(array[array_size].word, line) ;
        array[array_size].count = 1 ;
        return array_size+1; 
}

void displayFile (char out_file_name[], char fileName[], words array[] )
{
        int i = 0;
        char line [Num];
       
        ifstream inFile;
        inFile.open(fileName);
       
       
        while (inFile.getline(line,Num))
        { 
       
                strncpy(array[i].word, line, wordLength);
                i++;
        } 
       
    sortSetup(out_file_name, array, i);
    averageLength(out_file_name, array, i);
        Occurrence(out_file_name, array, i);
        averageOccurrence(out_file_name, array, i);
       
        inFile.close();
}

void sortSetup (char out_file_name[], words array [], int array_length)
{
        ofstream outFile;
        outFile.open(out_file_name);
               
        char temp[wordLength];
    int position;
    int i = array_length;
       
    for (int loop = 0; loop < array_length - 1; loop++)
    {
        position = sort (array, loop, array_length - 1);
        if (position != loop)
        {
            strcpy(temp, array[position].word);
            strcpy(array[position].word, array[loop].word);
            strcpy(array[loop].word, temp);
        }
    }
       
        outFile << "The words in alphabetical order are:"<< endl;

        for (int j = 0; j< array_length; j++)
        {
                if(strcmp(array[j].word,array[j-1].word)!=0)
                        outFile << array[j].word << endl;
        }       
       
        outFile << endl;
}


int sort (words array[], int start, int stop)
{
    int n;
        int loc = start;
    for (int pos = start + 1; pos <= stop; pos++)
    {   
                n = (strcmp(array[pos].word, array[loc].word));
               
                if (n < 0)
            loc = pos;
    }
        return loc;
}

void averageLength(char out_file_name[], words array[], int i)
{
        ofstream outFile;
        outFile.open(out_file_name);
       
        double average = 0;
        for(int j = 0; j<i; j++)
                average = average + strlen(array[j].word);
       
        average = average/i;
       
        outFile << "The average length of the words are: " << average <<endl;
        outFile << endl;
}       

void Occurrence(char out_file_name[], words array[], int array_length)
{
        ofstream outFile;
        outFile.open(out_file_name);
       
        int n;
        char cmp_array[wordLength];
        double count[Num];
       
        for( int i= 0; i< array_length; i++)
        {       
                strcpy(cmp_array, array[i].word);
                count[i] = 0;
                for (int j=0; j<array_length; j++)
                {
                        n = (strcmp(array[j].word, cmp_array));
                        if(n == 0)
                        count[i]++;
                }
        }
       
        outFile<<"The unique words and the number of times they appear in the text file appears asthe following:"<< endl;
        outFile<<"word/times it appears:" << endl;
        outFile<< endl;
        for (int k = 0; k< array_length; k++)
        {
                if(strcmp(array[k].word,array[k-1].word)!=0)
                        outFile <<array[k].word << " / " << count[k] <<  endl;
        }
       
        outFile<<endl;
        commonWord(out_file_name, count, array_length, array);
}


void commonWord(char out_file_name[], double count[], int array_length, words array[])
{
        ofstream outFile;
        outFile.open(out_file_name);
       
        int count_max;
        count_max = count[0];
        int j = 0;
        int i = 0;
       
       
        for(i = 1; i<array_length; i++)
        {
                if(count[i] > count_max)
                        count_max = count[i];
        }

        outFile<< "The word(s) that occur the most are: "<< endl;
       
        for( j = 0;  j<array_length; j++)
        {
                if(strcmp(array[j].word,array[j-1].word)!=0)
                {
                  if(count[j] == count_max)
               
                        outFile << array[j].word<< endl;
                }       
        }               

        outFile<< endl;
}               

void averageOccurrence(char out_file_name[], words array[], int array_length)
{
        ofstream outFile;
        outFile.open(out_file_name);
       
        int n;
        char cmp_array[wordLength];
        double count[Num];
       
        for( int i= 0; i< array_length; i++)
        {       
                strcpy(cmp_array, array[i].word);
                count[i] = 0;
                for (int j=0; j<array_length; j++)
                {
                        n = (strcmp(array[j].word, cmp_array));
                        if(n == 0)
                        count[i]++;
                }
        }
       
        outFile<<"The average occurence of a word appears as the following:" << endl; outFile <<"word/average appearence:" << endl;
        outFile<< endl;
        for (int k = 0; k< array_length; k++)
        {
                if(strcmp(array[k].word,array[k-1].word)!=0)
                        outFile <<array[k].word << " / " << count[k]/array_length <<  endl;
        }
       
        outFile<<endl;
}

---

The "storeFile" function is the only one that prints to the file.
BTW I know this code is unorganized and not the best way to do it, but this project is due tomorrow (12-10) so I'm just trying to turn in what I have.

They each write out to the file just fine. But of course, since each function starts by erasing the file before writing to it....

Thanks for the quick reply. I started messing with "outFile.put(out_file_name);" but that didnt work. Out professor told us only to read the first two chapters on "I/O File Streams and Data Files". However it wasn't intill the 5th chapter where it starts explaining file stream as function arguments. So I wonder why he didnt make that chapter assign reading. Well anyways this thread is solved.