Delete Array of Pointers

Hi,

I have an array of pointers:

Code:

---

Bitmap*    g_pTank[3];

---

I have a problem cleaning them up...

Code:

---

    for (int i = 0; i < 3; ++i)
  {
          delete []g_pTank[i];
  }
 
  delete []g_pTank;

---

The game crashes when closing down. In particular due to the last line of code:

Code:

---

delete []g_pTank;

---

But g_pTank is not allocated, only the elements in the array are, right?

It would help if you posted the code that allocates the memory.

--
Mats

Also remember to use delete [] only when you've used new [].
But since this is C++, you should probably be using smart pointers anyway.

Thanks guys.

Here was the code of initialisation - didnt realise I forgot to post it

Code:

---

  g_pTank[0] = new Bitmap(hDC, IDB_TANK, g_hInstance);
  g_pTank[1] = new Bitmap(hDC, IDB_TANK2, g_hInstance);
  g_pTank[2] = new Bitmap(hDC, IDB_TANK3, g_hInstance);

---

What do you think now?

You can use smart pointers. If not, then use delete on each element and not on the array itself.

Quote:

---

Originally Posted by Elysia

You can use smart pointers. If not, then use delete on each element and not on the array itself.

---

smart pointers?

In which case, you should use delete (without []) for the three array elements, and not at all for the array itself.

--
Mats

http://msdn.microsoft.com/en-us/library/bb982026.aspx
Or if you don't understand, the smart pointer takes ownership of the memory and frees it itself, freeing the burden from the programmer.