choice error

I'm having trouble with two nearly identical blocks of code in my program:

Code:

---

do
    {
            cout<<"What is your charater's name?\n";
            cin.ignore();
            getline( cin, yourname);
            do
            {
              cout<<"Your character's name is "<<yourname<<". Is that okay?\n";
              getline( cin, choice);
            } while (toupper(choice[0]) != 'y' && toupper(choice[0]) != 'n');
            if (toupper(choice[0] == 'n'))
            {
                  ok=false;
            }
            else
            {
                ok=true;
            }
    }while (ok==false);

---

It stays at the prompt without advancing past it, no matter what garbage is typed in.

How is toupper(anything) going to equal 'y'?

It's code I got off of a question I asked a couple of months ago. http://cboard.cprogramming.com/showthread.php?t=106347

It was to equate any input beginning with 'y' to 'y'. The code didn't act up until recently.

Except you did an extremely poor job of it. 'Y' is an uppercase letter; 'y' is not.

I intended for all input to be in lowercase. This code worked until recently, and both places where it was placed stopped working.

EDIT: I'm pretty sure I didn't change the check to lowercase, as the other place the code stopped working is the (until recently) woking version of the save function in the other thread.

If you want lowercase, then you should use tolower, not toupper.

And try to actually understand what you are typing. Don't just blindly type the code like a monkey.

That fixed it, thank you. That makes me feel stupid.

Quote:

---

Originally Posted by DarkAlex

That fixed it, thank you. That makes me feel stupid.

---

But you have to admit it was funny.

Yep, I do have to admit that. I also noticed that I had made this error in other areas of the program that would not have been good there. I also noticed that I had used == instead of = in three places.