problem in my strcpy strcat function

i m trying to write my own function of strcpy and strcat but 2nd character doesnt even getoutputed

Code:

---

#include <stdio.h>
int main(void){
        char name[21];
        char surname[21];
        char buffer[46];
        int a,b;
        printf("Please Enter your first name:  ");
        scanf("%[^\n]",name);
    printf("Please Enter your surname name:  ");
        scanf("%[^\n]",surname);
        for(a=0;name[a]='\0';a++);
        buffer[a]=name[a];
        buffer[a]=' ';
        for(b=0;surname[b]!='\0';b++,a++){
        buffer[b]=surname[b];
        }printf("Here is ur both value :  ",buffer);
        return 0;}

---

Quote:

---

Originally Posted by genie

i m trying to write my own function of strcpy and strcat but 2nd character doesnt even getoutputed

Code:

---

#include <stdio.h>
int main(void){
        char name[21];
        char surname[21];
        char buffer[46];
        int a,b;
        printf("Please Enter your first name:  ");
        scanf("%[^\n]",name);
    printf("Please Enter your surname name:  ");
        scanf("%[^\n]",surname);
        for(a=0;name[a]='\0';a++);  /*I wonder what you expect this to do? */
        buffer[a]=name[a]; /*This line has no effect, since you immediately change it below*/
        buffer[a]=' ';
        for(b=0;surname[b]!='\0';b++,a++){
        buffer[b]=surname[b];
        }printf("Here is ur both value :  ",buffer);
        return 0;}

---

---

See comments.

for loop i want it just to get name like from variable 0 untill null terminator and in the buffer i want it to save the first name till i print both in the end

Well your for loop currently just sets name[0] to '\0', effectively wiping out the string, and that's it. Notice also that there are no statements in your for loop (the for loop goes from the end parenthesis to the next semicolon, which conveniently is the very next character). If you intend the next line to be in the for loop, you should probably fix that. Note also that you do not have a check in your for loop, but an assignment.

here almost done it but prints weird characters along

Code:

---

#include <stdio.h>
int main(void){
        char name[21];
        char surname[21];
        char buffer[46];
        int a,b;
        printf("Please Enter your first name:  ");
        scanf("&#37;s",name);
    printf("Please Enter your surname name:  ");
        scanf("%s",surname);
        for(a=0;name[a]!='\0';a++)
        buffer[a]=name[a];
        buffer[a]=' ';
        a++;
        for(b=0;surname[b]!='\0';b++,a++){
        buffer[a]=surname[b];
        }printf("Here is ur both value : %s ",buffer);
        return 0;}

---

Strings don't end until there is a '\0'. If you don't put one in, the string won't end.

Ugh, what horrible looking code.

Use consistent indentation to make your program flow very clear.
Use newlines to separate functional steps.

Code:

---

#include <stdio.h>
int main(void){
    char name[21];
    char surname[21];
    char buffer[46];
    int a,b;
   
    printf("Please Enter your first name:  ");
    scanf("&#37;s",name);
    printf("Please Enter your surname name:  ");
    scanf("%s",surname);
   
    for(a=0;name[a]!='\0';a++){
        buffer[a]=name[a];
    }

    buffer[a]=' ';
    a++;

    for(b=0;surname[b]!='\0';b++,a++){
        buffer[a]=surname[b];
    }

    printf("Here is ur both value : %s ",buffer);
    return 0;
}

---

yah i got it fixed thanks