These string arrays are a pain!

Hi,

can someone tell me when I have code like this:

Code:

---

#import <stdio.h>
#import <string.h>

int main (int argc, char const *argv[])
{
        int userInput, printableInt, x = 0;

        char singleDigits[20];

        printf("Enter a positive integer or a negative one to quit: ");
        scanf("%i", &userInput);

        printf("\n\n");

        while ( userInput > 0 )
                {
                printableInt = userInput % 10;

                userInput /= 10;

                switch (printableInt)
                        {
                        case 0:
                                singleDigits[x] = "Zero, ";
                                x += 1;
                                break;

                        case 1:
                                singleDigits[x] = "One, ";
                                x += 1;
                                break;

                        case 2:
                                singleDigits[x] = "Two, ";
                                x += 1;
                                break;
       
                        case 3:
                                singleDigits[x] = "Three, ";
                                x += 1;
                                break;

                        case 4:
                                singleDigits[x] = "Four, ";
                                x += 1;
                                break;

                        case 5:
                                singleDigits[x] = "Five, ";
                                x += 1;
                                break;

                        case 6:
                                singleDigits[x] = "Six, ";
                                x += 1;
                                break;
                       
                        case 7:
                                singleDigits[x] = "Seven, ";
                                x += 1;
                                break;

                        case 8:
                                singleDigits[x] = "Eight, ";
                                x += 1;
                                break;

                        case 9:
                                singleDigits[x] = "Nine, ";
                                x += 1;

                        default:
                                singleDigits[x] = "Unknown ";
                                x += 1;
                                break;
                        }
                for ( ; x > 0; --x)
                        printf("%s", singleDigits[x]);
                }
}

---

Do I get the ubiquitous error:

main.m:24: warning: assignment makes integer from pointer without a cast

for every line that tries to assign a string to the array at index x?

I have trolled the forum to try to understand this error and the nearest I came to was the right side of the = is returning an int and the left side is expecting a pointer?

I am having on going problems trying to assign simple strings to what has to be char arrays??

thanks in advance

char *singleDigits[20];
would be the thing you need here.

That's because you are trying to assign a string of characters to a single element of the char array singleDigits[] ie

Code:

---

singleDigits[x] = "Zero, ";

---

what you ought to be doing is

Code:

---

singleDigits[] = "Zero, ";

---

Quote:

---

Originally Posted by FreeCare

[Why] do I get the ubiquitous error:

main.m:24: warning: assignment makes integer from pointer without a cast

for every line that tries to assign a string to the array at index x?

I have trolled the forum to try to understand this error and the nearest I came to was the right side of the = is returning an int and the left side is expecting a pointer?

I am having on going problems trying to assign simple strings to what has to be char arrays??

thanks in advance

---

You get that error because you're trying to assign a string to a character.
You'd still get an error if you tried to assign a string to a string. In C you have to copy every character individually using strcpy() or strncpy()...

Quote:

---

Originally Posted by Salem

char *singleDigits[20];
would be the thing you need here.

---

I would make that
const char* singleDigits[20];

Quote:

---

Originally Posted by itCbitC

...what you ought to be doing is

Code:

---

singleDigits[] = "Zero, ";

---

---

That doesn't work. You have to specify the index.

Anyhow, this is just something you have to deal with due to C being so low level. If you do not like it, there are other higher level languages that can avoid you this pain.
C++, Java, C#, VB, etc.

Oh and x += 1 is the same thing as x++.

Just to intrigue you a bit to look at C++, you could not change your code at all except this:

Code:

---

#include <string> //instead of <string.h>
using namespace std;
...
string singleDigits[20];

---

Now you can assign string literals (like "Zero") to a string as you do.

Oh yes const char *singleDigits[20] is the way to go as in fact they are an array of pointers to char strings.

Thank you all for the replies!

I programmed in C / C++ many moons ago but need to relearn it now.

I have for many a year now been programming in VB.NET hence by struggle to get back to grips with the low levelness of C, which I do like......just have to remember it all!!

Shall have a play with the tips provided, thanks again

Well then, is there a specific reason for C? C++ will not do?
Just asking because C++ might be easier if you are used to a higher-level language such as VB dotNet.

Sure, I have to learn Objective-C and am working thru the book by Stephen Kochan with the aim to getting into programming the iPhone.

So am in a crash course on Objective C to get up to speed. The chapters I am currently working thru are familiarisation with C I guess before jumping into the object stuff.